1.12.2 Use 2 blockstates

[RoyalReject]

So I currently have my block class setup and wanted my block to change face based on its direction no big deal, but I also use the same class to register different blocks via Enum values, basically I am trying to return 2 blockstates and wondered if it was possible. Because currently I can get it to rotate, but all blocks have same texture, otherwise i can get it to have different textures but then it no longer rotates 

 

public class BlockTier extends Block{
	public static final PropertyEnum<EnumTier> TIER = PropertyEnum.create("tier", EnumTier.class);
	public static final IProperty<EnumFacing> FACING = BlockHorizontal.FACING;
	
	public BlockTier(Material m, MapColor c) {
		super(m, c);
	}
	
	@Nonnull
	@Override
	protected BlockStateContainer createBlockState() {
		return new BlockStateContainer(this, TIER, FACING);
	}
	
	@Override
	@Deprecated
	public IBlockState getStateFromMeta(int meta){
		return this.getDefaultState().withProperty(FACING, EnumFacing.byHorizontalIndex(meta)).withProperty(TIER, EnumTier.byMeta(meta));
      //FIXED 
		
	}

	@Override
	public int getMetaFromState(IBlockState state){
		return state.getValue(TIER).ordinal() + state.getValue(FACING).getHorizontalIndex();
	}

	@Override
	public boolean hasTileEntity(IBlockState state){
		return true;
	}

	@Override
	public int damageDropped(IBlockState state){
		return state.getValue(TIER).ordinal();
	}

	@Override
	public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items){
		for (EnumTier tier : EnumTier.VALUES){
			items.add(new ItemStack(this, 1, tier.ordinal()));
		}
	}
	
	@Nonnull
	@Override
	public IBlockState getStateForPlacement(@Nonnull World world, @Nonnull BlockPos pos, @Nonnull EnumFacing facing, float hitX, float hitY, float hitZ, int meta, @Nonnull EntityLivingBase placer, EnumHand hand){
		return getStateFromMeta(meta).withProperty(FACING, placer.getHorizontalFacing().getOpposite());
	}

 

Edited April 5, 2019 by RoyalReject
Fixed

[Draco18s]

Blockstates aren't magic. They're just a more developer-friendly way of expressing the same information that has always been there: metadata. Metadata is still limited to 16 possible unique states, so with your current code you have a FACING value that has 4 distinct states. This means that your TIER value can only have 4 distinct states that fit within metadata.

 

That said, you shouldn't be using metadata to store "different" blocks at this point. Once you update your mod for 1.13, you'll have to flatten those metadata values back into separate block instances, so you may as well just do that now.

[RoyalReject]

If that was the case i have 5 different enums in tier and it work? or I just misunderstanding you?

[Draco18s]

48 minutes ago, RoyalReject said:

If that was the case i have 5 different enums in tier and it work? or I just misunderstanding you?

Either:

• 4 or fewer enum values
• Separate blocks

[RoyalReject]

2 hours ago, Draco18s said:

Either:

• 4 or fewer enum values
• Separate blocks

Would it be possible to store anymore states in a tileEntity to affect the texture and/or orientation of the block?

[Cadiboo]

You can’t store blockstates as a tile entity. You can have an infinite amount of variables in a tile entity though which is probably what you meant.

[RoyalReject]

I ended up creating a TileEntity and got it to store its Facing value in nbt.

public class TileCollector extends TileEntity implements ITickable{
	private EnumFacing facing;
	
	public EnumFacing getFacing(){
		if(facing != null) {
			return facing;
		}
		return EnumFacing.NORTH;
	}

	@Override
	public void update(){
		// TODO Auto-generated method stub		
	}
	
	public void setFacing(EnumFacing facing){		 
		 this.facing = facing;
		 markDirty();
	}
	
	@Override
	 public void readFromNBT(NBTTagCompound compound) {
		 facing = EnumFacing.byHorizontalIndex(compound.getInteger("Facing"));
		 super.readFromNBT(compound);		
	 }
	 
	 @Override
	 public NBTTagCompound writeToNBT(NBTTagCompound compound){
		 super.writeToNBT(compound);
		 compound.setInteger("Facing", facing.getHorizontalIndex());
		 return compound;		 
	 }
	 
	 @Override
	 public SPacketUpdateTileEntity getUpdatePacket(){
	     return new SPacketUpdateTileEntity(this.pos, 1, this.getUpdateTag());
	 }

	 @Override
	 public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt){
		 super.onDataPacket(net, pkt);
		 handleUpdateTag(pkt.getNbtCompound());
	 }
	 
	 @Override
	public NBTTagCompound getUpdateTag(){
		 return this.writeToNBT(new NBTTagCompound());
	}
}	

 

And then changed by block class to overtire

	@Override
	public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos){			
		TileCollector collector = (TileCollector) worldIn.getTileEntity(pos);
		return state.withProperty(FACING, collector.getFacing());	
	}
	
	@Override
	public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack){		
		TileCollector collector = (TileCollector) worldIn.getTileEntity(pos);;
		collector.setFacing(placer.getHorizontalFacing().getOpposite());		
	}

 

[desht]

Don't call World#getTileEntity() directly from getActualState() (or getExtendedState()), or you could end up with mysterious crashes and other flakiness.  Read the warning section here for a full explanation of why: https://mcforge.readthedocs.io/en/latest/blocks/states/#actual-states

 

A safer version (for use by getActualState()/getExtendedState()) looks like this:

 

public static TileEntity getTileEntitySafely(IBlockAccess world, BlockPos pos) {
    return world instanceof ChunkCache ?
            ((ChunkCache) world).getTileEntity(pos, Chunk.EnumCreateEntityType.CHECK) :
            world.getTileEntity(pos);
}

Edited April 8, 2019 by desht

[Cadiboo]

The above code won't quite work with OptiFine because it replaces ChunkCache with its own implementation, you can ignore this if you don't particularly care about compatibility. I can't think of how to solve this problem easily otherwise I would provide a solution