[1.13.2] GUI wont open

[TheRedMelon]

I right click on the block and nothing happens.  All relevant code below.  If I'm missing something you need to see, just let me know ?.

I've looked at previous threads where people ask for help and looked for their code as examples but can't figure out where I'm going wrong.

 

GUI Class:

Spoiler

public class GUIThreefoldCombiner extends GuiContainer {
	
	private static final ResourceLocation TEXTURE = new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");
	
	public GUIThreefoldCombiner(InventoryPlayer inventory, TileEntityThreefoldCombiner te) {
		
		super(new ContainerThreefoldCombiner(inventory, te));
		
	}
	
	@Override
	public void render(int mouseX, int mouseY, float partialTicks) {

		drawDefaultBackground();
		super.render(mouseX, mouseY, partialTicks);
		renderHoveredToolTip(mouseX, mouseY);
		
	}

	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		
		mc.getTextureManager().bindTexture(TEXTURE);
		drawModalRectWithCustomSizedTexture(guiLeft, guiTop, 0, 0, xSize, ySize, xSize, ySize);
		
	}
	
}

 

 

Main Class with GUI Handler:

Spoiler

@Mod(Reference.MOD_ID)
public class EnhancedMechanisms {

	public EnhancedMechanisms() {
		
		ModLoadingContext.get().registerExtensionPoint(ExtensionPoint.GUIFACTORY, () -> {
			
			return (OpenContainer) -> {
				
				ResourceLocation loc = OpenContainer.getId();
				
				if (loc.toString().equals(Reference.MOD_ID + ":threefold_combiner")) {
					
					EntityPlayerSP player = Minecraft.getInstance().player;
					BlockPos pos = OpenContainer.getAdditionalData().readBlockPos();
					TileEntity te = player.world.getTileEntity(pos);
					
					if (te instanceof TileEntityThreefoldCombiner) {
						
						return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);
						
					}
					
				}
				
				return null;
				
			};
			
		});
		
	}
	
}

 

 

onBlockActived:

Spoiler

	@Override
	public boolean onBlockActivated(IBlockState state, World worldIn, BlockPos pos, EntityPlayer player, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ) {
		
		if (worldIn.isRemote) {
			
			return true;
			
		} else {
			
			TileEntity tEntity = worldIn.getTileEntity(pos);
			
			if (tEntity instanceof TileEntityThreefoldCombiner) {
				
				NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
			}
			
			return true;
			
		}
		
	}

 

 

Tile Entity createContainer & getGuiID:

Spoiler

	@Override
	public Container createContainer(InventoryPlayer playerInventory, EntityPlayer playerIn) {

		return new ContainerThreefoldCombiner(playerInventory, this);
		
	}

	@Override
	public String getGuiID() {

		return Reference.MOD_ID + ":threefold_combiner";
		
	}

 

 

Tile Entity Registry:

Spoiler

	public static TileEntityType<TileEntityThreefoldCombiner> tileEntityThreefoldCombiner;

	@SubscribeEvent
	public static void OnRegisterTileEntities (RegistryEvent.Register<TileEntityType<?>> e) {
		
		tileEntityThreefoldCombiner = TileEntityType.register(Reference.MOD_ID + ":threefold_combiner", TileEntityType.Builder.create(TileEntityThreefoldCombiner::new));
		
	}

 

 

Thanks for any help.

[Cadiboo]

9 hours ago, TheRedMelon said:

new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");

Don’t use this constructor, use the constructor that takes in your modid and the path as separate parameters.

 

9 hours ago, TheRedMelon said:

NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);

I’m not sure that this is the correct way to open a mod GUI in 1.13.2.

[KingIceCream]

above the method openGui in NetworkHooks, it specifically says "Request to open a GUI on the client, from the server", so I'm pretty sure this isn't the correct method. We used to use the openGui method in EntityPlayer, but that no longer exists, nor does the class FMLNetworkHandler exist.

Edited April 17, 2019 by KingIceCream

[KingIceCream]

Hold on, try replacing 

if (worldIn.isRemote) {
			
	return true;
			
} else {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
			
	if (tEntity instanceof TileEntityThreefoldCombiner) {
				
		NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
	}
			
	return true;
			
}

with

if (!worldIn.isRemote) {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
	NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
}
return true;

 

[TheRedMelon]

I'm using the proper ResourceLocation  constructor now.

I tried changing that code like KingIceCream said, it basically does the same thing though so nothing changed.  I followed it through with the debugger and it gets to the GUI Factory and runs

return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);

So I think the issue is with the GUI or Container perhaps.

[KingIceCream]

Could you post or dm me all of the code so I can try to debug it more easily? (Like, all the code. To DM me, just click on my profile and click the "message button")

[Cadiboo]

4 hours ago, KingIceCream said:

Could you post or dm me all of the code so I can try to debug it more easily? (Like, all the code.

The best way to do this is to post your code as a working GitHub repository 

[DavidM]

Can you post your code as a GitHub repo?

[TheRedMelon]

Yeah here you go: https://github.com/TheRedMelon/Enhanced-Mechanisms

Sorry for the late reply.

[TheRedMelon]

Ah I see, I've fixed it now, thank you.  I just checked and saw that its the exact same line in the furnace's tile entity which is where I got the line from, why is it there and why does it work?

[TheRedMelon]

Oh thats that the mistake was, sorry I was confused about what the line did when I just looked at it.  Thank you.