1.12.2 need help for my datafixer

[TheRPGAdventurer]

So i needed data fixer because an amulet item that stores the dragons and respawn them saving the nbt data like health breed stuff like has been compressed from 13 registered names corresponding to dragon breeds to one amulet itself. so i need to data fix them. Now it doesnt work so it seems like im doing something wrong here. Also the breed was saved in the amulets inititialize instead of the nbt (now it is) how do i add that breed in?

 

this was derived especially from ItemTotemRename.class, it doesnt have an initizlization and im not sure how

DataFixer: https://pastebin.com/41vi5n4J

Registry: 

package com.TheRPGAdventurer.ROTD.datafix;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.datafix.IFixableData;

public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 2;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}

 

[DavidM]

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

Edited May 14, 2019 by DavidM

[TheRPGAdventurer]

1 hour ago, DavidM said:

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

i removed the else and left with only if statemets whats left to do it still doesnt fire up

[TheRPGAdventurer]

12 hours ago, DavidM said:

public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 1;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        if ("dragonmounts:storm_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}

[TheRPGAdventurer]

Ok someone debugged it and it say that the "id" nbt is null. Does registering an Item make an nbt already?

[Ruukas]

Items (or rather, ItemStacks) usually does not have an nbt tag, when first created.

[TheRPGAdventurer]

how was their "id" set then when we call Item.setRegistryName or Item.etUnlocalizedName or Item.setTranslationKey

[Cadiboo]

setRegistryName sets the registry name of the Item

setTranslationKey sets the translation key of the Item

 

none of them set the ItemStack’s NBT or the “id” in the ItemStack’s NBT

[TheRPGAdventurer]

so how do i restore items from old world saves without calling in the "id" in DataFixers.  As much as i can ee in Choonsters code when he helped me in datafixers i dont see him setting an ID.