Jump to content

Recommended Posts

Posted

So i needed data fixer because an amulet item that stores the dragons and respawn them saving the nbt data like health breed stuff like has been compressed from 13 registered names corresponding to dragon breeds to one amulet itself. so i need to data fix them. Now it doesnt work so it seems like im doing something wrong here. Also the breed was saved in the amulets inititialize instead of the nbt (now it is) how do i add that breed in?

 

this was derived especially from ItemTotemRename.class, it doesnt have an initizlization and im not sure how

DataFixer: https://pastebin.com/41vi5n4J

Registry: 

package com.TheRPGAdventurer.ROTD.datafix;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.datafix.IFixableData;

public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 2;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        } else if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}

 

Posted (edited)

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

Edited by DavidM

Some tips:

  Reveal hidden contents

 

Posted
  On 5/14/2019 at 6:39 AM, DavidM said:

Irrelevant: You might want to use something like regex to clean up that bunch of if elses.

Using sub-string to check if the last few characters equal to "dragon_amulet" would also work. Just don't use a bunch of if elses.

Expand  

i removed the else and left with only if statemets whats left to do it still doesnt fire up

Posted
  On 5/14/2019 at 6:39 AM, DavidM said:
public class DragonMountsItemDataFixes implements IFixableData {

    @Override
    public int getFixVersion() {
        return 1;
    }

    // is the fixTag proper (I think this is the cause tho) derived from PotionItem.class
    public NBTTagCompound fixTagCompound(NBTTagCompound compound) {
        if ("dragonmounts:end_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:nether_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:skeleton_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:wither_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:forest_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:fire_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:water_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:sunlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:enchant_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:terra_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }
        if ("dragonmounts:moonlight_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        if ("dragonmounts:storm_dragon_amulet".equals(compound.getString("id"))) {
            compound.setString("id", "dragonmounts:dragon_amulet");
        }

        return compound;
    }
}
Expand  
Posted

setRegistryName sets the registry name of the Item

setTranslationKey sets the translation key of the Item

 

none of them set the ItemStack’s NBT or the “id” in the ItemStack’s NBT

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • UPDATE: this seems to be an Arch-specific issue. Switching to Ubuntu server fixed EVERYTHING.
    • Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.