Jump to content

Set items in Container


Schleim_time

Recommended Posts

I tried out to set items in my container if i place something in the right place but the problem i got is that i cant see the item until i click on the slot and than it will appear.  I tried detectandsendchanges, getslot and putiteminslot and tried to set an itemstack to my slot, i also tried to use .update or something but it all dont worked, i recieve the item but the are not visible until you interact with the right slot, how can i fix that problem? Also i tried to use oncraftmatrixchanged but that dont even return me a sysout

Link to comment
Share on other sites

Show your code.

I've realized that you are reluctant in showing your code in many of your post. Why?

It is hard to help you if you don't show your code.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

3 hours ago, DavidM said:

Show your code.

I've realized that you are reluctant in showing your code in many of your post. Why?

It is hard to help you if you don't show your code.

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import java.util.ArrayList;
import java.util.List;

import com.Schleimtime.Wasteland.blocks.forgebench.slots.Outputslot;
import com.Schleimtime.Wasteland.init.moditems;

import net.minecraft.client.gui.inventory.GuiCrafting;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.ContainerWorkbench;
import net.minecraft.inventory.IContainerListener;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.InventoryCrafting;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraftforge.items.ItemStackHandler;

public class forgebenchcontainer extends Container{
    
    private forgetileentity tileentity;

public forgebenchcontainer(InventoryPlayer player, forgetileentity tyleentity) {
        this.tileentity = tyleentity;
        
        
        this.addSlotToContainer(new Slot(tyleentity, 0, 30, 17));
        this.addSlotToContainer(new Slot(tyleentity, 1, 48, 17));
        this.addSlotToContainer(new Slot(tyleentity, 2, 66, 17));
        
        this.addSlotToContainer(new Slot(tyleentity, 3, 30, 35));
        this.addSlotToContainer(new Slot(tyleentity, 4, 48, 35));
        this.addSlotToContainer(new Slot(tyleentity, 5, 66, 35));
        
        this.addSlotToContainer(new Slot(tyleentity, 6, 30, 53));
        this.addSlotToContainer(new Slot(tyleentity, 7, 48, 53));
        this.addSlotToContainer(new Slot(tyleentity, 8, 66, 53));
        
        this.addSlotToContainer(new Outputslot(tyleentity, 9, 124, 35));
        
        
        
        for(int y = 0; y < 3; y++) {
            for(int x = 0; x < 9; x++) {
                this.addSlotToContainer(new Slot(player, x+y*9+9, 8+x*18, 84+y*18));
            }
        }
        
        for(int x = 0; x < 9; x++) {
            this.addSlotToContainer(new Slot(player, x, 8+x*18, 142));
        }
        
        
    }

    @Override
    public boolean canInteractWith(EntityPlayer playerIn) {
        return true;
    }
    
    @Override
    public void detectAndSendChanges() {
        if(tileentity.getStackInSlot(1).getItem() == Items.IRON_INGOT) {
            System.out.println("lol");
            tileentity.setInventorySlotContents(9, new ItemStack(moditems.BRONZE_INGOT));
        }
    }

    
    @Override
    public void onContainerClosed(EntityPlayer playerIn) {
        ArrayList<ItemStack> itemlist = new ArrayList<ItemStack>();
        for(int x = 0; x < 9; x++) {
            ItemStack stack = tileentity.getStackInSlot(x);
            if(stack!=null) {
                itemlist.add(stack);
            }
        }
        if(!itemlist.isEmpty()) {
            for(ItemStack item : itemlist) {
            playerIn.inventory.addItemStackToInventory(item);
            }
        }
        tileentity.clear();
        itemlist.clear();
    }
    
    @Override
    public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = ItemStack.EMPTY;
        Slot slot = this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 0)
            {
                itemstack1.getItem().onCreated(itemstack1, playerIn.getEntityWorld(), playerIn);

                if (!this.mergeItemStack(itemstack1, 10, 46, true))
                {
                    return ItemStack.EMPTY;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index >= 10 && index < 37)
            {
                if (!this.mergeItemStack(itemstack1, 37, 46, false))
                {
                    return ItemStack.EMPTY;
                }
            }
            else if (index >= 37 && index < 46)
            {
                if (!this.mergeItemStack(itemstack1, 10, 37, false))
                {
                    return ItemStack.EMPTY;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 10, 46, false))
            {
                return ItemStack.EMPTY;
            }

            if (itemstack1.isEmpty())
            {
                slot.putStack(ItemStack.EMPTY);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.getCount() == itemstack.getCount())
            {
                return ItemStack.EMPTY;
            }

            ItemStack itemstack2 = slot.onTake(playerIn, itemstack1);

            if (index == 0)
            {
                playerIn.dropItem(itemstack2, false);
            }
        }

        return itemstack;
    }
    
    
}

 

thats it the sysout give me my message and the item is there but its buggy and i will only see the item if i click on the slot

 

3 hours ago, diesieben07 said:

Again: Show your code.

3 hours ago, DavidM said:

I've realized that you are reluctant in showing your code in many of your post. Why?

im sorry, i am responding when i got the mail and sometimes im not at home XD

Link to comment
Share on other sites

Ok im tryed it now with an Override method

 

Quote

@Override
    public ItemStack getStackInSlot(int slotIndex) {
        if(slotIndex == 9) {
            for(ForgingRecipe r : ForgingbenchRecipesInit.FORGINGRECIPES) {
                System.out.println("its wörking"+r.getinput1+r.getinput4);
                if(this.getStackInSlot(0).getItem() == r.getinput1) {
                if(this.getStackInSlot(1).getItem() == r.getinput2) {
                if(this.getStackInSlot(2).getItem() == r.getinput3) {
                if(this.getStackInSlot(3).getItem() == r.getinput4) {
                if(this.getStackInSlot(4).getItem() == r.getinput5) {
                if(this.getStackInSlot(5).getItem() == r.getinput6) {
                if(this.getStackInSlot(6).getItem() == r.getinput7) {
                if(this.getStackInSlot(8).getItem() == r.getinput8) {
                if(this.getStackInSlot(9).getItem() == r.getinput9) {
                                                    
                                                    return new ItemStack(r.getoutput);
                                                    
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
        return itemStacks[slotIndex];
    }

that worked if i do that manully but for some reason it will not work and also the for loop will not work

 

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import java.util.ArrayList;

import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgingbenchRecipesInit {
    
    public static final ArrayList<ForgingRecipe> FORGINGRECIPES = new ArrayList<ForgingRecipe>();
    
    Item o = null;
    Item i = Items.IRON_INGOT;
    Item s = Items.IRON_INGOT;
    
    ForgingRecipe iron_pickaxe = new ForgingRecipe(i,i,i,o,s,o,o,s,o, Items.IRON_PICKAXE);
}

 

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgingRecipe {
    
    private Item input1;
    private Item input2;
    private Item input3;
    private Item input4;
    private Item input5;
    private Item input6;
    private Item input7;
    private Item input8;
    private Item input9;
    private Item output;

    public ForgingRecipe (Item input1, Item input2, Item input3, Item input4, Item input5, Item input6, Item input7, Item input8, Item input9, Item output) {
        ForgingbenchRecipesInit.FORGINGRECIPES.add(this);
        
        this.input1 = input1;
        this.input2 = input2;
        this.input3 = input3;
        this.input4 = input4;
        this.input5 = input5;
        this.input6 = input6;
        this.input7 = input7;
        this.input8 = input8;
        this.input9 = input9;
        this.output = output;
        
    }
    
    public Item getinput1 = input1;
    public Item getinput2 = input2;
    public Item getinput3 = input3;
    public Item getinput4 = input4;
    public Item getinput5 = input5;
    public Item getinput6 = input6;
    public Item getinput7 = input7;
    public Item getinput8 = input8;
    public Item getinput9 = input9;
    public Item getoutput = output;
    
    
}

i dont get why

Link to comment
Share on other sites

7 hours ago, Schleim_time said:

                if(this.getStackInSlot(0).getItem() == r.getinput1) {
                if(this.getStackInSlot(1).getItem() == r.getinput2) {
                if(this.getStackInSlot(2).getItem() == r.getinput3) {
                if(this.getStackInSlot(3).getItem() == r.getinput4) {
                if(this.getStackInSlot(4).getItem() == r.getinput5) {
                if(this.getStackInSlot(5).getItem() == r.getinput6) {
                if(this.getStackInSlot(6).getItem() == r.getinput7) {
                if(this.getStackInSlot(8).getItem() == r.getinput8) {
                if(this.getStackInSlot(9).getItem() == r.getinput9) {

Have you heard of loops?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

15 minutes ago, Schleim_time said:

Yes but i cant do for x < 8 because i have for every recipe a own getInputX 

You can. Simply iterate through the inputs instead of creating a new variable for each one of them. Use a list.

Also, ItemStack != Item.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

16 minutes ago, Schleim_time said:

ahh however i think it isnt that much performance so i take that easy way i did

Iterating through a list isn't that performance intensive, but will make your code a lot more readable and easy to fix.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

18 hours ago, Schleim_time said:

ahh however i think it isnt that much performance so i take that easy way i did

Don't manually unroll loops. If there are any possible optimisations that can be done to your code, the JIT will do them. Manually unrolling loops makes your code unreadable and is likely to adversely effect performance.

https://stackoverflow.com/questions/2684364/why-arent-programs-written-in-assembly-more-often/2685541#2685541

https://blog.overops.com/java-on-steroids-5-super-useful-jit-optimization-techniques/

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.