[1.13.2] Blocks and Items not registered in the game.

[cinsiian]

Hello everyone. In these days i had an issue related to registering items and blocks. Seems that they're not integreted i the game.

Can you help me about that?

My github repository is https://github.com/cinsiian/Crystal.

Thanks for helping me in this project.

Bye.

[V0idWa1k3r]

Quote

 

This method will register the first parameter (item) and assign the current item(item) to the current item's class(itemClass).

 

 

 

What? This is not how anything works.

 

Quote

item = itemClass;

Yeah, this does absolutely nothing because item isn't a reference.

 

Your second method makes even less sense. Why assign the passed parameter to a random local and then register said local?

 

Quote

ItemBase

Here we go again. Don't use Item/BlockBase, there is already one, it's called Item/Block. Don't abuse inheritance.

 

Quote

public static void createBlock(Block block, Block blockClass, ItemBlock itemBlock, RegistryEvent.Register<Block> eventBlock, RegistryEvent.Register<Item> eventItem)

You can't pass both events to this method. Well, you can but you will break everything because items and blocks need to be registered in an appropriate event, you can't just start registering items in the block registry event and vice-versa.

 

Quote

block = blockClass;

As said already this won't work. It just assigns the value of blockClass to a block. Both of which are parameters which work as locals for this purpose.

 

Quote

ItemBlock itemBlock = new ItemBlock(block, new Item.Properties());

This will crash you in so many ways lol. Registering in the wrong time to a locked registry without a registry name is not the way to go.

 

Same to the next method.

 

public static ResourceLocation location(String name, String modid)
	{
		return new ResourceLocation(modid, name);
	}

But WHY have this method at all? Why type RegistryUtils.location every time when you can just type new ResourceLocation?

 

You don't seem to understand the concepts of passing by reference/value. 

https://stackoverflow.com/questions/40480/is-java-pass-by-reference-or-pass-by-value

 

You also don't seem to understand how registries work and we have docs for that.

https://mcforge.readthedocs.io/en/latest/concepts/registries/#registering-things

 

Next up:

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/config/CrystalConfig.java#L13

But why? You can just assign the value right there, in the field declaration. When we tell people never to use static initializers we mean don't use them for registry entries, otherwise static initializers are fine.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemBase.java#L11
As said earlier don't use ItemBase.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemBase.java#L28

You can do this in the Properties of your item. In fact please do so.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemTab.java

I don't... the more I look at this class the more I understand that I don't understand anything. Is this a horrifying way to type CrystalConfig.MOD_TABS ? ModItemGroups.GROUP : ItemGroup.SOMETHNG? But then

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemTab.java#L35

Like, what is even supposed to happen here? I am so confused. Why are you creating a new list, adding all vanilla groups to it, iterating it, doing a reference comparason to the group passed and then call your setters? Why not call them at the very beginning of the constructor?

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/mod/CrystalRegistry.java#L23

Don't use static initializers for registry entries. Here exampleBlock is null by the time this instantinates, so you pass a null block to your ItemBlock. 

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/mod/CrystalRegistry.java#L35

This is not how events work. Read the docs

https://mcforge.readthedocs.io/en/1.13.x/events/intro/

 

Edit: Yeah, what @DavidM said. Don't overcomplicate basic stuff, there is no reason to do so.

Edited May 22, 2019 by V0idWa1k3r

[DavidM]

You are way overcomplicating stuff like registration with unnecessary library classes and functions, making your code almost unreadable.

I would suggest to remove unnecessary classes (for example RegUtils, which only adds an item to the registry and assign the references of it to an ObjectHolder (and fails to do it), something that can be done in one line) and rewrite most of your code to keep things simple.

Moreover, do not use ItemBase. Read the Common issues and recommendations for more explanation.

Edited May 22, 2019 by DavidM

[cinsiian]

I am kinda new to this things so instead of copy other people's code i tried to make my own things. Apparently I did everything wrong lol. The ItemTab class is supposed to return my mod item group if the boolean in CrystalConfig is true, then, if false it will return a vanilla item group. I'm going to totally rewrite my mod. Thanks everyone.

[Cadiboo]

Simple base 1.13.2 mod: https://github.com/Cadiboo/Example-Mod