Jump to content

Find and replace adjacent blocks


Yamahari

Recommended Posts

Hi, I added a new type of block "weeds" that should be able to spread to nearby crops. The block itself works fine, but I don't know how I should go about the spreading mechanic.

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            String registryName = blockState.getValue().getBlock().getRegistryName().toString();
            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

I tried something like that, but that doesn't seem to work. How do I find out what type of block is next to the ticked blocked and how do I replace blocks in the world? 

Edited by Yamahari
Link to comment
Share on other sites

35 minutes ago, Yamahari said:

            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {

Ok, so, two problems:

 

1) Comparing strings in order to identify blocks is The Worst idea. Blocks.WHEAT, Blocks.BEETROOTBlocks.CARROTS, and Blocks.POTATOES are a thing. Just check if(block == Blocks.WHEAT), etc.

2) This can't handle mod added crops of any kind, you should instance check if(block instanceof BlockCrops)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Thanks for the feedback, it's been a long long time since I last touched modding x)

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

Can you help me with this: how do I get the age property from the block that may be replaced? 

 

Nvm i got it:

BlockCrops blockCrops = (BlockCrops) block;
if(blockState.getValue().get(blockCrops.getAgeProperty()) < blockCrops.getMaxAge()) {
	worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
}

 

Edited by Yamahari
Link to comment
Share on other sites

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

what is that

do it like so

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
		super.tick(state, worldIn, pos, random);
		for (EnumFacing facing : EnumFacing.HORIZONTALS){
			BlockPos offSet = pos.offset(facing);
			IBlockState blockState = worldIn.getBlockState(offSet);
			Block block = blockState.getBlock();
			if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
				worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
			}
		}
	}

 

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ok, I removed the littletiles mod and the server was opened, my problem was solved, thank you very much again.
    • The code is written by a neural network, but no matter how much I try to do damage or fire effect, either everything stops working, or the particles stop pointing at creatures. package net.tndax.thaumcraft.item.custom; import net.minecraft.core.Holder; import net.minecraft.core.particles.ParticleTypes; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.InteractionResultHolder; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.LivingEntity; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.Item; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.Level; import net.minecraft.world.damagesource.DamageSource; import java.util.List; import net.minecraft.world.damagesource.DamageType; public class ProtectiveItem extends Item { public ProtectiveItem(Properties pProperties) { super(pProperties); } @Override public InteractionResultHolder<ItemStack> use(Level level, Player player, InteractionHand hand) { if (level.isClientSide()) { new Thread(() -> { double radius = 2.0; // Радиус вращения double heightOffset = 1.5; // Высота вращения частиц относительно игрока int duration = 20000; // Продолжительность эффекта в миллисекундах int steps = 200; // Количество шагов в одном круге (увеличено для большей плотности частиц) long startTime = System.currentTimeMillis(); while (System.currentTimeMillis() - startTime < duration) { for (int step = 0; step < steps; step++) { try { Thread.sleep(5); // Время между шагами уменьшено для увеличения скорости } catch (InterruptedException e) { e.printStackTrace(); } double angle = 2 * Math.PI * step / steps; for (int i = 0; i < 5; i++) { // Добавляем несколько частиц с небольшими смещениями double offset = i * 0.1; double randomFactorX = Math.sin(Math.toRadians(step * 7 % 360 + offset)); double randomFactorY = Math.sin(Math.toRadians(step * 13 % 360 + offset)); double randomFactorZ = Math.sin(Math.toRadians(step * 17 % 360 + offset)); double x = player.getX() + radius * Math.cos(angle) * randomFactorX; double y = player.getY() + heightOffset + radius * Math.sin(angle) * randomFactorY; double z = player.getZ() + radius * Math.sin(angle) * randomFactorZ; level.addParticle(ParticleTypes.FLAME, x, y, z, 0, 0, 0); } // Проверяем наличие сущностей в радиусе 5 блоков List<Entity> nearbyEntities = level.getEntities(player, player.getBoundingBox().inflate(10), entity -> entity instanceof LivingEntity && entity != player); if (!nearbyEntities.isEmpty()) { Entity target = nearbyEntities.get(0); // Берём первую ближайшую сущность double targetX = target.getX(); double targetY = target.getY() + target.getEyeHeight(); double targetZ = target.getZ(); // Направляем частицы к цели for (int i = 0; i < 20; i++) { double t = i / 20.0; double particleX = player.getX() + t * (targetX - player.getX()); double particleY = player.getY() + heightOffset + t * (targetY - (player.getY() + heightOffset)); double particleZ = player.getZ() + t * (targetZ - player.getZ()); level.addParticle(ParticleTypes.FLAME, particleX, particleY, particleZ, 0, 0, 0); try { Thread.sleep(5); // Пауза между частицами } catch (InterruptedException e) { e.printStackTrace(); } } // Возвращаем частицы обратно к игроку for (int i = 0; i < 20; i++) { double t = i / 20.0; double particleX = targetX + t * (player.getX() - targetX); double particleY = targetY + t * (player.getY() + heightOffset - targetY); double particleZ = targetZ + t * (player.getZ() - targetZ); level.addParticle(ParticleTypes.FLAME, particleX, particleY, particleZ, 0, 0, 0); try { Thread.sleep(5); // Пауза между частицами } catch (InterruptedException e) { e.printStackTrace(); } } } } } }).start(); } return new InteractionResultHolder<>(InteractionResult.SUCCESS, player.getItemInHand(hand)); } }  
    • physicsmod is conflicting with embeddium - try other builds of both mods
    • Same issue without dungeons_gear?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.