Find and replace adjacent blocks

[Yamahari]

Hi, I added a new type of block "weeds" that should be able to spread to nearby crops. The block itself works fine, but I don't know how I should go about the spreading mechanic.

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            String registryName = blockState.getValue().getBlock().getRegistryName().toString();
            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

I tried something like that, but that doesn't seem to work. How do I find out what type of block is next to the ticked blocked and how do I replace blocks in the world? 

Edited May 28, 2019 by Yamahari

[Yamahari]

ah, the registryNames need to be prefixed with "minecraft:", then it works

[Draco18s]

35 minutes ago, Yamahari said:

            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {

Ok, so, two problems:

 

1) Comparing strings in order to identify blocks is The Worst idea. Blocks.WHEAT, Blocks.BEETROOT, Blocks.CARROTS, and Blocks.POTATOES are a thing. Just check if(block == Blocks.WHEAT), etc.

2) This can't handle mod added crops of any kind, you should instance check if(block instanceof BlockCrops)

[Yamahari]

Thanks for the feedback, it's been a long long time since I last touched modding x)

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

Can you help me with this: how do I get the age property from the block that may be replaced? 

 

Nvm i got it:

BlockCrops blockCrops = (BlockCrops) block;
if(blockState.getValue().get(blockCrops.getAgeProperty()) < blockCrops.getMaxAge()) {
	worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
}

 

Edited May 28, 2019 by Yamahari

[loordgek]

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

what is that

do it like so

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
		super.tick(state, worldIn, pos, random);
		for (EnumFacing facing : EnumFacing.HORIZONTALS){
			BlockPos offSet = pos.offset(facing);
			IBlockState blockState = worldIn.getBlockState(offSet);
			Block block = blockState.getBlock();
			if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
				worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
			}
		}
	}

 

[Yamahari]

Hm, what version of forge is this? I am modding for 1.13.2 ( maybe should have added that x) ) and there doesn't seem to be a member "HORIZONTALS" in EnumFacing.

[Yamahari]

Ah it's under EnumFacing.Plane.HORIZONTAL

Edited May 28, 2019 by Yamahari

[loordgek]

i was on 1.12.2