[1.12.2] Potential Memory leak detected

[GloriousAlpaca]

Hello,

for some reason all of my Packets are leaking.
This is the Code of my Packet:
https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/network/VoidcomReturnMessage.java

I have used nearly the same code in another class and there it is working fine. The progress and energy variables do have the right values, however the processMessage() method does not work.

 

Thank you for your help.

Edited May 29, 2019 by GloriousAlpaca
Clarification

[V0idWa1k3r]

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/network/VoidcomReturnMessage.java#L63

Well, you are returning the same packet as a response packet to send back, which will return itself as a response packet to send back ....... rince, repeat and you have a memory leak. Return null if you don't want to send a response packet.

 

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/network/VoidcomReturnMessage.java#L62

You can't do this. Minecraft is a client only class and as such this code will crash the server.

 

https://github.com/GloriousAlpaca/Leer/blob/master/Void Mod/src/main/java/mod/leer/network/VoidcomReturnMessage.java#L66

But WHY if you are the owner of these classes? Why would you use reflection on your own classes when you can just create a setter?

Edited May 29, 2019 by V0idWa1k3r

[GloriousAlpaca]

3 minutes ago, V0idWa1k3r said:

You can't do this. Minecraft is a client only class and as such this code will crash the server. 

Well the Packet is only sent to the client so that shouldn't be a problem right ?

There's also a check right before that as to not call that method on the server.

4 minutes ago, V0idWa1k3r said:

But WHY if you are the owner of these classes? Why would you use reflection on your own classes when you can just create a setter?

That's true, I'll try that.

 

Thank you!

[V0idWa1k3r]

6 minutes ago, GloriousAlpaca said:

Well the Packet is only sent to the client so that shouldn't be a problem right ?

 

While it is true that the default jvm won't load classes unless it is required it isn't the only JVM in existance.

[GloriousAlpaca]

Well it seems to be working now but what would I ideally do instead of:

if(!message.valid && ctx.side != Side.CLIENT)
				return null;
Minecraft.getMinecraft().addScheduledTask(() -> processMessage(message,ctx));

 

[loordgek]

proxy https://mcforge.readthedocs.io/en/latest/concepts/sides/

[Draco18s]

29 minutes ago, V0idWa1k3r said:

Return null if you don't want to send a response packet.

Which is going to be 99.99% of the time.