Posted May 31, 20196 yr I want to disable drops from wooden logs when player breaks it without an axe. But i have a mistake in my code, getHarvestLevel is red. Why? if ((event.getState().getBlock() instanceof BlockLog)) { if (event.getHarvester() != null) { ItemStack tool = event.getHarvester().getHeldItemMainhand(); EntityPlayer player = event.getHarvester(); IBlockState blockState = event.getState().getBlockState(); if (tool == null || !(tool.getItem().getHarvestLevel(tool, "axe", player, blockState)) > -1) { event.getDrops().clear(); } } } Edited May 31, 20196 yr by Tameet
May 31, 20196 yr Author 5 minutes ago, diesieben07 said: Tool types are now represented by the ToolType class, not a plain String. it means, that line "IBlockState blockState = event.getState().getBlockState();" has no mistake?
May 31, 20196 yr Author 1 minute ago, diesieben07 said: Well, it's not much use since getBlockState will just return the same IBlockState again. But yes, it "has no mistake". but my english "has a mistake"? Edited May 31, 20196 yr by Tameet
May 31, 20196 yr Author 9 minutes ago, diesieben07 said: It's a bit clunky, but it's completely understandable. Don't worry about it. And that's working. Thank you very much
May 31, 20196 yr @Tameet I would just suggest that you shouldn't judge "has no mistake" by the syntax correctness. Red underline only shows syntax errors; the code can still be erroneous when the syntax is correct. "IBlockState blockState = event.getState().getBlockState();" has no syntax errors, yet the logic is not exactly clean. The same can be accomplished with just event.getState(). Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.
May 31, 20196 yr Author 3 hours ago, DavidM said: @Tameet I would just suggest that you shouldn't judge "has no mistake" by the syntax correctness. Red underline only shows syntax errors; the code can still be erroneous when the syntax is correct. "IBlockState blockState = event.getState().getBlockState();" has no syntax errors, yet the logic is not exactly clean. The same can be accomplished with just event.getState(). I do not understand anything but ok ?. As they say in russian 'Них#я не понял, но очень интересно' Edited May 31, 20196 yr by Tameet
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.