[Solved] [1.13.2] Help fix a mistake

[Tameet]

I want to disable drops from wooden logs when player breaks it without an axe. But i have a mistake in my code, getHarvestLevel is red. Why?

if ((event.getState().getBlock() instanceof BlockLog)) {
			if (event.getHarvester() != null) {
				ItemStack tool = event.getHarvester().getHeldItemMainhand();
				EntityPlayer player = event.getHarvester();
				IBlockState blockState = event.getState().getBlockState();
				if (tool == null || !(tool.getItem().getHarvestLevel(tool, "axe", player, blockState)) > -1) {
					event.getDrops().clear();
				}
			}
		}

 

Edited May 31, 2019 by Tameet

[Tameet]

5 minutes ago, diesieben07 said:

Tool types are now represented by the ToolType class, not a plain String.

it means, that line "IBlockState blockState = event.getState().getBlockState();" has no mistake?

[Tameet]

1 minute ago, diesieben07 said:

Well, it's not much use since getBlockState will just return the same IBlockState again. But yes, it "has no mistake".

but my english "has a mistake"?

Edited May 31, 2019 by Tameet

[Tameet]

9 minutes ago, diesieben07 said:

It's a bit clunky, but it's completely understandable. Don't worry about it.

And that's working. Thank you very much

[DavidM]

@Tameet I would just suggest that you shouldn't judge "has no mistake" by the syntax correctness.

Red underline only shows syntax errors; the code can still be erroneous when the syntax is correct.

"IBlockState blockState = event.getState().getBlockState();" has no syntax errors, yet the logic is not exactly clean. The same can be accomplished with just event.getState().

[Tameet]

3 hours ago, DavidM said:

@Tameet I would just suggest that you shouldn't judge "has no mistake" by the syntax correctness.

Red underline only shows syntax errors; the code can still be erroneous when the syntax is correct.

"IBlockState blockState = event.getState().getBlockState();" has no syntax errors, yet the logic is not exactly clean. The same can be accomplished with just event.getState().

I do not understand anything but ok ?. As they say in russian 'Них#я не понял, но очень интересно'

Edited May 31, 2019 by Tameet