Code is at https://github.com/JGgithub2018/Simple-Batteries

The machine is the BlockAlloyFurnace and related classes.

 

What I'm trying to accomplish is a way to only allow players to interact with the slots. Hoppers shouldn't insert anywhere. I've created an ItemHandler that cannot be modified externally as well.

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/forgecaps/ReadOnlyItemHandler.java

??

just implement IItemHandler

 

your modID is to short use ¨simplebatteries¨ not sb

Edited June 4, 20196 yr by loordgek

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/forgecaps/ReadOnlyItemHandler.java#L23

A read-only stack handler should not allow a set. You want to set, keep a reference to the internal stack handler externally and set it there.

 

9 hours ago, loordgek said:

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/forgecaps/ReadOnlyItemHandler.java

??

just implement IItemHandler

Extending ItemStackHandler is perfectly fine, especially when you don't want to deal with some of the implementations (such as read/write to NBT), as its more work than simply nullifying the behavior you don't want (such as preventing insertion and extraction).

Edited June 4, 20196 yr by Draco18s

51 minutes ago, Draco18s said:

Extending ItemStackHandler is perfectly fine, especially when you don't want to deal with some of the implementations (such as read/write to NBT), as its more work than simply nullifying the behavior you don't want (such as preventing insertion and extraction).

look at what he is doing

he is using a ItemStackHandler  to wrap a ItemStackHandler

1 hour ago, loordgek said:

look at what he is doing

he is using a ItemStackHandler  to wrap a ItemStackHandler

So? I did too:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/api/internal/inventory/OutputItemStackHandler.java

There's a very legitimate reason to do this. My OutputSlotHandler is exposed via GetCapability (so that machines can extract from the slot, but not insert) while the internalSlot is accessed directly by the machine in order to produce output.

 

Creating a "read only" slot (one that can be queried for its contents, but not have the item extracted, nor allow an item insertion) would work the same way. The internal slot (the one that is being wrapped) can still be accessed normally in a private manner while the read only wrapper is exposed externally.

On 6/5/2019 at 12:35 AM, Draco18s said:

So? I did too:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/api/internal/inventory/OutputItemStackHandler.java

A little offtopic (sorry), but is there a particular reason you're calling markDirty() in getCapability()?  Bearing in mind that markDirty() calls World#updateComparatorOutputLevel() which can do a potentially non-trivial amount of work (calling Block#onNeighborChange() on all your block's neighbors, and possibly even some of their neighbors too).

47 minutes ago, desht said:

A little offtopic (sorry), but is there a particular reason you're calling markDirty() in getCapability()?  Bearing in mind that markDirty() calls World#updateComparatorOutputLevel() which can do a potentially non-trivial amount of work (calling Block#onNeighborChange() on all your block's neighbors, and possibly even some of their neighbors too).

Probably left over from an issue where something wasn't saving. Its been like 2 years.