TESR showing entity moves other TESRs

[Wunst]

Hi all,

I coded a Tile Entity that spawns a mob with a TESR that shows the entity's model, but as soon as the TE is on screen, all other TESRs like chests move to the right and forth while their blocks stay at the same spot.

Here's the renderer:

public class TESRCultistSpawn extends TileEntitySpecialRenderer<TileEntityCultistSpawn> {
    @Override
    public void render(TileEntityCultistSpawn te, double x, double y, double z, float partialTicks, int destroyStage, float alpha) {
        
        GlStateManager.translate(0.5, 0, 0.5);
        EntityCultist entity = new EntityCultist(te.getWorld());
        entity.rotationYaw = 45;
        Minecraft.getMinecraft().getRenderManager().renderEntity(entity, x, y, z, 180.0f, partialTicks, true);
    }
}

And what happens is attached as PNG. Compare the chest model and the block outline!

[loordgek]

set the translate back to 0

[Wunst]

This just reverses the effect: the TESR itself is moved to the left.

[loordgek]

show your code

 

[DavidM]

Remember to do GlStateManager::pushMatrix and GlStateManager::popMatrix before and after your rendering.

[Cadiboo]

3 hours ago, Wunst said:

EntityCultist entity = new EntityCultist(te.getWorld());

This is unrelated, but do NOT create a new entity each frame.

[Wunst]

@Cadiboo Oh, ok, I'll make the entity a field instead of a local variable.

@DavidM Maybe that will help, I forgot it...

[Cadiboo]

8 hours ago, Wunst said:

Oh, ok, I'll make the entity a field instead of a local variable.

Why do you need the entity in the first place?

[DavidM]

11 hours ago, Wunst said:

@DavidM Maybe that will help, I forgot it...

That is probably the issue. You are applying the translation to all rendering, which will not be cleared for future rendering if you do not push a new matrix for the translating, thus causing all renders to shift 0.5 on x and z axis.

 

3 hours ago, Cadiboo said:

Why do you need the entity in the first place?

I think he is trying to render a mob at the position of the TileEntity.

[Cadiboo]

2 hours ago, DavidM said:

I think he is trying to render a mob at the position of the TileEntity.

If that’s the only reason, they shouldn’t be making a new entity, they should just be rendering the model. If they want to render an entity dynamically they should be getting it from somewhere rather than making a new one.

[Wunst]

Okay, it works now, I changed the code to:

public class TESRCultistSpawn extends TileEntitySpecialRenderer<TileEntityCultistSpawn> {
    EntityCultist entity;
    
    @Override
    public void render(TileEntityCultistSpawn te, double x, double y, double z, float partialTicks, int destroyStage, float alpha) {
        if(entity == null) {
            entity = new EntityCultist(te.getWorld());
        }
        GlStateManager.pushMatrix();
        GlStateManager.translate(0, 0, 0);
        Minecraft.getMinecraft().getRenderManager().renderEntity(entity, x + 0.5, y, z + 0.5, 180.0f, partialTicks, true);
        GlStateManager.popMatrix();
    }
}

 

Edited June 11, 2019 by Wunst

[Wunst]

Should I initialize the field like

EntityCultist entity = new EntityCultist();

public void render(…) {

      ...

}

[desht]

Rather than creating an entity at all, do what @Cadiboosaid and just render the entity's model in your TESR.  I.e. do what your RenderCultist (or whatever) class does in its doRender() method.

[Wunst]

Okay, that makes sense... I'll edit this post when I tried it.