So i have a json recipe and it is loading but i want to add a condition to it. So i tried to do like in 1.12. But it gives me this error com.google.gson.JsonSyntaxException: Unknown condition type: recipes_and_more:golden_apple

This is my recipe file:

Spoiler

{
	"type": "minecraft:crafting_shaped",
	"pattern":
	[
		"GGG",
		"GAG",
		"GGG"
	],
	"key":
	{
		"G":
		{
			"item": "minecraft:gold_block"
		},
		"A":
		{
			"item": "minecraft:apple"
		}
	},
	"result":
	{
		"item": "minecraft:golden_apple",
		"data": 1
	},
	"conditions" : [
		{
			"type" : "recipes_and_more:golden_apple"
		}
	]
}

 

 

And my _factories file:

Spoiler

{
	"conditions": {
		"golden_apple": "meldexun.recipesAndMore.recipes.GoldenAppleCondition"
	}
}

 

 

And my condition class:

Spoiler

public class GoldenAppleCondition implements IConditionSerializer {
	
	@Override
	public BooleanSupplier parse(JsonObject json) {
		return () -> true;
	}
	
}

 

 

1.13 doesn't use _factories any more.

 

You need to register a serializer extends net.minecraftforge.registries.ForgeRegistryEntry<IRecipeSerializer<?>> implements IRecipeSerializer<R> (where R is your recipe class) within the appropriate registry event.

 

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/api/recipe/RecipeTagOutput.java#L180

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/HardLib.java#L51 (my registry stuff is handled by my Easy Registry system, but its functionally the same as you'd expect).

Edited August 3, 20196 yr by Draco18s

In Forge 1.13.2 the IRecipeSerializer class doesn't extend IForgeRegistryEntry. So can it even work in 1.13.2? It seems like i should just skip Forge 1.13.2 and work in Forge 1.14.4 since 1.13 is not getting updated currently.

1 hour ago, Meldexun said:

In Forge 1.13.2 the IRecipeSerializer class doesn't extend IForgeRegistryEntry. So can it even work in 1.13.2? It seems like i should just skip Forge 1.13.2 and work in Forge 1.14.4 since 1.13 is not getting updated currently.

Check the type hierarchy (that is, the existing vanilla classes that implement it). In 1.14 all the serializers extend IForgeRegistryEntry explicitly, rather than it being attached to the interface, so it probably is the same in 1.13 (which is weird, but whatever).

 

F4 in Eclipse, or you can right click on it.

 

(And if I'm wrong, I'm wrong. I updated to 1.14 pretty fast)

Edited August 3, 20196 yr by Draco18s

dont use 1.13 go to 1.14.X