[1.14.4] Determining if an ItemStack can be smelted (blasted or smoked)?

[Draco18s]

This is literally the best I have right now and its disgusting.

 

AbstractFurnaceTileEntity furn = (AbstractFurnaceTileEntity)te;
furn.setInventorySlotContents(0, stack.copy());
IRecipe<?> recipeIn = null;
if(furn instanceof BlastFurnaceTileEntity) {
	recipeIn = this.world.getRecipeManager().getRecipe(IRecipeType.BLASTING, furn, this.world).orElse(null);
}
else if(furn instanceof FurnaceTileEntity) {
	recipeIn = this.world.getRecipeManager().getRecipe(IRecipeType.SMELTING, furn, this.world).orElse(null);
}
else if(furn instanceof SmokerTileEntity) {
	recipeIn = this.world.getRecipeManager().getRecipe(IRecipeType.SMOKING, furn, this.world).orElse(null);
}
else return false;
return (recipeIn != null && !recipeIn.getRecipeOutput().isEmpty());

 

Any suggestions?

Edited August 16, 2019 by Draco18s

[Animefan8888]

3 hours ago, Draco18s said:

This is literally the best I have right now and its disgusting.

Agreed that is disgusting. Though I feel that the only viable alternatives at this point is also disgusting. One being to use reflection to access the recipes field or RecipeManager#getRecipes(IRecipeType<?>) in the RecipeManger so you can access the specific list/map of the recipe type you want. Or use the collection given by RecipeManager#getRecipes() and cache the recipes that you have already come across in a separate list/map so as to not iterate over every last recipe ever.

[Choonster]

AbstractFurnaceTileEntity stores its IRecipeType (BLASTING, SMELTING or SMOKING) in the protected AbstractFurnaceTileEntity#recipeType field, so you could use reflection to access this instead of using those instanceof checks. This would also handle any modded furnace that extends AbstractFurnaceTileEntity.

 

 

[Draco18s]

13 hours ago, Animefan8888 said:

Or use the collection given by RecipeManager#getRecipes() and cache the recipes that you have already come across in a separate list/map so as to not iterate over every last recipe ever.

Yeah, that was the thing I definitely did *not* want to do.

 

8 hours ago, Choonster said:

AbstractFurnaceTileEntity stores its IRecipeType (BLASTING, SMELTING or SMOKING) in the protected AbstractFurnaceTileEntity#recipeType field, so you could use reflection to access this instead of using those instanceof checks. This would also handle any modded furnace that extends AbstractFurnaceTileEntity.

I was afraid that that was the alternative. I don't particularly like that much either, but it would work and be more flexible.