Jump to content

How to save simple data to World?


titaniuns

Recommended Posts

Hi I'm trying to save a simple string to the world nbt data but it isn't working at all, in the same game session I'm able to set and get the data to the WorldSavedData but when I unload and reload the world the data wasn't saved.

 

Here is my code for the WorldSavedData.java

 

package vazkii.ambience.Util;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

import javax.annotation.Nullable;

import net.minecraft.client.Minecraft;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;
import vazkii.ambience.Ambience;
import vazkii.ambience.World.Biomes.Area;

public class WorldData extends WorldSavedData {
	final static String key = Ambience.MOD_ID;
	public static MapStorage storage;
	
	public String test="4";
	
	public String getTeste() {
		return test;
	}

	public void setTest(String teste) {
		this.test = teste;
	}

	public static WorldData getSavedDataforWorld(World world) {
		storage = world.getMapStorage();//.getPerWorldStorage();
		WorldData result = (WorldData) storage.getOrLoadData(WorldData.class, key);
		if (result == null) {
			result = new WorldData(key);
			storage.setData(key, result);
		}
		return result;
	}
	
	private NBTTagCompound data = new NBTTagCompound();

	public WorldData(String name) {
		super(name);
	}

	public NBTTagCompound saveData() {
		//NBTTagCompound tag=data;
		data.setString("teste", "3");

		//I tried to force save the classe itself
		storage.setData(key, this);
		this.markDirty();
		
		return data;
	}

	@Override
	public void readFromNBT(NBTTagCompound compound) {
		data = compound.getCompoundTag(key);
	}

	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag(key, data);
		return compound;
	}
}

 

And here is how I'm calling it to store data:

 

WorldData data= WorldData.forWorld(Minecraft.getMinecraft().player.world);			
NBTTagCompound tag = data.saveData();

 

Link to comment
Share on other sites

22 minutes ago, titaniuns said:

Minecraft.getMinecraft().player.world

First off this is client only you cant use this.

22 minutes ago, titaniuns said:

WorldData.forWorld

Secondly I dont see this method in your code.

  • Thanks 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Quote

First off this is client only you cant use this.

 

Oh I thought that saving the nbt data in the client side would syncronize to the server, but no. Thanks after your commentary I changed the code to send a packet to the server with the data and there I could access the World on the server side to save and worked perfectly!

Link to comment
Share on other sites

6 hours ago, titaniuns said:

Thanks after your commentary I changed the code to send a packet to the server with the data

What diesieben said above me is very true. You should send a packet telling the server to check the calculation/do it itself. Then save the data and if necessary send it back to the client.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

On 9/10/2019 at 4:58 PM, Animefan8888 said:

What diesieben said above me is very true. You should send a packet telling the server to check the calculation/do it itself. Then save the data and if necessary send it back to the client.

Yes, I did exactly that, I've sent the data to the server saved there and I had to send another packet to all the clients for sync the new data. What I'm creating is a tool where the player select a 3D region in the world by clicking in two blocks and saving that selected coordinates in a GUI, and I didn't find another way to do this in real time. This was way more difficult that what I though ? but it's working perfectly now, thanks ?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.