Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.14] Earliest Time to reference Tags?

Recommended Posts

I haven't yet worked out the systems necessary to convert my machines recipes over to a JSON system, but as largely speaking they tightly controlled values (eg. 1 raw ore chunk grinds to 2 tiny dust of the same metal type, 8 tiny dust combine to 1 large dust pile) I'm not overly concerned with exposing them via data packs.


I do, however, want to insure mod compatibility and have set up the necessary structures to handle tag-based inputs.


It seems, however, that I can't examine what stacks exist in a given tag until after a world loads, which has led to this:


private static Map<Tuple<Supplier<Tag<Item>>, Integer>, ItemStack> siftTagRecipes = Maps.<Tuple<Supplier<Tag<Item>>, Integer>, ItemStack>newHashMap();

which is storing the parameters passed thusly:

addSiftRecipe(() -> ItemTags.getCollection().getOrCreate(new ResourceLocation("forge","dusts/tiny/iron")), 8, new ItemStack(ModItems.largedust_iron,1));


I can't imagine that this is the best way of doing this. I'll even admit that a Map isn't the best choice either, but it was what was being used by the vanilla recipe manager, but an ArrayList<Tuple<Tuple<Supplier<Tag<Item>>, Integer>, ItemStack>> is equivalent for the purpose and still suffers the same problem:


How best to store a reference to a Tag when the point in time that I create the reference the tag contains no items. As far as I can tell, I need all of those wrappers.


In a related conversation, there does not seem to be any standard for tags that are the equivalent to the old OreDict conventions (e.g. dustTinyThing->dusts/tiny/thing and so forth). I have made a best-guess and can only hope that other developers make the same logical conclusion that I did. I would appreciate if a similar set of guidelines to the old OreDict Common Names were created for the new tag system (as, as far as I can tell, if you specify a different namespace, the tags are unique; e.g. "forge:dusts/tiny/iron" is not the same as "mcmod:dusts/tiny/iron").

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.


Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.


DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.