1.12.2) Blockstate Json Issues?

[xxWhatsherfacex]

Hello there! I'm messing around with how to make a double block, and I've gotten to the point where the model isn't showing up correctly. I've been looking this over for about an hour trying to figure it out. I ran my blockstate JSON through a validator and it came back okay...Is there a glaringly obvious issue that I missed here? Thanks!

doubleblock.json (Located in assets/yummy/blockstates)

{
    "variants": {
        "facing=east,half=lower":  { "model": "yummy:PresserModelLower", "y": 90 },
        "facing=south,half=lower": { "model": "yummy:PresserModelLower", "y": 180 },
        "facing=west,half=lower":  { "model": "yummy:PresserModelLower", "y": 270 },
        "facing=north,half=lower": { "model": "yummy:PresserModelLower" },
        "facing=east,half=upper":  { "model": "yummy:PresserModelUpper", "y": 90 },  
        "facing=south,half=upper": { "model": "yummy:PresserModelUpper", "y": 180 },
        "facing=west,half=upper":  { "model": "yummy:PresserModelUpper", "y": 270 },
        "facing=north,half=upper": { "model": "yummy:PresserModelUpper" }    
    }
}

 

Here are the PresserModelUpper and PresserModelLower.

 

[SerpentDagger]

What kind of texture/model errors are you getting, if any?

[xxWhatsherfacex]

2 minutes ago, SerpentDagger said:

What kind of texture/model errors are you getting, if any?

I've scoured my console and couldn't find anything relating to textures or models, unfortunately.

[SerpentDagger]

Actually, looking at your model jsons, I think it's that you've written "parent": "block/cube_all", at the top. Since your model isn't a cube, you need to remove that.

[xxWhatsherfacex]

I removed it but nothing seems to have changed. 

[Animefan8888]

3 hours ago, xxWhatsherfacex said:

Is there a glaringly obvious issue that I missed here?

Well if you put all of your files on github like I expected. You don't have a texture file at assets/modid/textures/blocks/juice_press_block

[xxWhatsherfacex]

Oof. I'm real sorry. My Github was a mess. (I'd just uploaded those two files to an outdated version of my code.) It's up to date now.

 

I think I've fixed one problem and caused another... I started from scratch again and it seems like the model is working. But when I try to place it with the Item. I get a CTD, with the error:

 

 

 

 

Spoiler

Description: Unexpected error

java.lang.NullPointerException: Unexpected error
    at com.rnh.home.Items.Items.ItemJuicePressBlock.onItemUse(ItemJuicePressBlock.java:46)
    at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:201)
    at net.minecraft.client.multiplayer.PlayerControllerMP.processRightClickBlock(PlayerControllerMP.java:499)
    at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1693)
    at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:2380)
    at net.minecraft.client.Minecraft.runTickKeyboard(Minecraft.java:2146)
    at net.minecraft.client.Minecraft.runTick(Minecraft.java:1934)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1187)
    at net.minecraft.client.Minecraft.run(Minecraft.java:441)
    at net.minecraft.client.main.Main.main(Main.java:118)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
    at GradleStart.main(GradleStart.java:25)
 

 

[Draco18s]

https://github.com/xWhatsherfacex/Testing/blob/master/java/com/rnh/home/Init/ModItems.java#L26

Problematic Code #14

[Animefan8888]

6 minutes ago, xxWhatsherfacex said:

It's up to date now.

There are so many problems with your code I don't really know where to start. Two of them are your use of IHasModel, and the fact that you are initializing your Item, Block fields statically.

Remove IHasModel completely. Use your list of Items/Blocks to register the models in the event.

 

Initialize your Item/Block fields in the registry event.

 

Remove ItemBase and BlockBase(if you have that). There is already a base item/block class. They are called Item and Block.

 

The Idea of a CommonProxy is already handled via the main mod class. The correct way to use the Proxy system is to have an interface(a lot of the time called IProxy) and two classes that implement it ServerProxy and ClientProxy.

 

Also I don't think you own the domain rnh.com so you should switch your package naming convention.

[xxWhatsherfacex]

Oh wow! I think I implemented all those changes correctly. Here is the updated code.

Things seem a lot simpler now, thanks! It seems pretty silly for people to teach it the other way. Haha.

 

Using the Item to place the block seems to be working well now too!