Forge 28.1.X causing crash when killing zombies while invisible

[raziel23x]

@Animefan8888 could you look at this line of code and confirm as well

[DaemonUmbra]

Wait... if he says it's a bug in Forge that's already been fixed... is this not solved?

[Animefan8888]

4 hours ago, raziel23x said:

I have started testing this mod with just lycanitesmobs while did not crash so i added EverlastingAbilities and CyclopsCore no crash but the second i add Apotheosis and Placebo and run the same test that is when the crash happens I looked at the code and see that Apotheosis has some custom code for invisibility so i think i narrowed it down to that since the test modpack above just has all the mods we though it was but it did not go crash until Apotheosis  as added into the mix

Can you try it with just Apotheosis and Placebo, then with those and Lycanite's Mobs so we can rule out the other two causing problems. It might be a problem with apotheosis doing some ASM trickery incorrectly with the new version of forge. Check if they have an updated version for the newer forge versions.

[raziel23x]

@Animefan8888 @LexManos

 

found this in  LycanitesMobs

https://gitlab.com/Lycanite/LycanitesMobs/blob/master/src/main/java/com/lycanitesmobs/GameEventListener.java#L180-205

// ==================================================
    //                 Attack Target Event
    // ==================================================
	@SubscribeEvent(priority = EventPriority.HIGHEST)
	public void onAttackTarget(LivingSetAttackTargetEvent event) {
		Entity targetEntity = event.getTarget();
		if(event.getEntityLiving() == null || targetEntity == null) {
			return;
		}

		// Better Invisibility:
		if(!event.getEntityLiving().isPotionActive(Effects.INVISIBILITY)) {
			if(targetEntity.isInvisible()) {
				if(event.isCancelable())
					event.setCanceled(true);
				event.getEntityLiving().setRevengeTarget(null);
				return;
			}
		}

		// Can Be Targeted:
		if(event.getEntityLiving() instanceof MobEntity && targetEntity instanceof BaseCreatureEntity) {
			if(!((BaseCreatureEntity)targetEntity).canBeTargetedBy(event.getEntityLiving())) {
				event.getEntityLiving().setRevengeTarget(null);
				if(event.isCancelable())
					event.setCanceled(true);
				((MobEntity)event.getEntityLiving()).setAttackTarget(null);
			}
		}
	}

Edited September 28, 2019 by raziel23x

[raziel23x]

[raziel23x]

@LexManos I Am confused with his response about everyone needing to check mob attacks targets while invisibility is in effect and or why he did this check or is this just a excuse