Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

(1.14.4) Potion effect wont remove

ImperialDragon99

By ImperialDragon99
in Modder Support

 Share

Recommended Posts

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
Posted (edited)

Im making a custom swordItem that gives the player the wither effect when you right click the sword and when you click it again the effect goes away. My problem is when I try and get rid of the effect it visually goes away but im still taking damage and after a few seconds the visual effect comes back. http://prntscr.com/p8poj9

Edited by ImperialDragon99
  • 2 weeks later...
ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
On 9/20/2019 at 10:56 AM, diesieben07 said:

You cannot store data like that in the Item class, there is only one instance of that class. Potions must also only be modified on the server.

How do you modify potions server side?

SerpentDagger Creeper Killer

SerpentDagger

Posted
Posted
49 minutes ago, ImperialDragon99 said:

How would I get a line of code to run on the logical server?

You query the isRemote field of a World object... 

if (!world.isRemote) { /*Whatever*/ }

...where world is an instance of World.

 

Fancy 3D Graphing Calculator mod, with many different coordinate systems.

Lightweight 3D/2D position/vector transformations library, also with support for different coordinate systems.

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
2 hours ago, diesieben07 said:

You can't "make it run" on the logical server. Either the method you are using is called on only one side (then you dont need to check) or it's called on both sides, then you can use isRemote to check the current one.

So I checked world.isremote and it = true right now which means its on the logical client. Thats interesting and all but how could I get playerIn.removeActivePotionEffect(Effects.WITHER); to actually remove the effect?

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
2 hours ago, ImperialDragon99 said:

So I checked world.isremote and it = true right now which means its on the logical client.

It should be called twice. Post your updated code.

 

2 hours ago, ImperialDragon99 said:

but how could I get playerIn.removeActivePotionEffect(Effects.WITHER); to actually remove the effect?

You have to do it on the logical server.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
10 minutes ago, Animefan8888 said:

It should be called twice. Post your updated code.

 

You have to do it on the logical server.

public class WitherSwordItem extends SwordItem{

    private ArrayList<String> active = new ArrayList<String>();
    private CoolDowns cooldown = new CoolDowns();

    public WitherSwordItem(IItemTier p_i484601, int p_i484602, float p_i484603, Properties p_i484604) {
        super(p_i484601, p_i484602, p_i484603, p_i484604);
    }
    
    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn){

        String pName = playerIn.getDisplayName().toString();
        ItemStack item = playerIn.getHeldItem(handIn);
        if(!worldIn.isRemote) {
            if (cooldown.isDone("WitherSwordRightClick", pName , 3000)){
                if(!active.contains(pName)){
                    System.out.println("On");
                    active.add(pName);
                    playerIn.addPotionEffect(new EffectInstance(Effects.WITHER, 999999999, 0));
                    playerIn.playSound(SoundEvents.ENTITY_WITHER_AMBIENT, 100, 0);
                }else{
                    System.out.println("Off");
                    active.remove(pName);
                    System.out.println(worldIn.isRemote());
                    playerIn.removeActivePotionEffect(Effects.WITHER);
                    playerIn.playSound(SoundEvents.BLOCK_LAVA_EXTINGUISH, 100, 0);
                    
               
                }
            item.damageItem(1, playerIn, null);
            }

        }
        return new ActionResult<ItemStack>(ActionResultType.SUCCESS, item);
    }
    
}

I know if(!worldIn.isRemote) makes it false but the code doesn't run, I'm sorry i'm not getting how to do this

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
4 minutes ago, ImperialDragon99 said:

the code doesn't run

Which part of the code? All of it(the method never gets called)? Past a certain if statement?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
1 minute ago, Animefan8888 said:

Which part of the code? All of it(the method never gets called)? Past a certain if statement?

  Well all the code runs but the playsound, addpotioneffect, removepotioneffect does nothing when I have if(!worldIn.isremote)

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
23 minutes ago, ImperialDragon99 said:

  Well all the code runs but the playsound, addpotioneffect, removepotioneffect does nothing when I have if(!worldIn.isremote)

How did you confirm this? Those methods should all work save for the EntityPlayer#playSound which doesnt work on the logical server you need to use another method. See here for more info.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
7 minutes ago, Animefan8888 said:

How did you confirm this? Those methods should all work save for the EntityPlayer#playSound which doesnt work on the logical server you need to use another method. See here for more info.

I managed to get everything to work except getting rid of the wither effect on the client side, I made a if(worldIn.isremote) statement to add the sounds which works fine. How would I get rid of the visual effect client side?

Animefan8888 Reality Controller

Animefan8888

Posted
Posted (edited)
2 minutes ago, ImperialDragon99 said:

I made a if(worldIn.isremote) statement to add the sounds which works fine.

No don't do that. That's not what you should do at all use one of the other methods of playing a sound.

 

2 minutes ago, ImperialDragon99 said:

How would I get rid of the visual effect client side?

It should go away when you remove it on the server.

Edited by Animefan8888

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
1 minute ago, Animefan8888 said:

No don't do that. That's not what you should do at all use one of the other methods of playing a sound.

 

It should go away when you remove it from the server.

The damage dealing goes away but the visual effect stays, isn't checking if world.isremote is false doing it server side?

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
3 hours ago, Animefan8888 said:

No don't do that. That's not what you should do at all use one of the other methods of playing a sound.

 

It should go away when you remove it on the server.

How would I get rid of the visual effect on the client?

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
2 hours ago, diesieben07 said:

Post updated code.

public class WitherSwordItem extends SwordItem{

    private ArrayList<String> active = new ArrayList<String>();
    private CoolDowns cooldown = new CoolDowns();

    public WitherSwordItem(IItemTier p_i484601, int damage, float p_i484603, Properties p_i484604) {
        super(p_i484601, damage, p_i484603, p_i484604);
    }
    
    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn){

        String pName = playerIn.getDisplayName().toString();
        ItemStack item = playerIn.getHeldItem(handIn);
        if(!worldIn.isRemote) {
            if (cooldown.isDone("WitherSwordRightClick", pName , 3000)){
                if(!active.contains(pName)){
                    System.out.println("On");
                    active.add(pName);
                    playerIn.addPotionEffect(new EffectInstance(Effects.WITHER, 999999999, 0));
                    item.addAttributeModifier(SharedMonsterAttributes.ATTACK_DAMAGE.getName(), new AttributeModifier(ATTACK_DAMAGE_MODIFIER, "Weapon modifier",10, AttributeModifier.Operation.ADDITION), EquipmentSlotType.MAINHAND);
                    item.damageItem(100, playerIn, null);
                
                    
                }else{
                    System.out.println("Off");
                    active.remove(pName);
                    playerIn.removeActivePotionEffect(Effects.WITHER);
                    
               }
            }
            

        }
        
        if(worldIn.isRemote) {
            if (cooldown.isDone("WitherSwordRightClick2", pName , 3000)){
                if(!active.contains(pName)) {
                    playerIn.playSound(SoundEvents.ENTITY_WITHER_AMBIENT, 30, 0);
                
                }else {
                    playerIn.playSound(SoundEvents.BLOCK_LAVA_EXTINGUISH, 30, 0);
                }
            }
    }
        return new ActionResult<ItemStack>(ActionResultType.SUCCESS, item);
    }
}

ImperialDragon99 Tree Puncher

ImperialDragon99

Posted
  • Author
Posted
2 minutes ago, diesieben07 said:

You cannot store data like that in the Item class, there is only one instance of that class.

Okay I'll get on that but why does the wither effect visual stay? I remove it the damage goes away but the visual effect stays

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)
3 minutes ago, EhAdam said:

https://skmedix.github.io/ForgeJavaDocs/javadoc/forge/1.9.4-12.17.0.2051/net/minecraft/item/ItemStack.html#getTagCompound--

https://skmedix.github.io/ForgeJavaDocs/javadoc/forge/1.9.4-12.17.0.2051/net/minecraft/nbt/NBTTagCompound.html

No. Capabilities exist.

Also good job linking someone using 1.14.4 to the 1.9.4 documentation.

Edited by Draco18s
  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept