[SOLVED] [1.12.2] Runnable Scheduled Tasks

[Differentiation]

I know it's good to schedule the messages received by the client and server in order to avoid crashes and bugs. However, should I make the messages scheduled or only a certain few? If so, how do I know which ones to add as a scheduled task?

 

Any help is appreciated.

 

Thanks

Edited October 15, 2019 by Differentiation

[DavidM]

Packet handling and the game are on different threads. Therefore, any actions concerning the game should be in a scheduled task (i.e. world manipulation, tile entity manipulation, etc).

[Differentiation]

  On 10/15/2019 at 1:35 AM, DavidM said:

Packet handling and the game are on different threads. Therefore, any actions concerning the game should be in a scheduled task (i.e. world manipulation, tile entity manipulation, etc).

Expand  

So if I have something as simple as EntityPlayer::capabilities#allowFlight = true; in client handler

I'd still need to schedule?

[DavidM]

  On 10/15/2019 at 1:40 AM, Differentiation said:

So if I have something as simple as EntityPlayer::capabilities#allowFlight = true; in client handler

I'd still need to schedule?

Expand  

I believe so.

[Differentiation]

  On 10/15/2019 at 1:41 AM, DavidM said:

I believe so.

Expand  

Thanks! Solved.

[Draco18s]

  On 10/15/2019 at 1:15 AM, Differentiation said:

should I make the messages scheduled or only a certain few?

Expand  

The simple answer is "any and all."

The only time you wouldn't need to would be if you were going to send a new packet somewhere and did not need to interact with anything outside the handler's current scope. These situations will be so rare and edge-case as to be practically nonexistent.

[Differentiation]

  On 10/15/2019 at 5:38 PM, Draco18s said:

The simple answer is "any and all."

The only time you wouldn't need to would be if you were going to send a new packet somewhere and did not need to interact with anything outside the handler's current scope. These situations will be so rare and edge-case as to be practically nonexistent.

Expand  

Then... can I just do this?

public abstract class AbstractPacket<REQ extends IMessage> implements IMessage, IMessageHandler<REQ, REQ>
{
    @Override
    public REQ onMessage(REQ message, MessageContext context)
    {
        if (context.side == Side.SERVER)
        {
        	EntityPlayerMP player = context.getServerHandler().player;
        	
            	player.getServer().addScheduledTask(new Runnable()
		{
			@Override
			public void run()
			{
		        	handleServerSide(message, player);
			}
		});
        } 
        else
        {
       		EntityPlayer player = Dinocraft.PROXY.getPlayer();
        	
            	Minecraft.getMinecraft().addScheduledTask(new Runnable()
		{
			@Override
			public void run()
			{
		        	handleClientSide(message, player);
			}
		});
        }
        
        return null;
    }

    public abstract void handleClientSide(REQ message, EntityPlayer player);

    public abstract void handleServerSide(REQ message, EntityPlayer player);
}

 

Edited October 15, 2019 by Differentiation