How to make 2 or more enchants compatible with each other (1.12)

NoobMaster4000 · October 30, 2019

How can I make my enchants compatible with other my enchants? I'm not talking about

        @Override
	protected boolean canApplyTogether(Enchantment ench) {
		return super.canApplyTogether(ench) && (ench != Enchantments.SILK_TOUCH);
	}

but like:

I have an enchant that uses

HarvestDropsEvent

and add the drop to your inventory but when I add another enchant that uses the same Event or a drop event it throws a NPE on

ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);

How can I make it compatible so that when I mine if I have the enchant A it adds my drops to my inventory if I have B it drops me more exp but when my pickaxe has both the enchants it drops me more exp and set the drop into my inventory?

Animefan8888 · October 30, 2019

29 minutes ago, NoobMaster4000 said:

and add the drop to your inventory but when I add another enchant that uses the same Event or a drop event it throws a NPE on

Post your code.

NoobMaster4000 · October 30, 2019

EntityPlayer player = (EntityPlayer) event.getHarvester();
		if (event.getHarvester() == null)
			return;
		World world = event.getWorld();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> telepathy = EnchantmentHelper.getEnchantments(hand);
		if (telepathy.isEmpty() || !telepathy.containsKey(InitEnchants.TELEPATHY))
			return;
		int telepathylevel = telepathy.get(InitEnchants.TELEPATHY);
		IBlockState state = event.getState();
		Random random = new Random();
		BlockPos pos = event.getPos();
		Block block = event.getState().getBlock();
		Messages.sendMessage(player, block.toString());
		int fortuneLevel = event.getFortuneLevel();
		ItemStack drop = new ItemStack(block, 1, block.getMetaFromState(state));
		String[] blacklist = ConfigHandler.enchants.telepathy.blacklistblocks;
		boolean isfull = player.inventory.getFirstEmptyStack() == -1;
		if (!world.isRemote) {
			if (telepathylevel > 0) {
				if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block)))
					return;
				event.getDrops().clear();
				if (drop.getItem() instanceof ItemAir)
					return;
				if ((drop != null) && (!(drop.getItem() instanceof ItemAir))) {
					int nItems = 0;
					if ((fortuneLevel > 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size() + random.nextInt(fortuneLevel + 1);
					} else if ((fortuneLevel <= 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size();
					}
					if ((drop.getItem() instanceof ItemBlock)) {
						nItems = 1;
					}
					for (int i = 0; i < nItems; i++) {
						if (!isfull) {
							player.inventory.addItemStackToInventory(drop.copy());
						} else {
							float f = random.nextFloat() * 0.6F + 0.1F;
							float f1 = random.nextFloat() * 0.6F + 0.1F;
							float f2 = random.nextFloat() * 0.6F + 0.1F;
							float f3 = 0.025F;

							EntityItem eitem = new EntityItem(world, pos.getX() + f, pos.getY() + f1, pos.getZ() + f2,
									drop.copy());
							eitem.motionX = (random.nextGaussian() * f3);
							eitem.motionY = (random.nextGaussian() * f3 + 0.20000000298023224D);
							eitem.motionZ = (random.nextGaussian() * f3);
							world.spawnEntity(eitem);
							event.setDropChance(0.0F);
						}
					}
				}
			}
		}
	}

if (event.getAttackingPlayer() instanceof EntityPlayer) {
			if (event.getEntityLiving() instanceof EntityLivingBase) {
				EntityLivingBase entity = (EntityLivingBase) event.getEntityLiving();
				World world = entity.world;
				if (!world.isRemote) {
					EntityPlayer player = (EntityPlayer) event.getAttackingPlayer();
					ItemStack head = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
					Map<Enchantment, Integer> xpboost = EnchantmentHelper.getEnchantments(head);
					if (xpboost.isEmpty() || !xpboost.containsKey(InitEnchants.XP_BOOST))
						return;
					int xpboostlevel = xpboost.get(InitEnchants.XP_BOOST);
					int xp = event.getDroppedExperience();
					int xpboostxlevel = xpboostlevel;
					while (xp > 0) {
						int cap = EntityXPOrb.getXPSplit(xp) + xpboostxlevel;
						xp -= cap;
						entity.world.spawnEntity(new EntityXPOrb(world, entity.posX, entity.posY, entity.posZ, cap));
					}
				}
			}
		}

I want to make these compatible

Draco18s · October 30, 2019

You are doing way more things in your HarvestDropsEvent than you should be. Fortune and exp dropping should already have been taken care of before any of your code gets called.

if (drop.getItem() instanceof ItemAir)

That should never occur.

if ((drop != null) && (!(drop.getItem() instanceof ItemAir))) {

Drop is already not null or the game crashed (assuming you didn't set it to new ItemStack anyway) and you know the item isn't air because you literally just checked for that.

					if ((fortuneLevel > 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size() + random.nextInt(fortuneLevel + 1);
					} else if ((fortuneLevel <= 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size();
					}

This can be simplified.

nItems = event.getDrops().size + (fortuneLevel > 0 ? random.nextInt(fortuneLevel + 1) : 0);

Of course, why are you using the number of stacks as your baseline value? That seems odd. Whatever.

Anyway.

Compatibility.

if (event.getAttackingPlayer() instanceof EntityPlayer) {

...This isn't the harvest drops event, so I don't see why you even have a problem...

NoobMaster4000 · October 30, 2019

4 minutes ago, Draco18s said:
You are doing way more things in your HarvestDropsEvent than you should be. Fortune and exp dropping should already have been taken care of before any of your code gets called.
if (drop.getItem() instanceof ItemAir)
That should never occur.
if ((drop != null) && (!(drop.getItem() instanceof ItemAir))) {
Drop is already not null or the game crashed (assuming you didn't set it to new ItemStack anyway) and you know the item isn't air because you literally just checked for that.
					if ((fortuneLevel > 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size() + random.nextInt(fortuneLevel + 1);
					} else if ((fortuneLevel <= 0) && (!(drop.getItem() instanceof ItemBlock))) {
						nItems = event.getDrops().size();
					}
This can be simplified.

nItems = event.getDrops().size + (fortuneLevel > 0 ? random.nextInt(fortuneLevel + 1) : 0);

Of course, why are you using the number of stacks as your baseline value? That seems odd. Whatever.

Anyway.

Compatibility.
if (event.getAttackingPlayer() instanceof EntityPlayer) {
...This isn't the harvest drops event, so I don't see why you even have a problem...

Sorry, the 2nd code uses

LivingExperienceDropEvent

Anyway, the code of both events works alone is when I set 2 enchants that do the same thing that doesn't work.

Eg: if I have the 1st code enchant and I apply add the enchant that let me mine 3x3 it doesn't work

Draco18s · October 30, 2019

I am not understanding your problem.

NoobMaster4000 · October 30, 2019

14 minutes ago, Draco18s said:

I am not understanding your problem.

I make you an example with 2 other enchants I have:

I have an enchant that breaks an area 3x3x3 dropping the item broken (or the basic block if I break stone for example), a second enchant that "teleport" the drop to your inventory and those doesn't work together

Draco18s · October 30, 2019

Ok, so, you didn't post the 3x3 code and I suspect it doesn't work because, like an idiot, you didn't fire any of the relevant Forge events when you broke those blocks.

NoobMaster4000 · October 30, 2019

4 minutes ago, Draco18s said:

Ok, so, you didn't post the 3x3 code and I suspect it doesn't work because, like an idiot, you didn't fire any of the relevant Forge events when you broke those blocks.

revelant forge events? Which is??

Draco18s · October 30, 2019

The HarvestDropsEvent, for one. If you're breaking blocks and generating loot from them and not firing the HarvestDropsEvent, then your other enchantment which relies on the HarvestDropsEvent to do its thing can't run.

NoobMaster4000 · October 30, 2019

6 hours ago, Draco18s said:

The HarvestDropsEvent, for one. If you're breaking blocks and generating loot from them and not firing the HarvestDropsEvent, then your other enchantment which relies on the HarvestDropsEvent to do its thing can't run.

Oh wow, I'm a idiot!! I use the HarvestDropsEvent ? ? ? ?

Did you read what I said in my first comment? No, I guess

9 hours ago, NoobMaster4000 said:
I have an enchant that uses
HarvestDropsEvent

Edited October 30, 2019 by NoobMaster4000

NoobMaster4000 · October 30, 2019

2 hours ago, diesieben07 said:

And again: Post the code.

I've posted the 2 codes, the enchant that break a 3x3x3 was an example

NoobMaster4000 · October 30, 2019

1 hour ago, diesieben07 said:

This is your issue. If you want to add drops, add them to the list in the event. Don't just spawn them-

It's probably the worst method ever but I have a class for every event so the 2 I've posted are in 2 different classes

Draco18s · October 30, 2019

3 hours ago, NoobMaster4000 said:

Oh wow, I'm a idiot!! I use the HarvestDropsEvent ? ? ? ?

Did you read what I said in my first comment? No, I guess

"Subscribing to" and "firing" are not the same thing.

Post your 3x3 mining enchantment code.

5 hours ago, diesieben07 said:

HarvestDropsEvent does not need to be fired manually, provided you call the correct methods in the Block class to generate the drops (which you should be doing anyways).

While true, I have serious doubts about the code calling the correct methods in the block class, as evidenced by the way he generates drops in the telepathy enchantment. So, one way or another, he's not invoking the HarvestDropsEvent (whether he needs to do so manually depends on other factors; there are legitimate reasons to bypass the Block class code, if admittedly rare).

Oh, speaking of:

12 hours ago, NoobMaster4000 said:


Map<Enchantment, Integer> telepathy = EnchantmentHelper.getEnchantments(hand);
		if (telepathy.isEmpty() || !telepathy.containsKey(InitEnchants.TELEPATHY))
			return;
		int telepathylevel = telepathy.get(InitEnchants.TELEPATHY);

This entire function block is completely and utterly irrelevant.

After checking the telepathy level, just loop over the event.drops() array and attempt to add them to the player's inventory. If it can be added to the player's inventory, remove it from the array. There's no need to go through all that bullshit your code does.

NoobMaster4000 · October 30, 2019

16 minutes ago, Draco18s said:

15 minutes ago, Draco18s said:

After checking the telepathy level, just loop over the event.drops() array and attempt to add them to the player's inventory. If it can be added to the player's inventory, remove it from the array. There's no need to go through all that bullshit your code does.

public static void onTelepathyUse(HarvestDropsEvent event) {
		EntityPlayer player = (EntityPlayer) event.getHarvester();
		if (event.getHarvester() == null)
			return;
		World world = event.getWorld();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> telepathy = EnchantmentHelper.getEnchantments(hand);
		if (telepathy.isEmpty() || !telepathy.containsKey(InitEnchants.TELEPATHY))
			return;
		int telepathylevel = telepathy.get(InitEnchants.TELEPATHY);
//		IBlockState state = event.getState();
//		Random random = new Random();
//		BlockPos pos = event.getPos();
		Block block = event.getState().getBlock();
//		int fortuneLevel = event.getFortuneLevel();
//		ItemStack drop = new ItemStack(block, 1, block.getMetaFromState(state));
		String[] blacklist = ConfigHandler.enchants.telepathy.blacklistblocks;
		boolean isfull = player.inventory.getFirstEmptyStack() == -1;
		if (!world.isRemote) {
			if (telepathylevel > 0) {
				if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block)))
					return;
				if (!isfull) {
					for (int i = 0; i < event.getDrops().size(); i++) {
						player.inventory.addItemStackToInventory(event.getDrops().get(i));
					}
				}
			}
		}
	}
}

Like this? Yes, it works not with the 3x3 enchant but it works

Edited October 30, 2019 by NoobMaster4000

Draco18s · October 30, 2019

Well, you did half of what I said. You're still only checking if things go into the players inventory once (outside the loop no less) and you aren't removing things from event.drops().

And you still haven't posted the 3x3 enchantment's code. You know, the code causing the problem.

Edited October 30, 2019 by Draco18s

NoobMaster4000 · October 30, 2019

18 minutes ago, Draco18s said:

Well, you did half of what I said. You're still only checking if things go into the players inventory once (outside the loop no less) and you aren't removing things from event.drops().

And you still haven't posted the 3x3 enchantment's code. You know, the code causing the problem.

Is just a test, I'll add now what it miss

public static void onExcavateUse(BlockEvent.BreakEvent event) {
		EntityPlayer player = (EntityPlayer) event.getPlayer();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> excavate = EnchantmentHelper.getEnchantments(hand);
		if (excavate.isEmpty() || !excavate.containsKey(InitEnchants.EXCAVATE))
			return;
		int excavatelevel = excavate.get(InitEnchants.EXCAVATE);
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		Block block = event.getState().getBlock();
		String[] blacklist = ConfigHandler.enchants.excavate.blacklistblocks;
		if (!world.isRemote) {
			if (excavatelevel > 0) {
				for (int i = 0; i < (excavatelevel + 1); i++) {
					Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
					for (BlockPos offset2 : it) {
						Block block2 = world.getBlockState(offset2).getBlock();
						if (block2 == block && block2 != Blocks.AIR
								&& !PlayerHelper.isBlacklisted(blacklist, block2.getRegistryName().toString())) {
     						world.destroyBlock(offset2, true);
							hand.damageItem(1, player);
						}
					}
				}
			}
		}
	}

Draco18s · October 30, 2019

5 hours ago, NoobMaster4000 said:

world.destroyBlock(offset2, true);

You remember how diesieben07 said something about calling the right methods in the block class, and how I said you're not calling the Forge events?

Yeah, this is why.

destroyBlock is essentially the same as setBlockToAir. This bypasses all the standard harvesting logic.

NoobMaster4000 · October 31, 2019

2 hours ago, Draco18s said:

You remember how diesieben07 said something about calling the right methods in the block class, and how I said you're not calling the Forge events?

Yeah, this is why.

destroyBlock is essentially the same as setBlockToAir. This bypasses all the standard harvesting logic.

Okay, I'll try.

I use this:

for (int i = 0; i < entityhurt.inventory.armorInventory.size(); i++) {
ItemStack hand = player.inventory.armorItemInSlot(i);

to check the player armor (for telepathy) but on server it crashes because there's no method, how can I check it? I want to make telepathy compatible for pickaxe/armor

Animefan8888 · October 31, 2019

38 minutes ago, NoobMaster4000 said:

Okay, I'll try.

Please just post all of your code(the events) and the problem you are having.

39 minutes ago, NoobMaster4000 said:

but on server it crashes because there's no method, how can I check it?

Use a method that isnt annotated with @SideOnly(Side.CLIENT).

NoobMaster4000 · October 31, 2019

1 hour ago, Animefan8888 said:

Please just post all of your code(the events) and the problem you are having.

Use a method that isnt annotated with @SideOnly(Side.CLIENT).

if (!world.isRemote) {
			if (excavatelevel > 0) {
				for (int i = 0; i < (excavatelevel + 1); i++) {
					Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
					for (BlockPos offset2 : it) {
						Block block2 = world.getBlockState(offset2).getBlock();
						if (/*block2 == block &&*/ block2 != Blocks.AIR
								&& !PlayerHelper.isBlacklisted(blacklist, block2.getRegistryName().toString())) {
							block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
							block2.removedByPlayer(state, world, offset2, player, true);
							hand.damageItem(1, player);
						}

					}
				}
			}
		}

The comment is because I want to set a setting to break only the same block but I have to solve the problem with the redstone since it becore lit_redstone_ore, so I leave there for now

Found this

ItemStack hand = player.inventory.armorInventory.get(i);

~~Now telepathy doesn't work with autosmelt, which is:~~

~~Dropping iron ingots and the ore~~

Edited October 31, 2019 by NoobMaster4000

Animefan8888 · October 31, 2019

2 hours ago, NoobMaster4000 said:


if (!world.isRemote) {
			if (excavatelevel > 0) {
				for (int i = 0; i < (excavatelevel + 1); i++) {
					Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
					for (BlockPos offset2 : it) {
						Block block2 = world.getBlockState(offset2).getBlock();
						if (/*block2 == block &&*/ block2 != Blocks.AIR
								&& !PlayerHelper.isBlacklisted(blacklist, block2.getRegistryName().toString())) {
							block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
							block2.removedByPlayer(state, world, offset2, player, true);
							hand.damageItem(1, player);
						}

					}
				}
			}
		}

This is not all of the code for example I don't knpw what event you are in. You've also given me no idea what enchant you are working on. This is like working on a code base that hasn't been well maintained because I can't tell what piece of code does what or even when it should be called.

NoobMaster4000 · October 31, 2019

5 hours ago, Animefan8888 said:

This is not all of the code for example I don't knpw what event you are in. You've also given me no idea what enchant you are working on. This is like working on a code base that hasn't been well maintained because I can't tell what piece of code does what or even when it should be called.

Sorry, it says "excavatelevel" but:

public static void onExcavateUse(BlockEvent.BreakEvent event) {
		EntityPlayer player = (EntityPlayer) event.getPlayer();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> excavate = EnchantmentHelper.getEnchantments(hand);
		if (excavate.isEmpty() || !excavate.containsKey(InitEnchants.EXCAVATE))
			return;
		int excavatelevel = excavate.get(InitEnchants.EXCAVATE);
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		IBlockState state = event.getState();
		Block block = event.getState().getBlock();
		String[] blacklist = ConfigHandler.enchants.excavate.blacklistblocks;
		boolean breakonlysimilarblocks = ConfigHandler.enchants.excavate.breakonlysimilarblocks;
		if (!world.isRemote) {
			if (excavatelevel > 0) {
				for (int i = 0; i < (excavatelevel + 1); i++) {
					Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
					for (BlockPos offset2 : it) {
						Block block2 = world.getBlockState(offset2).getBlock();
						if (/* block2 == block && */ block2 != Blocks.AIR
								&& !PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block2))) {
							block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
							block2.removedByPlayer(state, world, offset2, player, true);
							hand.damageItem(1, player);
						} else if (breakonlysimilarblocks) {
							if (block2 == block && block2 != Blocks.AIR
									&& !PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block2))) {
								block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
								block2.removedByPlayer(state, world, offset2, player, true);
								hand.damageItem(1, player);
							}
						}
					}
				}
			}
		}
	}

It works with everything (need the last test)

Now the problem is LivingHurtEvent:

String[] blacklist = ConfigHandler.enchants.poison.blacklistentities;
if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(entityhurt)))
return;

The 2 methods are:

public static boolean isBlacklisted(String[] blacklist, String name) {
		for (int i = 0; i < blacklist.length; i++) {
			if (blacklist[i].contains(name)) {
				return true;
			}
		}
		return false;
	}

	public static String getEntityName(Entity entity) {
		return EntityList.getKey(entity).toString();
	}

	public static String getEntityName(Block block) {

		return block.getRegistryName().toString();
	}

	public static String getEntityName(Item item) {

		return item.getRegistryName().toString();
	}

Which works if I hit a cow and the effect work, if I add "minecraft:cow" in the blacklist it work and the effect doesn't work on the cow but but I can't add "minecraft:player", if I hit a player it crashes. I want this blacklist so the entities blacklisted aren't affected

Draco18s · October 31, 2019

3 hours ago, NoobMaster4000 said:

for (int i = 0; i < (excavatelevel + 1); i++) {

Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));

I made a comment about these lines already. You do not need the loop.

3 hours ago, NoobMaster4000 said:

if (block2 == block && block2 != Blocks.AIR

You shouldn't need to check that block2 isn't air.

3 hours ago, NoobMaster4000 said:

if (!world.isRemote)

if (excavatelevel > 0)

You should inverse these checks and instead return, it reduces your indentation and makes your code easier to read.

NoobMaster4000 · October 31, 2019

10 minutes ago, Draco18s said:

I made a comment about these lines already. You do not need the loop.

You shouldn't need to check that block2 isn't air.

You should inverse these checks and instead return, it reduces your indentation and makes your code easier to read.

What about my second problem?

Sign In

How to make 2 or more enchants compatible with each other (1.12)

Recommended Posts

NoobMaster4000

Animefan8888

NoobMaster4000

Draco18s

NoobMaster4000

Draco18s

NoobMaster4000

Draco18s

NoobMaster4000

Draco18s

NoobMaster4000

NoobMaster4000

NoobMaster4000

Draco18s

NoobMaster4000

Draco18s

NoobMaster4000

Draco18s

NoobMaster4000

Animefan8888

NoobMaster4000

Animefan8888

NoobMaster4000

Draco18s

NoobMaster4000

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information