Jump to content

Recommended Posts

Posted

You will have to special-case the player. Players are not entities registered with the entity registry. They're special and so you're going to have to treat them as special.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
38 minutes ago, Draco18s said:

You will have to special-case the player. Players are not entities registered with the entity registry. They're special and so you're going to have to treat them as special.

I know they are not registered with the entity registry, I just don't know how to do it

Posted

entity instanceof PlayerEntity?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
5 minutes ago, Draco18s said:

entity instanceof PlayerEntity?

No, I mean how I put it in my entity check? What I need is exclude the player from the blacklist, he should be always whitelisted so that means:

Blacklist: cow

I hit the cow, no effects. hit the player, effects

Blacklist: {}

I hit the cow, effects. hit the player, effects

 

The blacklist should always exclude the player making him always affected, even if blacklisted somehow

Posted
[19:13:28] [Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.world.BlockEvent$BreakEvent@53c6a690:
java.lang.IllegalArgumentException: Cannot get property PropertyEnum{name=variant, clazz=class net.minecraft.block.BlockStone$EnumType, values=[stone, granite, smooth_granite, diorite, smooth_diorite, andesite, smooth_andesite]} as it does not exist in BlockStateContainer{block=minecraft:iron_ore, properties=[]}
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:204) ~[BlockStateContainer$StateImplementation.class:?]
	at net.minecraft.block.BlockStone.getItemDropped(BlockStone.java:52) ~[BlockStone.class:?]
	at net.minecraft.block.Block.getDrops(Block.java:1563) ~[Block.class:?]
	at net.minecraft.block.Block.getDrops(Block.java:1543) ~[Block.class:?]
	at net.minecraft.block.Block.dropBlockAsItemWithChance(Block.java:720) ~[Block.class:?]
	at net.minecraft.block.Block.dropBlockAsItem(Block.java:710) ~[Block.class:?]
	at net.minecraft.block.Block.harvestBlock(Block.java:929) ~[Block.class:?]
	at com.mod.modcore.events.enchantment.ExcavateEvent.onExcavateUse(ExcavateEvent.java:48) ~[ExcavateEvent.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_20_ExcavateEvent_onExcavateUse_BreakEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
	at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:838) [ForgeHooks.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:309) [PlayerInteractionManager.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.blockRemoving(PlayerInteractionManager.java:261) [PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:732) [NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) [CPacketPlayerDigging.class:?]
	at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) [CPacketPlayerDigging.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) [PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_221]
	at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_221]
	at net.minecraft.util.Util.runTask(Util.java:53) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_221]
if (!PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block2))) {
block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
block2.removedByPlayer(state, world, offset2, player, true);
hand.damageItem(1, player);
}

The error is at 

block2.harvestBlock

Also, telepathy add the item in my inventory and autosmelt on the ground

Telepathy:

boolean isfull = player.inventory.getFirstEmptyStack() == -1;
if (!isfull) {
player.inventory.addItemStackToInventory(event.getDrops().get(i));
}

AutoSmelt:

if (!world.isRemote) {
			ItemStack smelt = FurnaceRecipes.instance().getSmeltingResult(
					new ItemStack(block, 1 + random.nextInt(fortuneLevel + 1), block.getMetaFromState(state)));
			for (int i = 0; i < event.getDrops().size(); i++) {
				if (smelt.getItem() instanceof ItemAir)
					return;
				event.getDrops().clear();
				event.getDrops().add(smelt.copy());
			}
		}

 

Posted
54 minutes ago, diesieben07 said:

Stop posting tiny code snippets. Post your entire classes. And properly format them.

What is this shit:

image.png.f4080fbfbe0f8990e0462ac43a6593d4.png

Telepathy:

boolean isfull = player.inventory.getFirstEmptyStack() == -1;
		if (!world.isRemote) {
			if (telepathylevel > 0) {
				if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block)))
					return;
				for (int i = 0; i < event.getDrops().size(); i++) {
					if (!isfull) {
						player.inventory.addItemStackToInventory(event.getDrops().get(i));
					} else {
						Random random = new Random();
						float f = random.nextFloat() * 0.6F + 0.1F;
						float f1 = random.nextFloat() * 0.6F + 0.1F;
						float f2 = random.nextFloat() * 0.6F + 0.1F;
						float f3 = 0.025F;
						EntityItem eitem = new EntityItem(world, pos.getX() + f, pos.getY() + f1, pos.getZ() + f2,
								event.getDrops().get(i).copy());
						eitem.motionX = (random.nextGaussian() * f3);
						eitem.motionY = (random.nextGaussian() * f3 + 0.20000000298023224D);
						eitem.motionZ = (random.nextGaussian() * f3);
						world.spawnEntity(eitem);
						event.setDropChance(0.0F);
					}
				}
			}
		}

 

Autosmelt:

@SubscribeEvent
	public static void onAutosmeltUse(HarvestDropsEvent event) {
		EntityPlayer player = (EntityPlayer) event.getHarvester();
		if (event.getHarvester() == null)
			return;
		ItemStack hand = player.inventory.getCurrentItem();
		Map<Enchantment, Integer> autosmelt = EnchantmentHelper.getEnchantments(hand);
		if (autosmelt.isEmpty() || !autosmelt.containsKey(InitEnchants.AUTOSMELT))
			return;
		Block block = event.getState().getBlock();
		IBlockState state = event.getState();
		World world = event.getWorld();
		int fortuneLevel = event.getFortuneLevel();
		String[] blacklist = ConfigHandler.enchants.autosmelt.blacklistblocks;
		if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block))) {
			return;
		}
		if (!world.isRemote) {
			ItemStack smelt = FurnaceRecipes.instance().getSmeltingResult(
					new ItemStack(block, 1 + random.nextInt(fortuneLevel + 1), block.getMetaFromState(state)));
			for (int i = 0; i < event.getDrops().size(); i++) {
				if (smelt.getItem() instanceof ItemAir)
					return;
				event.getDrops().clear();
				event.getDrops().add(smelt.copy());
			}
		}
	}

 

The error log is for this:

@SubscribeEvent
	public static void onExcavateUse(BlockEvent.BreakEvent event) {
		EntityPlayer player = (EntityPlayer) event.getPlayer();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> excavate = EnchantmentHelper.getEnchantments(hand);
		if (excavate.isEmpty() || !excavate.containsKey(InitEnchants.EXCAVATE))
			return;
		int excavatelevel = excavate.get(InitEnchants.EXCAVATE);
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		IBlockState state = event.getState();
		Block block = event.getState().getBlock();
		String[] blacklist = ConfigHandler.enchants.excavate.blacklistblocks;
		boolean breakonlysimilarblocks = ConfigHandler.enchants.excavate.breakonlysimilarblocks;
		if (!world.isRemote) {
			if (excavatelevel > 0) {
				for (int i = 0; i < (excavatelevel + 1); i++) {
					Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
					for (BlockPos offset2 : it) {
						Block block2 = world.getBlockState(offset2).getBlock();
						if (!PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block2))) {
							block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
							block2.removedByPlayer(state, world, offset2, player, true);
							hand.damageItem(1, player);
						} else if (breakonlysimilarblocks) {
							if (block2 == block
									&& !PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block2))) {
								block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);
								block2.removedByPlayer(state, world, offset2, player, true);
								hand.damageItem(1, player);
							}
						}
					}
				}
			}
		}
	}

 

With error at line: 

block2.harvestBlock(world, player, offset2, state, null, ItemStack.EMPTY);

 

Posted (edited)
50 minutes ago, diesieben07 said:

Still not full classes. But here we go:

 

This logic is flawed. Just because the inventory has no empty slots does not mean there is no room. Use the IItemHandler API or just ItemHandlerHelper.giveItemToPlayer.

 

What? Why?

 

Use EnchantmentHelper.getEnchantmentLevel.

 

You cannot do this. Block metadata is not itemstack metadata. To obtain an ItemStack from a block you must call Block#getPickBlock. Your code will produce invalid and nonsensical ItemStacks (or even just straight up crash, not all blocks have an item).

In your case you want the silk-touch drop though, not the exact ItemStack. There is no straightforward way to obtain the silk touch drop, although you can try to call Block#getSilkTouchDrop (might be invalid, mods might just override Block#harvestBlock and disregard getSilkTouchDrop, but thats unlikely).

 

You are telling "block2" that it was harvested with the block state of "block" (event.getState).

Maybe I misunderstood or I explained bad, the autosmelt and telepathy enchants works both at the same time, if I harvest a block with a pickaxe with both of them, iron ore block and iron ingot from autosmelt enchant.

 

package com.mod.modcore.events.enchantment;

import java.util.Map;
import java.util.Random;

import com.mod.modcore.config.ConfigHandler;
import com.mod.modcore.init.InitEnchants;
import com.mod.modcore.lib.PlayerHelper;

import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentHelper;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemAir;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.world.World;
import net.minecraftforge.event.world.BlockEvent.HarvestDropsEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class AutosmeltEvent {

	static Random random = new Random();

	@SubscribeEvent
	public static void onAutosmeltUse(HarvestDropsEvent event) {
		EntityPlayer player = (EntityPlayer) event.getHarvester();
		if (event.getHarvester() == null)
			return;
		ItemStack hand = player.inventory.getCurrentItem();
		Map<Enchantment, Integer> autosmelt = EnchantmentHelper.getEnchantments(hand);
		if (autosmelt.isEmpty() || !autosmelt.containsKey(InitEnchants.AUTOSMELT))
			return;
		Block block = event.getState().getBlock();
		IBlockState state = event.getState();
		World world = event.getWorld();
		@SuppressWarnings("unused")
		int fortuneLevel = event.getFortuneLevel();
		String[] blacklist = ConfigHandler.enchants.autosmelt.blacklistblocks;
		if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block))) {
			return;
		}
		if (!world.isRemote) {
			ItemStack smelt = FurnaceRecipes.instance()
					.getSmeltingResult(block.getPickBlock(state, null, world, event.getPos(), player));
			for (int i = 0; i < event.getDrops().size(); i++) {
				if (smelt.getItem() instanceof ItemAir)
					return;
				event.getDrops().clear();
				event.getDrops().add(smelt.copy());
			}
		}
	}
}

I have this now, and works but I don't know how to add the fortunelevel to allow drop more items.

Edited by NoobMaster4000
Posted

You aren't using the contents of the event's drops, you're constructing a new block item based on what was broken. So telepathy comes along, gobbles up the iron ore first, then autosmelt comes along, doesn't look at the drops list, and constructs a new drop (nukes whatever's still in the list) and adds the iron ingot.

 

If you had one event handler in one location and actually used the drops from the event you could control this. But you're running ramshackle all over standard practice and doing whatever you feel like doing and producing barely functional code and then going "huh, I wonder why these two won't play nice together." They don't play nice together because you shat all over the system that makes them play nice together.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
2 hours ago, Draco18s said:

You aren't using the contents of the event's drops, you're constructing a new block item based on what was broken. So telepathy comes along, gobbles up the iron ore first, then autosmelt comes along, doesn't look at the drops list, and constructs a new drop (nukes whatever's still in the list) and adds the iron ingot.

 

If you had one event handler in one location and actually used the drops from the event you could control this. But you're running ramshackle all over standard practice and doing whatever you feel like doing and producing barely functional code and then going "huh, I wonder why these two won't play nice together." They don't play nice together because you shat all over the system that makes them play nice together.

Okay, instead of nuke the drop list I did this:

                     if (!world.isRemote) {
			for (int i = 0; i < event.getDrops().size(); i++) {
				if (!event.getDrops().isEmpty() && event.getDrops().get(i).getItem() instanceof ItemBlock) {
					ItemStack drop = event.getDrops().get(i);
					Block b = Block.getBlockFromItem(drop.getItem());
					ItemStack smelt = FurnaceRecipes.instance()
							.getSmeltingResult(b.getPickBlock(state, null, world, event.getPos(), player));
					smelt.setCount(1 + random.nextInt(fortuneLevel +1));
					if (smelt.getItem() instanceof ItemAir)
						return;
					if (event.getDrops().contains(drop)) {
						event.getDrops().remove(drop);
					}
					event.getDrops().add(smelt.copy());
				}
			}
		}
Spoiler

@EventBusSubscriber
public class AutosmeltEvent {

	static Random random = new Random();

	@SubscribeEvent
	public static void onAutosmeltUse(HarvestDropsEvent event) {
		EntityPlayer player = (EntityPlayer) event.getHarvester();
		if (event.getHarvester() == null)
			return;
		ItemStack hand = player.inventory.getCurrentItem();
		Map<Enchantment, Integer> autosmelt = EnchantmentHelper.getEnchantments(hand);
		if (autosmelt.isEmpty() || !autosmelt.containsKey(InitEnchants.AUTOSMELT))
			return;
		Block block = event.getState().getBlock();
		IBlockState state = event.getState();
		World world = event.getWorld();
		@SuppressWarnings("unused")
		int fortuneLevel = event.getFortuneLevel();
		String[] blacklist = ConfigHandler.enchants.autosmelt.blacklistblocks;
		if (PlayerHelper.isBlacklisted(blacklist, PlayerHelper.getEntityName(block))) {
			return;
		}
		if (!world.isRemote) {
			for (int i = 0; i < event.getDrops().size(); i++) {
				if (!event.getDrops().isEmpty() && event.getDrops().get(i).getItem() instanceof ItemBlock) {
					ItemStack drop = event.getDrops().get(i);
					Block b = Block.getBlockFromItem(drop.getItem());
					ItemStack smelt = FurnaceRecipes.instance()
							.getSmeltingResult(b.getPickBlock(state, null, world, event.getPos(), player));
					smelt.setCount(1 + random.nextInt(fortuneLevel +1));
					if (smelt.getItem() instanceof ItemAir)
						return;
					if (event.getDrops().contains(drop)) {
						event.getDrops().remove(drop);
					}
					event.getDrops().add(smelt.copy());
				}
			}
		}
	}
}

 

 Reverted the problem, now telepathy come over autosmelt.

Probably my modification is wrong and using 

ItemHandlerHelper.giveItemToPlayer(player, event.getDrops().get(i));

Now drop both

Edited by NoobMaster4000
Posted
20 minutes ago, NoobMaster4000 said:

if (smelt.getItem() instanceof ItemAir)
	return;

You want continue here. You don't want to abort if one item can't be smelted.

22 minutes ago, NoobMaster4000 said:

if (event.getDrops().contains(drop)) {
	event.getDrops().remove(drop);
}

??? How would drops not contain drop? You pulled it out of the array in the first place.

ItemStack drop = event.getDrops().get(i);

And oh yeah, you can't modify an array while looping over it with a for-loop. The game should crash with a ConcurrentModificationException.

 

25 minutes ago, NoobMaster4000 said:

Block b = Block.getBlockFromItem(drop.getItem());
ItemStack smelt = FurnaceRecipes.instance()
	.getSmeltingResult(b.getPickBlock(state...

Seriously? What the fuck. You already had the item stack version of the block. It's drop. You're not trying to smelt the block that got mined, so stop trying to convert to it: you're trying to smelt the dropped item regardless of what that item is. Imagine an ore block that doesn't drop a blockitem, but which drops a chunk of raw ore.

28 minutes ago, NoobMaster4000 said:

smelt.setCount(1 + random.nextInt(fortuneLevel +1));

Great, now you fucked up the furnace recipes.

And you're fucking with fortune in a place you shouldn't be fucking with fortune (again). Fortune already triggered. You should use the size of the smelt stack times the size of the drop stack and assign it to the cloned stack.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
1 hour ago, Draco18s said:

You want continue here. You don't want to abort if one item can't be smelted.

??? How would drops not contain drop? You pulled it out of the array in the first place.


ItemStack drop = event.getDrops().get(i);

And oh yeah, you can't modify an array while looping over it with a for-loop. The game should crash with a ConcurrentModificationException.

 

Seriously? What the fuck. You already had the item stack version of the block. It's drop. You're not trying to smelt the block that got mined, so stop trying to convert to it: you're trying to smelt the dropped item regardless of what that item is. Imagine an ore block that doesn't drop a blockitem, but which drops a chunk of raw ore.

Great, now you fucked up the furnace recipes.

And you're fucking with fortune in a place you shouldn't be fucking with fortune (again). Fortune already triggered. You should use the size of the smelt stack times the size of the drop stack and assign it to the cloned stack.

Testing but I think I've solved. I want that fortune works with autosmelt when mining an iron ore, like it does with the redstone because now it gives me only 1 item

Edited by NoobMaster4000
Posted
11 hours ago, NoobMaster4000 said:

I want that fortune works with autosmelt when mining an iron ore, like it does with the redstone because now it gives me only 1 item

Ok, great, but you're not doing it correctly.

You aren't performing the increase based on whether or not it was an ore block (of any variety) that was broken. You're doing it all the time as long as there's a smelting result. And you're corrupting the furnace recipes at the same time.

 

Try mining regular stone, see what happens.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.