[1.12.2] bukkit like scheduler for forge?

[JoelGodOfWar]

Is there a scheduler for the server to run a runnable after a delay? Like the one in bukkit/spigot?

I'm trying to port my plugin to a Forge Serverside Mod. The mod will only do anything on a server.

Any help will be greatly appreciated.

 

For bukkit/spigot I use the following code.

 

  Reveal hidden contents

		if(player.hasPermission("sps.hermits")||player.hasPermission("sps.op")){
			if(!isCanceled){
				// Below this schedules the runnable to run after a delay
				transitionTask = this.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {

					public void run() {
						setDatime(player, world);
					}
				}, 10 * 20); // This waits 10 seconds before running the Runnable.
			}else{
				isCanceled = false;
			}
		}else if(!player.hasPermission("sps.hermits")||player.hasPermission("sps.op")){
			player.sendMessage("" + lang.get("noperm." + daLang + ""));
		}

 

 

I've been out of Forge Modding for nearly 3 years, and decided to try to bring a plugin from bukkit, into forge.

[Animefan8888]

  On 10/31/2019 at 4:09 AM, JoelGodOfWar said:

Is there a scheduler for the server to run a runnable after a delay?

Expand  

Not that I know of but you can subscribe to the ServerTickEvent and count the ticks yourself.

[JoelGodOfWar]

So I may have found a way to work around this.

Is there anything I should change? Several variables are set in the event that would schedule the runnable in bukkit, daTimer2, playerisinbed, etc.

  Reveal hidden contents

	@SubscribeEvent
	public void servertick(ServerTickEvent event){
		if((daTimer - daTimer2) == 200){
			if(playerisinbed==true){
				if(!isCanceled){
					ITextComponent damsg = new TextComponentString("10s, !isCanceled");
					server.sendMessage(damsg); // Sends message to server terminal not chat.
					broadcast("" + damsg); //Sends message to chat.
				}
			}else{
				daTimer = 0;
			}
		}else if(daTimer > 200){

		}
		
		daTimer++;
	}
	
	public void broadcast(String string){
		
		ITextComponent textComponent = ITextComponent.Serializer.jsonToComponent(string);
		for(EntityPlayerMP playerMP : server.getPlayerList().getPlayers()) {
            try {
				playerMP.sendMessage(TextComponentUtils.processComponent(server, textComponent, playerMP));
			} catch (CommandException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}
        }
	}

 

 

[Draco18s]

  On 11/6/2019 at 1:03 AM, JoelGodOfWar said:

if(playerisinbed==true){

Expand  

Which player?

 

  On 11/6/2019 at 1:03 AM, JoelGodOfWar said:

}else if(daTimer > 200){ }

Expand  

By doing this, you're making it so that the timer counts up forever, because unless "the" player is in a bed, on exactly tick #200, you never reset this counter. And oh yeah, daTimer2 never gets set to anything, so you might have to wait a long time for no apparent reason (because if daTimer2 is something huge, and daTimer got reset to 0, you have to wait a while).

[JoelGodOfWar]

  On 11/6/2019 at 4:00 AM, Draco18s said:

Which player?

 

By doing this, you're making it so that the timer counts up forever, because unless "the" player is in a bed, on exactly tick #200, you never reset this counter. And oh yeah, daTimer2 never gets set to anything, so you might have to wait a long time for no apparent reason (because if daTimer2 is something huge, and daTimer got reset to 0, you have to wait a while).

Expand  

Which player doesn't matter for my reasons, a player is in bed, the variable is set in another function to start the look for the 200 tick delay.

daTimer2 is set to daTimer by the same function as playerisinbed. Should I reset daTimer every now and then?

I just need to know when 200 ticks(10 seconds) have elapsed. And since the servertickevent runs every tick, either I need to reset daTimer constantly, or just let it count up. I've been looking at bukkit's source to try to see if there was a way to make my own scheduler. I'm surprised forge has never added a scheduler, to run code at a certain delay.

I'm trying to port my SinglePlayerSleep plugin over to forge, it will run serverside only, adding nothing if used on clientside.

[Draco18s]

  On 11/6/2019 at 4:17 AM, JoelGodOfWar said:

Should I reset daTimer every now and then?

Expand  

...every time you change daTimer or your timer won't be 200 ticks long.

Otherwise it's going to look like this:

"Hey! Start a timer!"
"How long?"

"I dunno, wait until whatever time makes the condition true."

[JoelGodOfWar]

  On 11/6/2019 at 3:15 PM, Draco18s said:

...every time you change daTimer or your timer won't be 200 ticks long.

Otherwise it's going to look like this:

"Hey! Start a timer!"
"How long?"

"I dunno, wait until whatever time makes the condition true."

Expand  

What if I start the timer with daTimer being 200, and count down to 0, then until I set it to 200 again, it does nothing?

Do you think that would be more efficient?

I could also add checks so that when daTimer gets higher than 200, or lower than 0, the counter stops adding/subtracting until it is called.

[Draco18s]

  On 11/6/2019 at 8:55 PM, JoelGodOfWar said:

Do you think that would be more efficient?

Expand  

Yes

[JoelGodOfWar]

  On 11/6/2019 at 11:20 PM, Draco18s said:

Yes

Expand  

How about this? If daTimer is set to -1 do nothing, if daTimer gets below -1 then set it to -1 so it does nothing, if daTimer is set higher than -1 then count down to 0 to run code.

  Reveal hidden contents

		if(daTimer <= -2){
			daTimer = -1;
		}else if(!(daTimer == -1)){
			daTimer--;
		}else if(daTimer == 0){
			// Timer done run code.
		}

 

 

[Draco18s]

Two statements

		if(daTimer == 0){
			// Timer done run code.
			daTimer = -1;
		}else if(daTimer > 0){
			daTimer--;
		}

There's literally no need to set it to -1 if its less than -1, as if it is less than -1, you don't do anything anyway.

[JoelGodOfWar]

  On 11/7/2019 at 3:13 AM, Draco18s said:

Two statements

		if(daTimer == 0){
			// Timer done run code.
			daTimer = -1;
		}else if(daTimer > 0){
			daTimer--;
		}

There's literally no need to set it to -1 if its less than -1, as if it is less than -1, you don't do anything anyway.

Expand  

That does seem more efficient than my code. Hope my next bit of code goes this smoothly. Thank you.