Jump to content

Recommended Posts

Posted

Is there a simple way to check if a block can be activated?

Ideally, it would return the same result as onBlockActivated, but without actually affecting anything.

Not sure if this is viable or even possible...

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted

If I understood correctly, I am pretty sure there is no way to achieve this.

Block#onBlockActivated does 2 things: determine whether the block is “activatable” (indicated by the return value) and do stuff when the block is activated. Since these two things are packed together in one method, there is no way to prevent one from happening.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Posted
2 minutes ago, DavidM said:

If I understood correctly, I am pretty sure there is no way to achieve this.

Block#onBlockActivated does 2 things: determine whether the block is “activatable” (indicated by the return value) and do stuff when the block is activated. Since these two things are packed together in one method, there is no way to prevent one from happening.

Yeah, that's what I was worried about.

One option would be to somehow pass in a fake world, which would be pretty ridiculous and not at all viable... probably?

A more likely option would be to iterate over all of the registered blocks after initialization and use reflection to see if they override Block#onBlockActivated. But, that would entirely disregard the actual method's logic and probably be pretty slow (though I'd probably cache it with a config value)...

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted
4 hours ago, diesieben07 said:

The question is: What are you trying to achieve?

I'm altering the block highlight effect when a given block is intractable. It's a sort of "immersive WAILA" type of thing. I'm doing the same for other situations, such as when blocks are harvest-able with a tool, but intractable blocks have been the only hurdle I haven't been able to find a clean solution to.

 

My reflection idea functions well enough, but not being able to perform the actual Block#onBlockActivated check has been a real killer...

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted

Your best bet will, probably, be a fake world (you will need to use a dimension). You'll have to clone the item stacks in the player's hands as well to avoid inadvertent modification (e.g. barrel blocks that get right clicked with an item to store items) and may have to use a fake player as well (this class already exists; FakePlayer).

 

Feel free to examine my mod for how I use my Filter Dimension to check to see if items can be inserted into TileEntities or not.

https://github.com/Draco18s/ReasonableRealism/tree/1.14.4/src/main/java/com/draco18s/industry

 

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
12 minutes ago, Draco18s said:

Your best bet will, probably, be a fake world (you will need to use a dimension). You'll have to clone the item stacks in the player's hands as well to avoid inadvertent modification (e.g. barrel blocks that get right clicked with an item to store items) and may have to use a fake player as well (this class already exists; FakePlayer).

 

Feel free to examine my mod for how I use my Filter Dimension to check to see if items can be inserted into TileEntities or not.

https://github.com/Draco18s/ReasonableRealism/tree/1.14.4/src/main/java/com/draco18s/industry

 

Thanks for the lead, wasn't expecting a fake world to be that clean!

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted
1 hour ago, imacatlolol said:

wasn't expecting a fake world to be that clean!

It doesn't save blocks, it doesn't generate blocks, it doesn't care about any data in it (it will always check what's there first, and if its what it wants, it uses it, if not it replaces it).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try other builds of this modpack or report it to the modpack creator Looks like an issue with environmental, naturalist and/or crafttweaker
    • Hello! There is an issue with my world(Chocolate Edition modpack), after joining the world all creatures are frozen and the game is not responding or the game crashes after short period of time. Reproduction Steps: Turn on the game Join the world Game crashes immediately or after short period of time. Additional info: Crash log saying that an entity crashed the game is created after the crash(not the logs that I posted, different file from crash-logs, game crashed 3x by Snail, 1x by Small Snail, 1x by Tortoise) Specification: CPU: i5-13600KF GPU: GTX 1070 RAM: 32GB 3200MhZ - allocated 10GB Log links: latest.log: https://mclo.gs/Lp8zlsv crash-reports/crash: https://mclo.gs/XhtyJQI Minecraft version: 1.19.2 Modpack Version: Chocolate Edition 1.9 OS: Windows 10 Java Version: 22.0.2 Minecraft Java: Java 17
    • Hello, for several days I've been trying to find a way to add my animations in this style. @Override public void setupAnim(Entity entity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch) { }   My current public class is : public class FakePlayerModelWithAnim<T extends FakePlayerEntity> extends EntityModel<EntityRenderState>   But i can't do that :  public class FakePlayerModelWithAnim<T extends FakePlayerEntity> extends EntityModel<T> Type parameter 'T' is not within its bound; should extend 'net.minecraft.client.renderer.entity.state.EntityRenderState' But with EntityRenderState it ok and it work !   But my setupAnim look like this :  @Override public void setupAnim(EntityRenderState p_370046_) { super.setupAnim(p_370046_); }   I don't have any access to my entity ! Look like 1.21.1 : @Override public void setupAnim(FakePlayerEntity entity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch) { this.root().getAllParts().forEach(ModelPart::resetPose); this.applyHeadRotation(netHeadYaw, headPitch); this.animateWalk(FakePlayerEntityAnimations.ANIM_PLAYERS_WALKING, limbSwing, limbSwingAmount, 2f, 2.5f); this.animate(entity.idleAnimationState, FakePlayerEntityAnimations.ANIM_PLAYERS_IDLE, ageInTicks, 1f); } But i'm stuck with new version of Forge...
    • Looks like an issue with abyssalsovereigns - this mod has functions that are not working on a server (client-side-only mod)
    • I added some new mods and updated old ones to my forge server and they will run successfully but the moment I try to join ill briefly load into the world and get booted with the message, internal server error. The mods in question work fine on singleplayer and removing too many from the server causes it to stop working so I cant be sure which one is causing the problem... any ideas? server log: https://pastebin.com/hGH8UUjm client log (from modrinth app): https://mclo.gs/a3oOUGY
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.