Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.14.4] ContainerGUI not syncing with Server


Recommended Posts

I've been trying to build a custom container block with a GUI that has an input slot that can consume items.
So far i can open the GUI, see and use my own inventory, put items into the input slot of my GUI and by pressing a button in the GUI, the stack in the input slot is "consumed" one item at a time.
However, when i click the input slot, I get all of the items I put in back, even if the slot appears to be completely empty.
I'm assuming there is something going wrong communicating the changes in stack size to the server and when I click the slot, the game assumes nothing has changed.
Does anyone have any idea of what I could've missed?

Edited by Tessa
follow common formatting
Link to post
Share on other sites

Hard to know for sure without seeing your code, but I'm guessing you're doing the "consume" operation client-side, and that's not to going to work.

 

When the button is clicked, the server needs to know; in other words, send a custom "this button was clicked" packet to the server, and do the inventory change there.  Changes don't get magically sent to the server if you modify a slot client-side; if you look at vanilla code, you'll see packets are used to handle this (take a look at PlayerController#windowClick() for example - modifying the container slot and sending a packet to the server are done separately).

Link to post
Share on other sites
37 minutes ago, Tessa said:

I was assuming the item/slot manipulation functions in the base container class would take care of it manually, but then i'll take a look at the vanilla click code.
Thanks a lot!

GUI-Slots are, yes. But your button doesn't hook into those mechanisms. You must send a packet.

See this (old, 1.12) code:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/ores/client/gui/GuiContainerOreCart.java#L77

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

Okay, so making and sending custom packets appears to be pretty challenging and I doubt that I have the knowledge to take that beast on. In some tutorials I see people using the ItemStackHandler Capability, in which case they often have inventories in an entity instead of a container. Would that be an alternative or do you guys know a different workaround for me?

Link to post
Share on other sites
24 minutes ago, Tessa said:

Okay, so making and sending custom packets appears to be pretty challenging and I doubt that I have the knowledge to take that beast on. In some tutorials I see people using the ItemStackHandler Capability, in which case they often have inventories in an entity instead of a container. Would that be an alternative or do you guys know a different workaround for me?

capabilities have to be synced too so no you must use packets and its not that difficult to be honest. 

https://mcforge.readthedocs.io/en/latest/networking/simpleimpl/

 

Link to post
Share on other sites
  • 1 month later...

Just wanted to "close" this topic by saying I managed to get the packets working. Indeed, it wasn't too difficult. I didn't feel like the Forge documentation got me all the way there, but with the help of a few tutorials and other forum posts I got it together. When clicking the GUI button a packet gets sent to the server telling it to reduce the stack size of my input slot.

Link to post
Share on other sites
1 hour ago, Tessa said:

Just wanted to "close" this topic by saying I managed to get the packets working. Indeed, it wasn't too difficult. I didn't feel like the Forge documentation got me all the way there, but with the help of a few tutorials and other forum posts I got it together. When clicking the GUI button a packet gets sent to the server telling it to reduce the stack size of my input slot.

The server should also check if the operation is successful (if you haven't added that already). Clients could just send fake information to the server, which would carry them out if no check is in place.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to post
Share on other sites

After handling the packet I did the "setPacketHandled" thing, and the packet itself is registered through forge's SimpleChannel

	public static void handle(Packet_HandInQuest msg, Supplier<NetworkEvent.Context> ctx) {
		DangerSignTile te = (DangerSignTile)ctx.get().getSender().getServerWorld().getTileEntity(msg.pos);
		te.container.takeQuestItems(msg.questInt);
		te.container.takeKillCount(msg.questInt);
		te.container.giveRewards(msg.questInt);
		te.setQuestCompleted(msg.questInt);
		ctx.get().setPacketHandled(true);
	}
Link to post
Share on other sites

What happens if a client sends a packet with forged (fake) information in it?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

If I am a malicious player playing on a server, I can modify my clients to send fake quest complete packets.

Your current packet handling code will allow me to obtain quest rewards over and over, since it does not check for 1) if the quest is already completed 2) if the player has the quest items in his inventory.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • And also if u could help create a server with forge 
    • package com.example.examplemod; import java.util.Collection; import net.minecraft.client.Minecraft; import net.minecraft.client.network.NetworkPlayerInfo; import net.minecraft.command.CommandBase; import net.minecraft.command.CommandException; import net.minecraft.command.ICommand; import net.minecraft.command.ICommandSender; import net.minecraftforge.client.ClientCommandHandler; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.common.Mod.EventHandler; import net.minecraftforge.fml.common.event.FMLPostInitializationEvent; @Mod(modid = "PartyAll", name = "PartyAll", version = "1.0", acceptedMinecraftVersions = "[1.16.X]") public class ExampleMod extends CommandBase {   @EventHandler   public void init(FMLPostInitializationEvent event) {     MinecraftForge.EVENT_BUS.register(this);     ClientCommandHandler.instance.func_71560_a((ICommand)this);   }      public int func_82362_a() {     return 0;   }      public String func_71517_b() {     return "pall";   }      public String func_71518_a(ICommandSender sender) {     return null;   }      public void func_71515_b(ICommandSender sender, String[] args) throws CommandException {     (new Thread(() -> myRun(sender))).start();   }      public void myRun(ICommandSender sender) {     Collection<NetworkPlayerInfo> playersC = Minecraft.func_71410_x().func_147114_u().func_175106_d();     playersC.forEach(loadedPlayer -> {           String loadedPlayerName = loadedPlayer.func_178845_a().getName();           (Minecraft.func_71410_x()).field_71439_g.func_71165_d("/p " + loadedPlayerName);           try {             Thread.sleep(150L);           } catch (InterruptedException e) {             e.printStackTrace();           }          });   } @Override public String getCommandName() {     // TODO Auto-generated method stub     return null; } @Override public String getCommandUsage(ICommandSender sender) {     // TODO Auto-generated method stub     return null; } @Override public void processCommand(ICommandSender sender, String[] args) throws CommandException {     // TODO Auto-generated method stub      } }  
    • Now that i'm using 1.16 it still gives me errors with the func_ note: I'm not a professional
    • I am installing forge but then it changes it in WinRar version and then i cant do anything with it please help 😪
    • The darkness is associated with ambient occlusion, in your block class you can modify this with: @Override public float getAmbientOcclusionLightValue(BlockState state, IBlockReader worldIn, BlockPos pos) { return (some float); } I've found that small values (usually around 0.1F) reduce the dark. Alternatively in your block model json you can disable or enable occlusion with: "ambientocclusion": true/false  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.