Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

onItemRightClick return an item [1.15.1]


Dr.Nickenstein
 Share

Recommended Posts

46 minutes ago, Dr.Nickenstein said:

So I want this item to check the block that it hits on right click, and if it is a certain block, it returns a certain item

 

Don't do it on the item, do it on the block. If it is your block override onBlockActivated and check if the player is holding your item. If it is a vanilla block use events to achieve the same thing.

Link to comment
Share on other sites

55 minutes ago, Dr.Nickenstein said:

Yes, it is. It's called "RubberStreamingRubberWoodLog", that's the class that I created.

 

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

Edited by Cerandior
Link to comment
Share on other sites

3 minutes ago, Cerandior said:

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

so this? player.getHeldItem(handIn); and then how do i check which item it is?

Edited by Dr.Nickenstein
Link to comment
Share on other sites

Just now, Dr.Nickenstein said:

so this? player.getHeldItem(handIn); and then how do i check which item it is?

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Link to comment
Share on other sites

Just now, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Yeah i want this block to drop a certain item when it is right clicked (activated) with another item.

Link to comment
Share on other sites

10 minutes ago, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

Edited by Dr.Nickenstein
Link to comment
Share on other sites

4 minutes ago, Dr.Nickenstein said:

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 

Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:

if(condition){
statement
}

 

Link to comment
Share on other sites

12 minutes ago, Cerandior said:

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 


Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:


if(condition){
statement
}

 

For the second error, i corrected it later but didn't correct the post with it, for the first one thanks. BTW wehn you do (item instanceof ItemInit.RUBBER_EXTRACTOR)

{

stuff

}

it says rubber extractor isn't a type, and I can't reference any kind of other items

Edited by Dr.Nickenstein
Link to comment
Share on other sites

3 hours ago, Dr.Nickenstein said:

item instanceof ItemInit.RUBBER_EXTRACTOR

Sigh.

Let me break this down.

X instanceof Y requires X to be an object and Y to be a Class.

X == Y requires X to be an object (or primative) and Y to be an object (or primative).

Your code, item instanceof ItemInit.RUBBER_EXTRACTOR, has X is an object, Y is an object.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So i just bought a RLcraft server for me and my friends to play on. I launched it and it is working fine but it tells me that i need to download all the mods i go to mods and press "minecraft forge" and nothing shows up that i can open files. If anyone have a suggestion i would need the help. This is the server hosting i  used 
    • i did it in 1.12.2 not walking for me can anyone help me get it pls???  
    • Got the rotation working. I had to look at LivingEntityRenderer#render and setupRotations a little more closely, and I realized that I needed to change the custom entity's yBodyRot and yBodyRotO.  private static boolean renderingCustomEntity = false; private static CustomEntity customEntity; private static void refreshCustomEntity(LocalPlayer localPlayer, LivingEntity livingEntity) { if (customEntity == null || customEntity.isRemoved()) { customEntity = ModEntities.CUSTOM_ENTITY.get().create(localPlayer.clientLevel); } if (!customEntity.level.dimension().equals(livingEntity.level.dimension())) { customEntity.discard(); } } @SubscribeEvent public static void replaceMobModel(RenderLivingEvent.Pre<LivingEntity, EntityModel<LivingEntity>> event) { LocalPlayer localPlayer = Minecraft.getInstance().player; if (localPlayer != null && event.getEntity() instanceof Mob mob) { if (/* put your own condition here */) { if (!renderingCustomEntity) { try { renderingCustomEntity = true; event.setCanceled(true); refreshCustomEntity(localPlayer, mob); // (truth be told, my custom entity does not have a "head", so these lines aren't needed) // customEntity.setYHeadRot(mob.getYHeadRot()); // customEntity.yHeadRotO = mob.yHeadRotO; customEntity.setYBodyRot(mob.yBodyRot); customEntity.yBodyRotO = mob.yBodyRotO; customEntity.setPose(mob.getPose()); Minecraft.getInstance().getEntityRenderDispatcher().getRenderer(customEntity).render( customEntity, customEntity.yBodyRot, event.getPartialTick(), event.getPoseStack(), event.getMultiBufferSource(), event.getPackedLight() ); } finally { renderingCustomEntity = false; } } } } }   As shown in my code, if the mob whose model is replaced moves to a different dimension, I unload the custom entity with Entity#discard and then reinitialize it on the next tick. I wonder if I also have to unload the custom entity when the mob it is "replacing" dies.
    • Thank you for the video, but I found the issue. I had to update the Gradle from 7.2 to 7.3 in gradle/wrapper/gradle-wrapper.properties.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.