how does the FlowerPotBlock-class know, wich block to show, if put a plant?

[Drachenbauer]

Hello

 

I decided to play around with colors for flowerpots.

 

So i opened a new mod-project and added two new mlocks:

black_flower_pot (an empty flowerpot with black concrete-texture and it´s BlockItem)

black_potted_acacia_sapling (an acatia-sapling, placed in a black flowerpot)

 

Than i made a testrun and i was surprised:

If i place my modded black pot and then put the acacia-sapling, it correctly appears in the black pot.

that means it uses my modded one here.

 

How does the FlowerPotBlock-class know, that it has to place my modded acacia in the black pot here

instead of the the vanilla one in the brown terracotta-pot?

 

I want to add more flowerpot colors (to compleete the 16 minecraft colors).

Does it still choose the plants in the matching colored pots then?

[Drachenbauer]

It wants them as suppliers.

How do i create theese suppliers?

[DaemonUmbra]

This you could google

[Drachenbauer]

Now, with some more google, i found it.

 

at first, i had the simpler constructor-call, so i wonder, why it used the correct variant of the potted sapling in this case.

 

11 hours ago, diesieben07 said:

And then you call addPlant on the empty pot to register your full pots...

In my case, i think, it should look like this:

BLACK_FLOWER_POT.get().addPlant(Blocks.ACACIA_SAPLING.getRegistryName(), BLACK_POTTED_ACACIA_SAPLING_SUPPLIER);

but where in my mod should i place this line.

 

Edit:

Now i made it so:

        DeferredWorkQueue.runLater(() ->
        {
                    ColoredFlowerPotsBlocks.BLACK_FLOWER_POT.get().addPlant(Blocks.ACACIA_SAPLING.getRegistryName(), ColoredFlowerPotsBlocks.BLACK_POTTED_ACACIA_SAPLING_SUPPLIER);
        }
        );

In the common setup like the biome-stuff in the tulips-mod.

This works.

Other things i tryed before, made "object not present" errors.

 

Now i think, i should collect all theese calls for the different plants and pot-colors here.

Edited March 13, 2020 by Drachenbauer

[Drachenbauer]

While i collected the different plants, that can be placed in a flowerpot, i saw, that the model of the cactus is made a very complicated way.

I think, to make it look like it looks ingame, just two model-boxes are needed: a 6x6x6 cube for the pot and a taller 4x4 base box for the cactus itself,

And a dirt-texture is not needed here, because the cactus fills the whoole hole of the pot.

 

Why did they make it so complicated?

 

Now i made separeted handler-classes for the addPlant-lines and the cutout-rendering of the plant-textures.

So the main-mod-class is short and clean.

In the handler-classes i simply placed all theese method-calls in a method, that i now call in the main-class.

Edited March 13, 2020 by Drachenbauer

[Drachenbauer]

Now i have a huge stack of RegistryObjects in my blocks class.

Every possible combination of plant-type (25 different plants) and pot-color (16 color) appears as it´s own registered block.

 

The same for the method-calls for adding the plants to the pots and render them in cutout-style (the render-thing is not needed for the cactus) in their handler-classes.

 

Is there any way to shorten the code, maybe with this for-loop:

ArrayList<String> colors = new ArrayList<String>(Arrays.asList(black, blue, brown, cyan, gray, green, light_blue, light_gray,
                                                               lime, magenta, orange, pink, purple, red, white, yellow));

for (String color : colors)
{
     //do stuff
}

But i don´t know how to create RegistryObjects in a for-loop...

[Draco18s]

4 hours ago, Drachenbauer said:

But i don´t know how to create RegistryObjects in a for-loop...

All I have to say is, "Wow dude, do you Java?"

[Drachenbauer]

Is there no way to reduce this code while still using deferred register?

 

actually i have about 400 RegistryObject-fields in this class, to have all combinations of plants and potcolors.

 

I just heared, that for-loops are often used to shorten code without changing what it should do.

Edited March 14, 2020 by Drachenbauer

[Draco18s]

42 minutes ago, Drachenbauer said:

I just heared, that for-loops are often used to shorten code without changing what it should do.

https://www.w3schools.com/java/java_for_loop.asp

[Drachenbauer]

I know about the for-loop, but i just don´t know, if there is aný way to use it to generate the names of the registry-objects for the deferred register..

[Cyborgmas]

well same difference. You should be able to know to what extent they can serve. It's a basic in a lot of OOP 

[Drachenbauer]

Now i try to work with an Arraylist<RegistryObject<FlowerPotBlock>> instead of alot of single fields.

Or an Arraylist<FlowerPotBlock>.

But no matter, what i try, i get an Registry Object not present error.

Does it matter, that i try to work in a

static
{

}

in the class, because i need to use for-loops to fill the list

The last thing, i tried, is, that i tried to register a block in a variable inside the for-loop and than add the content of the RegistryObject into an Arraylist<FlowerPotBlock>.

 

Why this also gives the error?

Is

public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<>(ForgeRegistries.BLOCKS, Reference.MOD_ID);

unable to handle things in the static thing or a for-loop

 

If yes, how can i register stuff with code inside there?

 

Or is it impossible to register blocks in an Arraylist<RegistryObject<FlowerPotBlock>> ?

Edited March 15, 2020 by Drachenbauer

[Drachenbauer]

Now i have this:

    public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<>(ForgeRegistries.BLOCKS, Reference.MOD_ID);
    
    private static final Supplier<Block> AIR_SUPPLIER = () -> Blocks.AIR;
    
    public static final ArrayList<Supplier<Block>> PLANT_SUPPLIERS = new ArrayList<Supplier<Block>>(Arrays.asList(() -> Blocks.ACACIA_SAPLING,
                                                                                                                  () -> Blocks.ALLIUM,
                                                                                                                  () -> Blocks.AZURE_BLUET,
                                                                                                                  () -> Blocks.BAMBOO,
                                                                                                                  () -> Blocks.BIRCH_SAPLING,
                                                                                                                  () -> Blocks.BLUE_ORCHID,
                                                                                                                  () -> Blocks.BROWN_MUSHROOM,
                                                                                                                  () -> Blocks.CACTUS,
                                                                                                                  () -> Blocks.CORNFLOWER,
                                                                                                                  () -> Blocks.DANDELION,
                                                                                                                  () -> Blocks.DARK_OAK_SAPLING,
                                                                                                                  () -> Blocks.DEAD_BUSH,
                                                                                                                  () -> Blocks.FERN,
                                                                                                                  () -> Blocks.JUNGLE_SAPLING,
                                                                                                                  () -> Blocks.LILY_OF_THE_VALLEY,
                                                                                                                  () -> Blocks.OAK_SAPLING,
                                                                                                                  () -> Blocks.ORANGE_TULIP,
                                                                                                                  () -> Blocks.OXEYE_DAISY,
                                                                                                                  () -> Blocks.PINK_TULIP,
                                                                                                                  () -> Blocks.POPPY,
                                                                                                                  () -> Blocks.RED_MUSHROOM,
                                                                                                                  () -> Blocks.RED_TULIP,
                                                                                                                  () -> Blocks.SPRUCE_SAPLING,
                                                                                                                  () -> Blocks.WHITE_TULIP,
                                                                                                                  () -> Blocks.WITHER_ROSE));
    
    public static final ArrayList<String> COLORS = new ArrayList<String>(Arrays.asList("black",
                                                                                       "blue",
                                                                                       "brown",
                                                                                       "cyan",
                                                                                       "gray",
                                                                                       "green",
                                                                                       "light_blue",
                                                                                       "light_gray",
                                                                                       "lime",
                                                                                       "magenta",
                                                                                       "orange",
                                                                                       "pink",
                                                                                       "purple",
                                                                                       "red",
                                                                                       "white",
                                                                                       "yellow"));
    
    public static final ArrayList<RegistryObject<FlowerPotBlock>> EMPTY_FLOWER_POT_REGISTRIES = new ArrayList<RegistryObject<FlowerPotBlock>>();
    public static final ArrayList<Supplier<FlowerPotBlock>> EMPTY_FLOWER_POT_SUPPLIERS = new ArrayList<Supplier<FlowerPotBlock>>();
    public static final ArrayList<FlowerPotBlock> EMPTY_FLOWER_POTS = new ArrayList<FlowerPotBlock>();
    public static final ArrayList<RegistryObject<FlowerPotBlock>> FULL_FLOWER_POT_REGISTRIES = new ArrayList<RegistryObject<FlowerPotBlock>>();
    public static final ArrayList<Supplier<FlowerPotBlock>> FULL_FLOWER_POT_SUPPLIERS = new ArrayList<Supplier<FlowerPotBlock>>();
    public static final ArrayList<FlowerPotBlock> FULL_FLOWER_POTS = new ArrayList<FlowerPotBlock>();
    
    private static int i;
    private static int j;
    
    static
    {
        i = 0;
        
        for(String color : COLORS)
        {
            EMPTY_FLOWER_POT_REGISTRIES.add(BLOCKS.register(color + "_flower_pot", () -> new FlowerPotBlock(null, AIR_SUPPLIER,
                                            Block.Properties.create(Material.MISCELLANEOUS).hardnessAndResistance(0f).notSolid())));
            EMPTY_FLOWER_POT_SUPPLIERS.add(() -> EMPTY_FLOWER_POT_REGISTRIES.get(i).get());
            
            j = 0;
            
            for(Supplier<Block> plant_supplier : PLANT_SUPPLIERS)
            {
                String plant = plant_supplier.get().getRegistryName().getPath();
                FULL_FLOWER_POT_REGISTRIES.add(BLOCKS.register(color + "_potted_" + plant, () -> new FlowerPotBlock(EMPTY_FLOWER_POT_SUPPLIERS.get(i), plant_supplier,
                                               Block.Properties.create(Material.MISCELLANEOUS).hardnessAndResistance(0f).notSolid())));
                FULL_FLOWER_POT_SUPPLIERS.add(() -> FULL_FLOWER_POT_REGISTRIES.get(j).get());
                j++;
            }
            
            i++;
        }
    }

Why this makes a "RegistryObject not present" error, if i want to access the blocks anywhere in the code?

Only the lines, wich fill the Supplier-Lists, don´t make the error.

 

Why i cannot access theese blocks, or does the registry process not work at list-contents?

Edited March 19, 2020 by Drachenbauer

[Alpvax]

The whole point of registry objects is that they are initialised in the correct event (The DeferredRegister does that too).

Until the registry events have run, the registry objects will be "not present".

 

As all you are after is the id, use RegistryObject#getId() instead of trying to get the object first.

[Drachenbauer]

with the arraylist, i got this error too, as i tried to access the blocks at registering the blockitems.

[Alpvax]

Again, you CANNOT access the blocks until after the event has fired. They simply don't exist.

 

Use the ID, or the RegistryObject itself, it is an instance of Supplier<T>.

I use the following 3 methods to register my blocks:

/**
 * Register a block and a default ItemBlock with the Item group set to my Item group.
 */
private static <T extends Block> RegistryObject<T> register(String name, Supplier<? extends T> block) {
    return register(name, block, (b) -> () -> new BlockItem(b.get(), new Item.Properties().group(AAItems.ITEM_GROUP)));
}
/**
 * Register a block and an Item using a custom Item supplier.
 * @param itemCreator type is (block) -> Supplier<Item>. (block passed in so you could use the same function to define multiple block items).
 */
private static <T extends Block> RegistryObject<T> register(String name, Supplier<? extends T> block, Function<RegistryObject<T>, Supplier<? extends Item>> itemCreator) {
    RegistryObject<T> ret = registerBlockOnly(name, block);
    ITEMS.register(name, itemCreator.apply(ret));
    return ret;
}
/**
 * Register a block with no item (could be used for door/bed halves etc.).
 */
private static <T extends Block> RegistryObject<T> registerBlockOnly(String name, Supplier<? extends T> sup) {
    return BLOCKS.register(name, sup);
}

The reason why you have to pass in suppliers to the DeferredRegister#register methods is so that they can call them in the registry events, i.e. at the correct time.

 

Note that using the block/item objects .get() in suppliers ONLY WORKS FOR GETTING BLOCKS AND ITEMS. This is because those 2 registry events are fired in that order, before any others, and until the event has fired, the object doesn't exist, so cannot be used in other events. (The order of other registries is random, so it might work sometimes and not others.) If you need to access other registry objects, you need to use a supplier (as in pass the actual RegistryObject into the constructor) and get the object when it is needed.

Edited March 19, 2020 by Alpvax

[Drachenbauer]

as i registered my Blocks this way:

public static final RegistryObject<FlowerPotBlock> BLACK_FLOWER_POT = BLOCKS.register("black_flower_pot", () -> new FlowerPotBlock(
                        null, AIR_SUPPLIER,Block.Properties.create(Material.MISCELLANEOUS).hardnessAndResistance(0f).notSolid()));

 

i was able to register the blockitem this way:

public static final RegistryObject<Item> BLACK_FLOWER_POT = ITEMS.register("black_flower_pot", () -> new BlockItem(ColoredFlowerPotsBlocks.BLACK_FLOWER_POT.get(),
                        new Item.Properties().defaultMaxDamage(0).group(ColoredFlowerPots.COLORED_FLOWERPOTS).maxStackSize(64).rarity(Rarity.COMMON).setNoRepair()));

 

Do you mean, that i try to access the block for generating the item-registryname at using the variant with list and for-loop?

 

But once i also had the error, where i called the method addPlant of the FlowerPotBlock, and tried to access the blocks there-

Edited March 19, 2020 by Drachenbauer

[Alpvax]

12 minutes ago, Drachenbauer said:

Do you mean, that i try to access the block for generating the item-registryname at using the variant with list and for-loop?

I'm not quite sure what you mean by this.

 

I would use this as your loop. You have no use for the ..._SUPPLIERS variables, as RegistryObjects ARE Suppliers. And again, the ArrayList<FlowerPotBlock> is useless, because the blocks do not exist yet, so there is nothing to fill the list with.

i = 0;
for(String color : COLORS)
{
    EMPTY_FLOWER_POT_REGISTRIES.add(BLOCKS.register(color + "_flower_pot", () -> new FlowerPotBlock(null, AIR_SUPPLIER,
    Block.Properties.create(Material.MISCELLANEOUS).hardnessAndResistance(0f).notSolid())));

	j = 0;

	for(Supplier<Block> plant_supplier : PLANT_SUPPLIERS)
	{
		String plant = plant_supplier.getId().getPath();
		FULL_FLOWER_POT_REGISTRIES.add(BLOCKS.register(color + "_potted_" + plant, () -> new FlowerPotBlock(EMPTY_FLOWER_POT_SUPPLIERS.get(i), plant_supplier,
								Block.Properties.create(Material.MISCELLANEOUS).hardnessAndResistance(0f).notSolid())));
  		j++;
	}

	i++;
}

 

Edited March 19, 2020 by Alpvax
Code formatting

[Drachenbauer]

But how do i fill the supplyer-thing for the full pots where the need to know their emptx pots?

 

Edit:

 

I noticed, i can put the RegistryObject of the empty pot there.

Edited March 19, 2020 by Drachenbauer

[Drachenbauer]

If i try to use getId from the block-RegistryObject to generate the registryname for the blockitem-registry, i get a NullPointerException...

Edited March 19, 2020 by Drachenbauer

[Alpvax]

18 minutes ago, Drachenbauer said:

If i try to use getId from the block-RegistryObject to generate the registryname for the blockitem-registry, i get a NullPointerException...

What's the exception? With stacktrace preferably.

Is your code on github? It would be easier for me to see if it was.

[Drachenbauer]

Code:

public static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, Reference.MOD_ID);
    
    @SuppressWarnings("unchecked")
    public static final RegistryObject<BlockItem>[] EMPTY_FLOWER_POTS = new RegistryObject[ColoredFlowerPotsBlocks.COLORS.size() + 1];
    
    private static int i;
    
    static
    {
        i = 0;
        
        for (RegistryObject<FlowerPotBlock> empty_pot_register : ColoredFlowerPotsBlocks.EMPTY_FLOWER_POTS)
        {
            String empty_pot = empty_pot_register.getId().getPath();
            
            EMPTY_FLOWER_POTS[i] = ITEMS.register(empty_pot, () -> new BlockItem(empty_pot_register.get(),
                                   new Item.Properties().defaultMaxDamage(0).group(ColoredFlowerPots.COLORED_FLOWERPOTS).maxStackSize(64).rarity(Rarity.COMMON).setNoRepair()));
            
            i++;
        }
    }

 

I tried to use Arrays instead of ArrayLists now.

console:

Spoiler

[m[1;31m[16:54:12] [modloading-worker-1/ERROR] [ne.mi.fm.ja.FMLModContainer/LOADING]: Failed to create mod instance. ModID: coloredflowerpotsmod, class drachenbauer32.coloredflowerpotsmod.ColoredFlowerPots
java.lang.ExceptionInInitializerError: null
    at drachenbauer32.coloredflowerpotsmod.ColoredFlowerPots.<init>(ColoredFlowerPots.java:39) ~[?:?] {re:classloading}
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_241] {}
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_241] {}
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_241] {}
    at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:1.8.0_241] {}
    at java.lang.Class.newInstance(Unknown Source) ~[?:1.8.0_241] {}
    at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:131) ~[?:31.1] {re:classloading}
    at java.util.function.Consumer.lambda$andThen$0(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.function.Consumer.lambda$andThen$0(Unknown Source) ~[?:1.8.0_241] {}
    at net.minecraftforge.fml.ModContainer.transitionState(ModContainer.java:112) ~[?:?] {re:classloading}
    at net.minecraftforge.fml.ModList.lambda$null$10(ModList.java:134) ~[?:?] {re:classloading}
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.ForEachOps$ForEachTask.compute(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.concurrent.CountedCompleter.exec(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinTask.doInvoke(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinTask.invoke(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.ReferencePipeline.forEach(Unknown Source) ~[?:1.8.0_241] {}
    at java.util.stream.ReferencePipeline$Head.forEach(Unknown Source) ~[?:1.8.0_241] {}
    at net.minecraftforge.fml.ModList.lambda$dispatchParallelEvent$11(ModList.java:134) ~[?:?] {re:classloading}
    at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(Unknown Source) [?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) [?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(Unknown Source) [?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) [?:1.8.0_241] {}
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) [?:1.8.0_241] {}
Caused by: java.lang.NullPointerException
    at drachenbauer32.coloredflowerpotsmod.init.ColoredFlowerPotsItems.<clinit>(ColoredFlowerPotsItems.java:65) ~[?:?] {re:classloading}
    ... 30 more

i don´t know, how to display the "30 more" lines at the end, if they include helpful infos

 

 

Edited March 19, 2020 by Drachenbauer

[Alpvax]

Please create a github repository, it is very hard to debug when we only have tiny snapshots of your code.

[DragonITA]

23 minutes ago, Drachenbauer said:

at drachenbauer32.coloredflowerpotsmod.init.ColoredFlowerPotsItems.<clinit>(ColoredFlowerPotsItems.java:65)

 

16 minutes ago, Alpvax said:

Please create a github repository, it is very hard to debug when we only have tiny snapshots of your code.

@Alpvax I know this is basic IDE and Java, but i never work with Debugging, so i am asking me what you do want to make… @Drachenbauer, hope it help you (see that i quoted, it was into drachenbauer32.coloredflowerpotsmod.init.ColoredFlowerPotsItems the line 65)

[Drachenbauer]

i know, where it is, but i don´t know, what´s wrong with that line...

 

I´m sure, it should get the id of the RegistryObject(that´s similar to the RegistryName of the block.)

 

But i don´t know, why it finds no registryname to use...

Edited March 19, 2020 by Drachenbauer