[1.15] How to Grant and Check on Advancements

[Kristopher_RAS]

Hello everyone, I try access to the player advancements to

- first: check if specifics advancements has been granted

- second: Grant advancements.

 

I found several leads like:

 

Minecraft.getInstance().player.connection.getAdvancementManager().setSelectedTab(Minecraft.getInstance().player.connection.getAdvancementManager().getAdvancementList().getAdvancement(Registry.GetRL("copper_cable")), true); 

 

also I found  a class called: PlayerAdvancements (With a grant and revoke function) but I don't know where to find it in the player class or how to instance a new one (the second arguments is a file and I don't know what file it has to be). (https://forge.galaxy.nctu.me/forge/javadoc/14.23.5.2838-stable_39/net/minecraft/advancements/playeradvancements#getProgress-net.minecraft.advancements.Advancement-)

 

Thanks.

 

Note: it's possible to grant achievement through commands but I prefer do it by code.

Edited March 26, 2020 by Kristopher_RAS
title change

[Kristopher_RAS]

After hours of research in the forge and minecraft codes i found it:

 

Minecraft.getInstance().getIntegratedServer().getPlayerList().getPlayerAdvancements(Minecraft.getInstance().getIntegratedServer().getPlayerList().getPlayers().get(0)).grantCriterion(Minecraft.getInstance().player.connection.getAdvancementManager().getAdvancementList().getAdvancement(Registry.GetRL("copper_cable")), "unlock");
Minecraft.getInstance().getIntegratedServer().getPlayerList().getPlayerAdvancements(Minecraft.getInstance().getIntegratedServer().getPlayerList().getPlayers().get(0)).getProgress(Minecraft.getInstance().player.connection.getAdvancementManager().getAdvancementList().getAdvancement(Registry.GetRL("copper_cable"))).getPercent();
				

 

[diesieben07]

No, this is doing terrible things, such as reaching across logical sides.

[Kristopher_RAS]

This is the only way I've found. But if you have a better way don't hesitate to tell.

Edited March 27, 2020 by Kristopher_RAS

[Alpvax]

Your way will crash on a server.

Where are you calling this from? What are you trying to achieve?

[Kristopher_RAS]

I have a research table and when you do a specific researches it unlock some advancements but I have to check first if the previous achievement has been granted or not.

[Alpvax]

So you have an instance of the player (the one using the table).

Use that player to get the server: player.world.getServer();

 

[Kristopher_RAS]

So I tried using player.world.getServer() but it crashed.

I've made some test and player.world.getServer() return null.

 

Note: the player came from the container for the interface.

[DavidM]

Post your code.

It sounds like you are reaching across logical sides.

Make sure you are calling World#getServer from the server side.

Edited March 28, 2020 by DavidM

[Kristopher_RAS]

Well basically the event is called when the player press a button in the interface. But the screen, handle the button events only on client side (I think), so I don't know how to do it on server side.

[Draco18s]

12 hours ago, Kristopher_RAS said:

when the player press a button in the interface

That would be the client side yes. You need to send a packet to the server (all this packet does is say "this button was clicked"!) and the server does the operations neccessary (including checking to make sure that the player is allowed to click the button).

 

Quick "Am I on the Server?" guide:

Is it visual? No, you are on the client

Is it input related? No, you are on the client

Was a world or player object passed to you? Maybe, check world.isRemote (or player.world.isRemote)

isRemote returns true? No, you are on the client

Did you get your world by calling Minecraft.getInstance()? No, you are on the client. Also don't do this unless you know what you're doing.

Edited March 28, 2020 by Draco18s

[diesieben07]

7 hours ago, Draco18s said:

isRemote returns false? No, you are on the client

Not true. isRemote can be read as isClient. If its true you are on the client. false means server.

[Draco18s]

2 hours ago, diesieben07 said:

Not true. isRemote can be read as isClient. If its true you are on the client. false means server.

It was kinda late, I fuckered that up. XD

Fixed it.

Edited March 28, 2020 by Draco18s

[Kristopher_RAS]

OK, so I found this https://mcforge.readthedocs.io/en/1.15.x/networking/simpleimpl/, to learn how to send packet but I'm not sure if EntityPlayerMP is

ClientPlayerEnity or ServeurPlayerEntity (I guess this is he first but i want to be sure).

 

My bad found it: ServeurPlayerEntity

Edited March 28, 2020 by Kristopher_RAS

[Kristopher_RAS]

https://mcforge.readthedocs.io/en/1.15.x/networking/simpleimpl/ Did not really helped me, do you have a proper tutorial on Minecraft networking ??

[Kristopher_RAS]

I've followed this tutorial: 

 

 

And now it work properly this "Research" Function is called on server side (I've tested it with isRemote), Thank you a lot guys.

 

If you want me to post my codes for you to check tell me.

Edited March 28, 2020 by Kristopher_RAS

[Kristopher_RAS]

Last small things, I still to use: 

Minecraft.getInstance().player.connection.getAdvancementManager().getAdvancementList().getAdvancement(Registry.GetRL(AdvName))

to get the advancement, if I'm Serveur side how do I get a ClientPlayerEnity (where is the connection and the advancementManager) ??

[Draco18s]

1 hour ago, Kristopher_RAS said:

Last small things, I still to use: 

Minecraft.getInstance().player.connection.getAdvancementManager().getAdvancementList().getAdvancement(Registry.GetRL(AdvName))

to get the advancement, if I'm Serveur side how do I get a ClientPlayerEnity (where is the connection and the advancementManager) ??

You can't call that code on the server. You can't access a ClientPlayerEntity on the server (it is a CLIENT only class).

[Kristopher_RAS]

So where can I find my advancement ?

 

well found it:

return serverPlayer.getAdvancements().getProgress(serv.getAdvancementManager().getAdvancement(Registry.GetRL(AdvName))).isDone();

Edited March 29, 2020 by Kristopher_RAS