My Packet is dont work

[AlexInCube]

I want the GUI to change the control of the redstone signal when you press a button. But packet don't change the variable in TileEntity. P.S. NBT dont saved too.

GUI Code:

Spoiler

@Override
    public boolean mouseClicked(double mouseX, double mouseY, int mouseButton) {
        int i = (this.width - this.xSize) / 2;
        int j = (this.height - this.ySize) / 2;

        if (super.mouseClicked(mouseX, mouseY, mouseButton)) {
            if (mouseX >= this.guiLeft+133 && mouseY >= this.guiTop+35 && mouseX < this.guiLeft+152 && mouseY < this.guiTop+51) {
                if (this.container.tileEntity.get(0) == 0) {
                    Networking.INSTANCE.sendToServer(new PacketChangeRedstoneControl(this.container.tileEntity.getPos(), 1));
                }else{
                    Networking.INSTANCE.sendToServer(new PacketChangeRedstoneControl(this.container.tileEntity.getPos(), 0));
                }
                return true;
            }
        }
        return super.mouseClicked(mouseX, mouseY, mouseButton);
    }

 

Packet Code:

Spoiler

public class PacketChangeRedstoneControl {

    private final BlockPos blockpos;
    private final int rc;

    public PacketChangeRedstoneControl(PacketBuffer buf){
        blockpos = buf.readBlockPos();
        rc = buf.readInt();
    }

    public void toBytes(PacketBuffer buf){
        buf.writeBlockPos(blockpos);
        buf.writeInt(rc);
    }

    public PacketChangeRedstoneControl(BlockPos blockpos, int rc){
        this.blockpos = blockpos;
        this.rc = rc;
    }

    public void handle(Supplier<NetworkEvent.Context> ctx){
        ctx.get().enqueueWork(() -> {
            TileEntity te = ctx.get().getSender().getServerWorld().getTileEntity(blockpos).getTileEntity();
            ((blockbreakertile) te).set(0,rc);
            });
        ctx.get().setPacketHandled(true);
    }
}

 

TileEntity Code:

Spoiler

private int redstoneControl = 1;


        public int get(int index) {
            switch(index) {
                case 0:
                    return blockbreakertile.this.redstoneControl;

                default:
                    return 0;
            }
        }

        public void set(int index, int value) {
            switch(index) {
                case 0:
                    blockbreakertile.this.redstoneControl = value;
            }
        }

 

 

[AlexInCube]

nobody did that at 1.15?

[Animefan8888]

16 minutes ago, AlexInCube said:

nobody did that at 1.15?

Did you register your packet?

[AlexInCube]

Yes, if i print message in packet it work.

[AlexInCube]

I put the mod on github, I'm trying to make it possible to change the redstone mode in block breaker through gui.

https://github.com/AlexInCube/All-you-need

[diesieben07]

First of all you need to understand a very core concept when sending packets to the server:

The client cannot be trusted.

Your current version allows the client to change any of your TEs in the world, without any safety checks. First of all you do not need to send the block position, the server has the Container available, which holds your TE instance. You should send the windowId though, to ensure that the window is still the same.

Then you also need to validate that the value being sent is actually valid, otherwise clients can cause your server-side mod to crash.

[AlexInCube]

I send windowId into a package. But how do I interact with it?

 

[diesieben07]

15 minutes ago, AlexInCube said:

I send windowId into a package. But how do I interact with it?

Not sure what I mean.

[AlexInCube]

I don't know what kind of code there must be in the package to get something out of windowid.

[diesieben07]

Get the player's open container, check if its the right type and the windowID still matches.

[AlexInCube]

I have to do it through the event?

[diesieben07]

What are you talking about? What event?

[AlexInCube]

I know there's an event through which you can get a container

[diesieben07]

I don't know what on earth you are talking about.

[AlexInCube]

Okay, forget it, I just don't know what code to get the container in the packet.

[diesieben07]

Get the player's open container.

Maybe look at PlayerEntity and try to use your brain a bit and see if you can find a field that mabye, just maybe, holds the container that is currently open?

 

Please, try to use your IDE to at least look at the code a little bit.

[AlexInCube]

I didn't notice in the sender right away that you could get a container.

if (windowId == ctx.get().getSender().openContainer.windowId){ }

I'm checking to see if I'm comparing the windowid and then what?
Do I have to update the variable in Container from TE all the time or try to change the variable in TE and Container at once?

[diesieben07]

The TE should hold the data. Not the container.

[AlexInCube]

Spoiler

public class PacketChangeRedstoneControl {
    private final int windowId;
    private final int rc;

    public PacketChangeRedstoneControl(PacketBuffer buf){
        windowId = buf.readInt();
        rc = buf.readInt();
    }

    public void toBytes(PacketBuffer buf){
        buf.writeInt(windowId) ;
        buf.writeInt(rc);
    }

    public PacketChangeRedstoneControl(int windowId, int rc){
        this.windowId = windowId;
        this.rc = rc;
    }

    public void handle(Supplier<NetworkEvent.Context> ctx){
        ctx.get().enqueueWork(() -> {
            Container playercont=ctx.get().getSender().openContainer;
            if (windowId == playercont.windowId){
                ((blockbreakercontainer)playercont).tileEntity.set(0,rc);
            }
            System.out.println(((blockbreakercontainer)playercont).tileEntity.get(0));
            });
        ctx.get().setPacketHandled(true);
    }
}

 

what did I do wrong?

[diesieben07]

1. You're still blindly casting the tile entity and also not checking for null. Malicious clients can use this to completely crash a server with your mod running on it.
2. Whats the symptom? How do you send the packet?

[AlexInCube]

I want to make it work somehow first, and then think about safety. 

Sending packages this way:

Spoiler

 @Override
    public boolean mouseClicked(double mouseX, double mouseY, int mouseButton) {

        if (mouseX >= this.guiLeft+133 && mouseY >= this.guiTop+35 && mouseX < this.guiLeft+152 && mouseY < this.guiTop+51) {
            if (this.container.getRedstoneControl() == 0) {
                Networking.INSTANCE.sendToServer(new PacketChangeRedstoneControl(this.container.windowId, 1));
            }else{
                Networking.INSTANCE.sendToServer(new PacketChangeRedstoneControl(this.container.windowId, 0));
            }
        }

        return super.mouseClicked(mouseX, mouseY, mouseButton);
    }

 

 

[Ugdhar]

4 minutes ago, AlexInCube said:

I want to make it work somehow first, and then think about safety

That is the #1 worst way to do things ever. I would not trust the security of any server that was running your mod with a mindset like that, unfortunately

[AlexInCube]

I can't do well right away, I'm just learning how to make mods for minecraft.

[AlexInCube]

in general, I'm trying to look at the vanilla class to avoid mistakes.

[AlexInCube]

I put the variables in IIntArray and it works fine.