[1.15.2][Solved] Weird issue with adding blocks to creative tab

[GhostGaming]

I created a mod a few days ago but moved everything to a new project to tidy it up because I really wasn't happy with how unorganized everything was (although most things were working fine). For the most part, the code didn't change which is why I'm utterly confused on why the blocks are not being added to the creative inventory anymore. I tried it with a custom creative tab and also with the vanilla ones but it's not working in both cases. I checked whether the BlockItems are not being registered but they are. I can place the blocks down using /setblock, I can give them to myself using /give and place them down afterwards but they are not only not being rendered in the creative inv, they simply don't exist. Anyone has a clue why this could happen?

Edited April 13, 2020 by GhostGaming

[Animefan8888]

  On 4/13/2020 at 12:17 PM, GhostGaming said:

Anyone has a clue why this could happen?

Expand  

When you created your BlockItem instances did you set the ItemGroup via Item.Properties?

[GhostGaming]

  On 4/13/2020 at 12:20 PM, Animefan8888 said:

When you created your BlockItem instances did you set the ItemGroup via Item.Properties?

Expand  

Yes, I did. I used the code that Cadiboo used in his example mod

[Animefan8888]

  On 4/13/2020 at 12:25 PM, GhostGaming said:

Yes, I did. I used the code that Cadiboo used in his example mod

Expand  

I don't need to look at someone else's code when I am helping you with your own. I have no guarantee you did everything Cadiboo did unless you directly copy-pasted his code.

[GhostGaming]

  On 4/13/2020 at 12:31 PM, Animefan8888 said:

I don't need to look at someone else's code when I am helping you with your own. I have no guarantee you did everything Cadiboo did unless you directly copy-pasted his code.

Expand  

Basically, I loop through all my blocks in the item registry event and create and register a new ItemBlock with the ItemGroup. The weird thing is, that even when using one of my blocks as the tab icon it doesn't show up

[Animefan8888]

  On 4/13/2020 at 12:34 PM, GhostGaming said:

Basically, I loop through all my blocks in the item registry event and create and register a new ItemBlock with the ItemGroup. The weird thing is, that even when using one of my blocks as the tab icon it doesn't show up

Expand  

If you don't show us your code no one on here can actually help you all we can do is make shortsighted guesses on what could be causing your problem. If you don't feel comfortable sharing your code then don't and know we can't really help you.

[GhostGaming]

  On 4/13/2020 at 12:36 PM, Animefan8888 said:

If you don't show us your code no one on here can actually help you all we can do is make shortsighted guesses on what could be causing your problem. If you don't feel comfortable sharing your code then don't and know we can't really help you.

Expand  

Sorry, I was on my phone ?

 

My Mod class constructor:

public GhostsExplosives() {
	final ModLoadingContext modLoadingContext = ModLoadingContext.get();
	final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

	ModBlocks.BLOCKS.register(modEventBus);
	ModItems.ITEMS.register(modEventBus);
	ModEntityTypes.ENTITY_TYPES.register(modEventBus);

	modLoadingContext.registerConfig(ModConfig.Type.CLIENT, ConfigHolder.CLIENT_SPEC, "ghostsexplosives2-client.toml");
	modLoadingContext.registerConfig(ModConfig.Type.SERVER, ConfigHolder.SERVER_SPEC, "ghostsexplosives2-server.toml");
}

 

My ModBlocks class:

public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<>(ForgeRegistries.BLOCKS, GhostsExplosives.MODID);

public static final RegistryObject<BlockTNTGhostsExplosives> TNT_X1_2 = registerBlockTNT(TNTProperties.TNT_X1_2);

 

My ModEventBusSubscriber class:

@Mod.EventBusSubscriber(modid = GhostsExplosives.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class ModEventBusSubscriber {
	@SubscribeEvent
	public static void onItemRegistry(RegistryEvent.Register<Item> event) {
		final IForgeRegistry<Item> registry = event.getRegistry();

		ModBlocks.BLOCKS.getEntries().stream().map(RegistryObject::get).forEach(block -> {
     			final Item.Properties properties = new Item.Properties().group(ItemGroup.SEARCH);
       			final BlockItem blockItem = new BlockItem(block, properties);
       			blockItem.setRegistryName(block.getRegistryName());
       			registry.register(blockItem);
       		});
	}

 

I think this should be everything important

[Animefan8888]

  On 4/13/2020 at 12:45 PM, GhostGaming said:

I think this should be everything important

Expand  

When, where, and how is ItemGroup.SEARCH initialized?

[GhostGaming]

  On 4/13/2020 at 12:52 PM, Animefan8888 said:

When, where, and how is ItemGroup.SEARCH initialized?

Expand  

ItemGroup.SEARCH is the vanilla item group where you can search for items I believe

[GhostGaming]

Here is an image where I tried to add the block in the hotbar to my custom creative tab and set it as the tab icon

 

My custom ItemGroup class:

public class ModItemGroups {
	public static final ItemGroup ITEMGROUP_TNT_BLOCKS = new ModItemGroup("tnt_blocks", () -> new ItemStack(ModBlocks.TNT_X5.get()));
	public static final ItemGroup ITEMGROUP_TNT_MINECARTS = new ModItemGroup("tnt_minecarts", () -> new ItemStack(Items.TNT_MINECART));

	public static final class ModItemGroup extends ItemGroup {
		@Nonnull
		private final Supplier<ItemStack> iconSupplier;

		public ModItemGroup(@Nonnull final String name, @Nonnull final Supplier<ItemStack> iconSupplier) {
			super(GhostsExplosives.MODID + "." + name);
			this.iconSupplier = iconSupplier;
		}

		@Override
		@Nonnull
		public ItemStack createIcon() {
			return iconSupplier.get();
		}
	}
}

 

Edited April 13, 2020 by GhostGaming

[Animefan8888]

  On 4/13/2020 at 1:03 PM, GhostGaming said:

Here is an image where I tried to add the block in the hotbar to the inventory and set it as the tab icon

Expand  

Post your code as a working github repo I would like to test this locally to find an answer. I might be blind or missing information.

[GhostGaming]

  On 4/13/2020 at 1:07 PM, Animefan8888 said:

Post your code as a working github repo I would like to test this locally to find an answer. I might be blind or missing information.

Expand  

I tried using GitHub Desktop to publish my repository but it looks like it completely wrecked my project because all my source files are gone, so I'm gonna cry now for a few days and maybe I'll come back here after I've implemented everything back ?

[GhostGaming]

  On 4/13/2020 at 1:07 PM, Animefan8888 said:

Post your code as a working github repo I would like to test this locally to find an answer. I might be blind or missing information.

Expand  

Well... I got my project back running and the issue still exists. Here is the github repository

[Animefan8888]

  On 4/13/2020 at 5:43 PM, GhostGaming said:

Well... I got my project back running and the issue still exists. Here is the github repository

Expand  

Wait are you registering your Blocks twice? Here and here. I'm not sure how I didn't notice this. And commenting out the registry event fixes the issue. Register your Blocks once and only once.

[GhostGaming]

  On 4/13/2020 at 6:07 PM, Animefan8888 said:

Wait are you registering your Blocks twice? Here and here. I'm not sure how I didn't notice this. And commenting out the registry event fixes the issue. Register your Blocks once and only once.

Expand  

So my blocks are being registered again just by subscribing to the registry event? Interesting, I though that event was just called after all blocks have been registered. But anyways, thanks for your help ?

[Animefan8888]

  On 4/13/2020 at 6:14 PM, GhostGaming said:

So my blocks are being registered again just by subscribing to the registry event? Interesting, I though that event was just called after all blocks have been registered.

Expand  

Actually I'm crazy sleep deprived, they aren't being registered twice. But commenting out the registry event does fix the problem. And honestly I don't have the brain capacity to see what exactly is happening but I'm gonna say the problem is your Items are getting a different version of the Block than what is actually registered. As such the Block to Item mapping is returning an air Block.

[Draco18s]

  On 4/13/2020 at 6:14 PM, GhostGaming said:

So my blocks are being registered again just by subscribing to the registry event? Interesting, I though that event was just called after all blocks have been registered. But anyways, thanks for your help ?

Expand  

Well.

Yes.

Because that's what that event is for. You use either a deferred register or the appropriate event.

 

Also:

// SET THE BLOCKS IN THE TNT PROPERTIES

...do that when you construct the block...seriously. You have a perfectly good place to do this already:

https://github.com/alessio1309/GhostsExplosives/blob/cd50068d6c3d5a213df7e7c8791b2b3d69470ffc/scr/main/java/mod/ghostgaming/ghostsexplosives2/init/ModBlocks.java#L73

Edited April 13, 2020 by Draco18s

[GhostGaming]

  On 4/13/2020 at 6:23 PM, Draco18s said:

Well.

Yes.

Because that's what that event is for. You use either a deferred register or the appropriate event.

 

Also:

// SET THE BLOCKS IN THE TNT PROPERTIES

...do that when you construct the block...seriously. You have a perfectly good place to do this already:

https://github.com/alessio1309/GhostsExplosives/blob/cd50068d6c3d5a213df7e7c8791b2b3d69470ffc/scr/main/java/mod/ghostgaming/ghostsexplosives2/init/ModBlocks.java#L73

Expand  

Yes, I realized that as well, thank you anyways

[GhostGaming]

  On 4/13/2020 at 6:23 PM, Animefan8888 said:

Actually I'm crazy sleep deprived, they aren't being registered twice. But commenting out the registry event does fix the problem. And honestly I don't have the brain capacity to see what exactly is happening but I'm gonna say the problem is your Items are getting a different version of the Block than what is actually registered. As such the Block to Item mapping is returning an air Block.

Expand  

I've examined what exactly caused the problem and it had nothing to do with the registry event but instead with registering the dispense behavior. I don't understand why this is happening but as soon as I register any sort of dispense behavior, even the default one, it won't show up in the creative inventory anymore. Really weird

[Animefan8888]

  On 4/13/2020 at 7:44 PM, GhostGaming said:

I've examined what exactly caused the problem and it had nothing to do with the registry event but instead with registering the dispense behavior. I don't understand why this is happening but as soon as I register any sort of dispense behavior, even the default one, it won't show up in the creative inventory anymore. Really weird

Expand  

Where are you doing it and how are you doing it?

[GhostGaming]

  On 4/13/2020 at 7:46 PM, Animefan8888 said:

Where are you doing it and how are you doing it?

Expand  

In the constructor of the block and by using DispenserBlock.registerDispenseBehavior()

DispenserBlock.registerDispenseBehavior(this, new DefaultDispenseItemBehavior() {
			protected ItemStack dispenseStack(IBlockSource source, ItemStack stack) {
				World world = source.getWorld();
				BlockPos blockpos = source.getBlockPos().offset(source.getBlockState().get(DispenserBlock.FACING));

				BlockTNTGhostsExplosives block = (BlockTNTGhostsExplosives) ((BlockItem) stack.getItem()).getBlock();

				if (block.getProperties().isIgnitableByDispensers()) {
					EntityTNTGhostsExplosives tntentity = new EntityTNTGhostsExplosives(world, (double) blockpos.getX() + 0.5D, (double) blockpos.getY(), (double) blockpos.getZ() + 0.5D, (LivingEntity) null, block.getProperties());
					world.addEntity(tntentity);
					world.playSound(null, tntentity.getPosX(), tntentity.getPosY(), tntentity.getPosZ(), SoundEvents.ENTITY_TNT_PRIMED, SoundCategory.BLOCKS, 1.0F, 1.0F);
					stack.shrink(1);
				} else {
					Direction direction = source.getBlockState().get(DispenserBlock.FACING);
					IPosition iposition = DispenserBlock.getDispensePosition(source);
					ItemStack itemstack = stack.split(1);
					doDispense(source.getWorld(), itemstack, 6, direction, iposition);
				}
				return stack;
			}
		});