Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I have a newly registered item, which is a water flask. I'm trying to play the drinking animation and the drinking sound while right clicking on it, but it doesn't work. Because of the sound playing try, my minecraft just crashes. And the animation just doesn't work.

Here's my whole Item class:

package com.venonat.venonatmod.objects.items;
import com.venonat.venonatmod.events.MyTimer;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.UseAction;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.SoundEvents;
import net.minecraft.world.World;

public class FlaskItem extends Item {
    MyTimer timer = MyTimer.getInstance();
    Minecraft mc;
    boolean alreadyExecuted;

    public FlaskItem(Properties props) {
        super(props);
    }


    @Override
    public UseAction getUseAction(ItemStack stack){
        getUseAction(stack);
        return UseAction.DRINK;
    }

    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        timer.setCountdown(timer.getCountdown() + 5);
        if (!alreadyExecuted) {
            mc.player.playSound(SoundEvents.ENTITY_GENERIC_DRINK, 0.5f, 1.0f);
            alreadyExecuted = true;
        }
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }
}

and here is my item registration:

package com.venonat.venonatmod.init;

import com.venonat.venonatmod.VenonatMod;
import com.venonat.venonatmod.objects.items.FlaskItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@ObjectHolder(VenonatMod.MOD_ID + "flask")
@Mod.EventBusSubscriber(modid = VenonatMod.MOD_ID, bus = Bus.MOD)

public class ItemInit {

    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new FlaskItem(new Item.Properties().maxStackSize(1).group(ItemGroup.MISC)).setRegistryName("flask"));
    }
}

 

1 hour ago, Mower said:

I have a newly registered item, which is a water flask. I'm trying to play the drinking animation and the drinking sound while right clicking on it, but it doesn't work. Because of the sound playing try, my minecraft just crashes. And the animation just doesn't work.

Here's my whole Item class:


package com.venonat.venonatmod.objects.items;
import com.venonat.venonatmod.events.MyTimer;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.UseAction;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.SoundEvents;
import net.minecraft.world.World;

public class FlaskItem extends Item {
    MyTimer timer = MyTimer.getInstance();
    Minecraft mc;
    boolean alreadyExecuted;

    public FlaskItem(Properties props) {
        super(props);
    }


    @Override
    public UseAction getUseAction(ItemStack stack){
        getUseAction(stack);
        return UseAction.DRINK;
    }

    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        timer.setCountdown(timer.getCountdown() + 5);
        if (!alreadyExecuted) {
            mc.player.playSound(SoundEvents.ENTITY_GENERIC_DRINK, 0.5f, 1.0f);
            alreadyExecuted = true;
        }
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }
}

and here is my item registration:


package com.venonat.venonatmod.init;

import com.venonat.venonatmod.VenonatMod;
import com.venonat.venonatmod.objects.items.FlaskItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@ObjectHolder(VenonatMod.MOD_ID + "flask")
@Mod.EventBusSubscriber(modid = VenonatMod.MOD_ID, bus = Bus.MOD)

public class ItemInit {

    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new FlaskItem(new Item.Properties().maxStackSize(1).group(ItemGroup.MISC)).setRegistryName("flask"));
    }
}

 

why use mc.player instead of the player already given? and you should probably store the cooldown in nbts

1 hour ago, Mower said:

Could you show on my code what to do then?

You can use capabilities or nbt tags to store data, and you will probably want to just use the playerIn in onItemRightClick() instead

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.