[1.15.2] Dimension registering problem

[QuantumSoul]

Hey,

I tried registering my custom dimension but it crashes, I checked different times but couldn't find why.

 

 DimensionMod: 

Spoiler

@ObjectHolder(BinaryMod.MOD_ID)
@Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class DimensionMod
{
    private final static String DIM_BINARY_ID = "binary_dimension";
    public static final ResourceLocation DIM_BINARY_RL = new ResourceLocation(BinaryMod.MOD_ID, DIM_BINARY_ID);


    // MODDIMENSION REGISTERING
    @ObjectHolder(DIM_BINARY_ID)
    public static final ModDimension DIM_BINARY_MOD = null;

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(DIM_BINARY_ID));
    }


    // DIMENSION REGISTERING
    @Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus=Mod.EventBusSubscriber.Bus.FORGE)
    private static class ForgeEvents
    {
        @SubscribeEvent
        public static void onRegisterDimensionsEvent(RegisterDimensionsEvent event)
        {
            if(DimensionType.byName(DIM_BINARY_RL) == null)
                DimensionManager.registerDimension(DIM_BINARY_RL, DIM_BINARY_MOD, null, true);
        }
    }
}

 

Crash report:

https://pastebin.com/MsqtmeqS

[kaydogz]

6 minutes ago, QuantumSoul said:

Hey,

I tried registering my custom dimension but it crashes, I checked different times but couldn't find why.

 

 DimensionMod: 

  Hide contents

@ObjectHolder(BinaryMod.MOD_ID)
@Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class DimensionMod
{
    private final static String DIM_BINARY_ID = "binary_dimension";
    public static final ResourceLocation DIM_BINARY_RL = new ResourceLocation(BinaryMod.MOD_ID, DIM_BINARY_ID);


    // MODDIMENSION REGISTERING
    @ObjectHolder(DIM_BINARY_ID)
    public static final ModDimension DIM_BINARY_MOD = null;

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(DIM_BINARY_ID));
    }


    // DIMENSION REGISTERING
    @Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus=Mod.EventBusSubscriber.Bus.FORGE)
    private static class ForgeEvents
    {
        @SubscribeEvent
        public static void onRegisterDimensionsEvent(RegisterDimensionsEvent event)
        {
            if(DimensionType.byName(DIM_BINARY_RL) == null)
                DimensionManager.registerDimension(DIM_BINARY_RL, DIM_BINARY_MOD, null, true);
        }
    }
}

 

Crash report:

https://pastebin.com/MsqtmeqS

Your setRegistryName does not include a namespace.

[QuantumSoul]

25 minutes ago, kaydogz said:

Your setRegistryName does not include a namespace.

I changed it to

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(BinaryMod.MOD_ID + ":" + DIM_BINARY_ID));
    }

And It still crashes with the same error.

[Draco18s]

Your object holder annotation is bad.

[QuantumSoul]

4 minutes ago, Draco18s said:

Your object holder annotation is bad.

How ? I tried adding a namespace but it didn't work so I removed it and

I found that it is the top one, the @ObjectHolder at the top which is crashing.

My work around is to do that

Spoiler

    public static final ModDimension DIM_BINARY_MOD = new ModDimension() {
        @Override
        public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
        {
            return BinaryDimension::new;
        }
    };

    // MODDIMENSION REGISTERING
    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(DIM_BINARY_MOD.setRegistryName(DIM_BINARY_RL));
    }

But I think it's not good

 

Edited May 11, 2020 by QuantumSoul

[kaydogz]

16 minutes ago, QuantumSoul said:

I changed it to

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(BinaryMod.MOD_ID + ":" + DIM_BINARY_ID));
    }

And It still crashes with the same error.

Use your resource location, not a concatenation of strings.

[QuantumSoul]

Just now, kaydogz said:

Use your resource location, not a concatenation of strings.

I tried that too

[imacatlolol]

Use a deferred registry, it's designed to get rid of these sorts of headaches.