I'm trying to remove a potion effect from all entities in a world using ClientWorld#getAllEntities, since this method is in ClientWorld I do it from ClienTickEvent with this code:

Spoiler

Minecraft.getInstance().world.getAllEntities().forEach(entity -> {
                        if(entity instanceof MobEntity)
                            if(((MobEntity) entity).isPotionActive(EffectInit.CRIMSON.get()))
                                ((MobEntity) entity).removePotionEffect(EffectInit.CRIMSON.get());
                    });

 

But it doesn't take the effect away, I suspect potion effects aren't synced to the client and that the second if statement is always false because of it. For more context the class in which this code is being run can be found here as a git repo.

Are there better ways to get all entities in a world, or am I doomed to use 8 for Entity entity : World#getEntitiesInAABBexcluding? (1 for every direction)

3 minutes ago, diesieben07 said:

What's your use case?

I have a custom effect I only want to be applied while a player has an ability active, when that ability isn't active I want to immediately remove the effect from all entities that have it, and every entity in the player's view should have it.

1 minute ago, diesieben07 said:

Your custom effect already receives an update every tick, you can remove it there.

Where?

Also, what happens if there are two players, both set their effect active, and then one sets it inactive?

 

What should happen? How does your code insure this happens?

28 minutes ago, diesieben07 said:

Effect#isReady is called every tick. If that returns true (it does not by default, so you need to override it!), Effect#performEffect will be called that tick as well.

This happens for all entities your effect is currently active on.

This helped, thanks you!

 

16 minutes ago, Draco18s said:

Also, what happens if there are two players, both set their effect active, and then one sets it inactive?

Just tested that, works fine without any modification of the code.