Mod data overrides vanilla

[Slit_bodmod]

I have been working on a mod for 1.15.2 Minecraft, I am new to Minecraft mod development. I thought I had a grip on how tags worked however whenever I try and append some items in my mod to a Minecraft tag it seems to somehow stop that tag from loading any items either from vanilla or my mod.

I haven't (yet) tried to access or manipulate any files in code or access tags at any point, in theory it should be a resources only problem. I haven't deliberately overwritten any Minecraft data files although I have overwritten textures for horse armour and dark oak leaves.

I have made sure that my files are in the right place and that the replace setting is set to false.

As an example I uploaded my extension to the walls file saved at src/main/resources/data/minecraft/tags/blocks/walls.json. The intended result was to let my thatch, blackstone and blackstone_bricks wall connect to other walls in the game however the effect has proved to stop any walls from connecting to any other walls while the game is running.

No recipes are working, leaves are decaying next to log blocks it's all gone a bit disastrous.

Any help would be much appreciated as like I said, I'm relatively amateur, thought I had a grip on things and now really don't know what to do.

 

walls.json

[Ugdhar]

Please post your debug.log, and if you can your project as a github repository.

 

Simply adding that walls.json would not cause all that stuff to happen, so there's definitely something else at play here.

[Draco18s]

25 minutes ago, Ugdhar said:

Simply adding that walls.json would not cause all that stuff to happen

Well, it can, if the json file is invalid. Any invalid json file inside /data will cause ALL data files to not be loaded. Its rather frustrating.

 

Slit_bodmod, its unlikely that the problem is your walls.json file, have you added any other data files (such as recipes or advancements?)

[Slit_bodmod]

8 minutes ago, Ugdhar said:

 

hi, yes, sorry, just had to make a github account (I should really have had one by now). Here (hopefully) is a link to my project

https://github.com/slit-bodmod/lotb-mod

btw, by debug.log do you mean my latest.log file from minecraft

[Ugdhar]

1 minute ago, Slit_bodmod said:

btw, by debug.log do you mean my latest.log file from minecraft

It should be debug.log but I'll take latest.log if that's all you have

[Slit_bodmod]

6 minutes ago, Ugdhar said:

It should be debug.log but I'll take latest.log if that's all you have

Oh right yeah, just looked inside my logs folder, not sure if this is what you were looking fo but i found files named latest.log and debug.log

latest.log debug.log

[Draco18s]

I was right you have a malformed json file.

Quote

com.google.gson.JsonParseException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 4 column 20 path $.pack.description

 

This looks wrong:

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/logs.json#L4

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/wooden_stairs.json#L4

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/wooden_buttons.json#L4

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/slabs.json#L4

ditto the same problem for the block tags

[Slit_bodmod]

Oh, right, what's wrong with it, is the # supposed to come before the open quotes?

[Draco18s]

Dude, compare the your other files. Like this one.

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/leaves.json#L4

[Slit_bodmod]

1 minute ago, Draco18s said:

Dude, compare the your other files. Like this one.

https://github.com/slit-bodmod/lotb-mod/blob/master/src/main/resources/data/minecraft/tags/items/leaves.json#L4

I fixed the problem with me putting minecraft instead of lotb, that was a silly mistake to miss however I genuinely can't see the problem with the logs file. Is it something really obvious staring me in the face, is it something to do with the hashtag because I am trying to link a block tag I've created.

 I don't want to come across like I'm taking the mic but I'm known to be quite dyslexic at the best of times. Sorry.

[Draco18s]

If you're trying to add YOUR blocks to the tag, you need to tell the tag about YOUR block which should have YOUR mod ID.

All of the ones I linked are wrong.

[Slit_bodmod]

44 minutes ago, Draco18s said:

If you're trying to add YOUR blocks to the tag, you need to tell the tag about YOUR block which should have YOUR mod ID.

All of the ones I linked are wrong.

I changed where I typed minecraft in the block tags instead of my mod id on the last 3 files you mentioned (i haven't changed it on github), when doing that I removed the first file you mentioned, the problamatic #lotb:shire_oak_logs file, entirely and it all worked fine.

I then re-added the logs file unchanged and nothing seemed to have broken, all the blocks reconnected, saplings still placed trees correctly, so on.

 

The only thing that isn't working is recipes and block loot_tables (presumably all loot tables but i only currently have the ones for block drops), for both vanilla and my mod, ie: no blocks will drop, nothing is craftable.

 

Thanks for pointing out my silly id mess up though, I was finding it really hard to find it and you also gave me some very useful pointers in how to find issues with the data.

[Draco18s]

You probably have a bad file somewhere still.

[Slit_bodmod]

Yeah, I think so, glad that it seems to be loading the block tags now though.

I wrote a little program to help auto generate a lot of files, it was primarily for block-states and models but it also does some other things and while it's massively helped with speed and enjoyability of developing this mod it does also mean that I'm going at a speed where it's slightly hard to debug, there's a chance there's a hiccup with that, either that or one of the extra few recipes I added manually, If I check the logs it should tell me where it is, right.

Also, again, thankyou very much for helping me with this.

Edited May 22, 2020 by Slit_bodmod

[Ugdhar]

7 hours ago, Slit_bodmod said:

I wrote a little program to help auto generate a lot of files, it was primarily for block-states and models but it also does some other things

Data generators are now built-in: https://wiki.mcjty.eu/modding/index.php?title=Tut14_Ep7 there are more generators in the net.minecraftforge.client.model.generators package

Edited May 22, 2020 by Ugdhar

[Slit_bodmod]

1 hour ago, Ugdhar said:

Data generators are now built-in: https://wiki.mcjty.eu/modding/index.php?title=Tut14_Ep7 there are more generators in the net.minecraftforge.client.model.generators package

Oh haha, thankyou, that's really useful, I should have checked really. It's like the old programming thing, someone's probably done it before and better.