What are some reasons why deserialize nbt might not work correctly?

[Turtledove]

I'm attempting to write and read members of my player capability class, and for things like my stamina, accuracy, fuel variables, when I exit the game and return, it 100% works and saves just fine. However, I also have a 3x3 grid of user bound indices that I've represented as a one dimensional array of integers, which I then created 9 integer data parameters of, registering and setting it like the others.

 

When I go to print these values within my serializenbt method, the correct values are printed, i.e. 2,4,1,0,...

 

However, when I print them after the readNBT call within the deserialize method after exiting the game and reloading, it just prints the default values for them, 0,0,0,0,... Note that this is immediately after calling readnbt in the same deserializeNBT method.

 

Both these methods are called on the logical server, and the client/server side for these variables are synced, so I don't believe it could be a server/client side issue. There's nothing weird with how I'm calling the two methods, since it works for all my other variables. The only time I set these variables to 0 is in the default/nondefault constructor as well.

 

Anyone know what it could be? Does it just not work well with arrays?

Edited May 27, 2020 by Turtledove

[Blazer Nitrox]

Could you post the relevant code? It sounds like there might be some confusion in the naming somewhere (i.e. you're saving it as "3_x_3_array" and loading it as "3x3_array"). Either that, or it's calling your constructor somewhere you don't expect it to. But without the code, those are just guesses.

[Turtledove]

13 minutes ago, Blazer Nitrox said:

Could you post the relevant code? It sounds like there might be some confusion in the naming somewhere (i.e. you're saving it as "3_x_3_array" and loading it as "3x3_array"). Either that, or it's calling your constructor somewhere you don't expect it to. But without the code, those are just guesses.

It's got nothing to do with how I'm writing/reading nbt data within the data provider class, I'm 100% certain of that, plus it implements ICapabilitySerializable and doesn't rely on strings as tags.

 

I guess I'm confused about what exactly happens when readnbt is called when used on a player capability. I.e, how does it determine which member variables to populate? It does so just fine for other member variables of my player capability class, but does not for my array variable.

[DavidM]

You have to post the code for us to see the problem. I don't think there is anything different with int arrays (at least the lat time I used them), and it is more likely to be caused by your code.

[Blazer Nitrox]

19 minutes ago, Turtledove said:

It's got nothing to do with how I'm writing/reading nbt data within the data provider class, I'm 100% certain of that, plus it implements ICapabilitySerializable and doesn't rely on strings as tags.

OH, I CapabilitySerializable! I'll be honest, I haven't messed with it, as I could never seem to find any resources for how to use it. I honestly just have an interface defining methods for reading to/writing from NBT, and then use those in my ICapabilityStorage implementation. I'm pretty sure what I'm doing violates diesieben07's coding guidelines, but it's how I first learned to do it back in... was it 1.10?

Anyway, I'm going to defer to DavidM's judgement here, as he's clearly more experienced than I.

[Turtledove]

4 minutes ago, DavidM said:

You have to post the code for us to see the problem. I don't think there is anything different with int arrays (at least the lat time I used them), and it is more likely to be caused by your code.

Alright my player capability class is pretty big, but here's all the relevant parts. The parts removed for clearer reading just affect stuff like bow accuracy, player combat, etc.

 

Anyhow, the 3x3 container (implemented here as a 1-d array) has initial values when the player first joins the world, and they can manipulate values within it from my custom player inventory. All of this works perfectly fine, I send a packet from client to server when the GUI is closed, plus for testing purposes I manually sync both client and server every 1200 ticks. But yeah the problem is that it does not save, when printArtes() is called, it prints what it was initially set to in the constructor:  https://pastebin.com/y8R0Up3L

[Turtledove]

I was hoping I could figure it out on my own after posting like I usually do, but no dice this time haha

Edited May 27, 2020 by Turtledove

[DaemonUmbra]

Please post the whole mod as a GitHub repo, makes it much easier for us to help you if we can run it and test for ourselves

[DavidM]

47 minutes ago, Blazer Nitrox said:

Anyway, I'm going to defer to DavidM's judgement here, as he's clearly more experienced than I.

I haven't been modding much after 1.15, so I guess I'm quite a noob now. 

 

@Turtledove I'm not sure what some of the data meant, but it seems that you are storing the data that is meant to be the same in two places: the int array and the data manager (corresponding to the 9 integer data parameter). You should keep them in one place instead (I would suggest the data manager instead of the array).

bindedArtes[0] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[1] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[2] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[3] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[4] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[5] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[6] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[7] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[8] = ArteHandler.ARTES.DEMON_FANG.ordinal();

//...

privateData.register(R0C0,0);
privateData.register(R1C0,0);
privateData.register(R2C0,0);

privateData.register(R0C1,0);
privateData.register(R1C1,0);
privateData.register(R2C1,0);

privateData.register(R0C2,0);
privateData.register(R1C2,0);
privateData.register(R2C2,0);

As you can see there are parts like this, in which the values in the two places are de-synced with each other. My best guess is that during the reading/writing, this happened.

 

You also seem to be using the capability as a non-direct handler for certain events, which I would not suggest. Capability is only meant to be a method of storing data, and routines that use the data should be in their corresponding places instead of the capability class. This will make debugging easier.

Edited May 27, 2020 by DavidM

[Turtledove]

4 minutes ago, DavidM said:

I haven't been modding much after 1.15, so I guess I'm quite a noob now. 

 

@Turtledove I'm not sure what some of the data meant, but it seems that you are storing the data that is meant to be the same in two places: the int array and the data manager (corresponding to the 9 integer data parameter). You should keep them in one place instead (I would suggest the data manager instead of the array).

bindedArtes[0] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[1] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[2] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[3] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[4] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[5] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[6] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[7] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[8] = ArteHandler.ARTES.DEMON_FANG.ordinal();

//...

privateData.register(R0C0,0);
privateData.register(R1C0,0);
privateData.register(R2C0,0);

privateData.register(R0C1,0);
privateData.register(R1C1,0);
privateData.register(R2C1,0);

privateData.register(R0C2,0);
privateData.register(R1C2,0);
privateData.register(R2C2,0);

As you can see there are parts like this, in which the values in the two places are de-synced with each other. My best guess is that during the reading/writing, this happened.

Ah you're right, if I print the data parameters every tick server-side, none of them are initialized until I send my packet from the client after editing the grid in the inventory. I'll get back to you on that and see what happens if I fix it.

 

Unfortunately having both is kind of necessary, it makes some of the referencing I need to do 100x times cleaner, for example it's used to determine which attack the player should do on a certain number of clicks:

 

 

 

[Turtledove]

On 5/26/2020 at 8:31 PM, DavidM said:

I haven't been modding much after 1.15, so I guess I'm quite a noob now. 

 

@Turtledove I'm not sure what some of the data meant, but it seems that you are storing the data that is meant to be the same in two places: the int array and the data manager (corresponding to the 9 integer data parameter). You should keep them in one place instead (I would suggest the data manager instead of the array).

bindedArtes[0] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[1] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[2] = ArteHandler.ARTES.QUICK_SLASH.ordinal();
bindedArtes[3] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[4] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[5] = ArteHandler.ARTES.SCATTERING_SLASH.ordinal();
bindedArtes[6] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[7] = ArteHandler.ARTES.DEMON_FANG.ordinal();
bindedArtes[8] = ArteHandler.ARTES.DEMON_FANG.ordinal();

//...

privateData.register(R0C0,0);
privateData.register(R1C0,0);
privateData.register(R2C0,0);

privateData.register(R0C1,0);
privateData.register(R1C1,0);
privateData.register(R2C1,0);

privateData.register(R0C2,0);
privateData.register(R1C2,0);
privateData.register(R2C2,0);

As you can see there are parts like this, in which the values in the two places are de-synced with each other. My best guess is that during the reading/writing, this happened.

 

You also seem to be using the capability as a non-direct handler for certain events, which I would not suggest. Capability is only meant to be a method of storing data, and routines that use the data should be in their corresponding places instead of the capability class. This will make debugging easier.

 

Yup, fixing that got it to work. I really need to manage capability data initialization and read/writes better. Is there any tips for managing multiple systems on a player capability? My capability class controls mana, accuracy, defense, passive skills, etc. If this were one of my Unreal or OpenGL projects I wouldn't have to centralize all this data onto a single class.

[DavidM]

3 hours ago, Turtledove said:

 

Yup, fixing that got it to work. I really need to manage capability data initialization and read/writes better. Is there any tips for managing multiple systems on a player capability? My capability class controls mana, accuracy, defense, passive skills, etc. If this were one of my Unreal or OpenGL projects I wouldn't have to centralize all this data onto a single class.

I personally define the read/write NBT myself in ICapabilitySerializable, as I find it more flexible (have more control over how stuff is stored, as well as being able to store types such as int array). This would force you to manage string keys though.

However it is really up to you. I would suggest adhering to the single responsibility principle and make sure that your capability class is meant for data storage only; this will make it easier to debug as well as more readable.