Jump to content

Localization with Server Only Mods


Caffeinated Pinkie

Recommended Posts

I've just found an issue with Forge localization that I'm not sure is intentional or not. Basically, I have mod that is only required on the server-side, but has some commands and messages that are sent to players. Using TranslationTextComponents, the messages are translated to the appropriate locale if the client has the mod installed. However, if the client does not have the mod, the messages are untranslated and just the translation key is sent. For example, "commands.ahe.explosions.stopped" is sent instead of "Explosions stopped." This issue is also present in the server console, but I figured that's fine if the client translates it properly.

 

Am I missing something or is there just no proper way to use localization to clients that don't have the proper mods?

Link to comment
Share on other sites

8 hours ago, diesieben07 said:

Correct. The server only knows English, hence the translation key is sent if you use TranslationTextComponent.

Alright. Is there a method to check if clients have the localization and send just a StringTextComponent instead?

 

Never mind, the documentation describes this pretty well. Thank you for the help.

Edited by Caffeinated Pinkie
Link to comment
Share on other sites

10 hours ago, diesieben07 said:

Correct. The server only knows English, hence the translation key is sent if you use TranslationTextComponent.

Alright, is there a way to check whether the client has a particular mod? TextComponentHelper works if the client is vanilla, but not if the client is modded and does not have the mod.

Link to comment
Share on other sites

On 6/16/2020 at 4:20 PM, diesieben07 said:

ChannelRegistrationChangeEvent will fire on your NetworkChannel to inform you when a client registers / unregisters (doesn't happen for forge channels) your channel. This allows you to detect if a player has registered your channel (your mod is present on the client) or not (your mod is not present).

I'm sorry if this is already answered somewhere, but the wall I've hit at this point is that the dedicated server does not seem to be able to translate the keys. When I send a TranslationTextComponent to the MinecraftServer with the translation key or directly translate it in place using LanguageMap and then send it in a StringTextComponent to the MinecraftServer or players, it still just displays the translation key. The dedicated client is able to translate the key, however, if sent a TranslationTextComponent.

Also, for the ChannelRegistrationChangeEvent, what is the proper way to register my mod so that it actually fires. Do I only have to register it on the client or the server too? I can't seem to find any documentation or guides on this topic.

 

As a rule of thumb, should modders generally try to translate for modded clients without their particular mod? Or is it common practice to just use TextComponentHelper and leave it at that?

Link to comment
Share on other sites

13 minutes ago, Caffeinated Pinkie said:

send a TranslationTextComponent to the MinecraftServer

What.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 minute ago, Draco18s said:

What.

For example, PlayerList#sendMessage(ITextComponent). If you use a TranslationTextComponent, so that the message is lazily translated by clients, the message is also sent back to the server with this line:

this.server.sendMessage(component);

The server doesn't translate the message before displaying it in the server console in a dedicated server. In general, the dedicated server doesn't seem to be able to eagerly translate mod language keys even in English.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.