Jump to content

Ore Generation Isn't Working


Recommended Posts

I have been following TurtyWurty's tutorial on how to add Ore Generation to a mod, and I have followed it fully as much as I am aware. I have created a new world, and I cannot find it anywhere. It does load properly as an item, so that isn't the problem. Here is my code



package com.booktail.newdawn.util;

import com.booktail.newdawn.NewDawn;
import com.booktail.newdawn.blocks.BlockItemBase;
import com.booktail.newdawn.blocks.PrismallonBlock;
import com.booktail.newdawn.blocks.PrismallonOreBlock;
import com.booktail.newdawn.items.ItemBase;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

public class RegistryHandler {

    public static final DeferredRegister<Item> ITEMS = new DeferredRegister<>(ForgeRegistries.ITEMS, NewDawn.MOD_ID);
    public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<Block>(ForgeRegistries.BLOCKS, NewDawn.MOD_ID);

    public static void init() {

    //Item Declaration for "Hello World"
    public static final RegistryObject<Item> DINGUS = ITEMS.register("dingus", ItemBase::new);

    public static final RegistryObject<Item> PRISMALLON_INGOT = ITEMS.register("prismallon_ingot", ItemBase::new);

    //Blocks (and Block Items)
    public static final RegistryObject<Block> PRISMALLON_BLOCK = BLOCKS.register("prismallon_block", PrismallonBlock::new);
    public static final RegistryObject<Item> PRISMALLON_BLOCK_ITEM = ITEMS.register("prismallon_block", ()-> new BlockItemBase(PRISMALLON_BLOCK.get()));

    public static final RegistryObject<Block> PRISMALLON_ORE_BLOCK = BLOCKS.register("prismallon_ore_block", PrismallonOreBlock::new);
    public static final RegistryObject<Item> PRISMALLON_ORE_BLOCK_ITEM = ITEMS.register("prismallon_ore_block", ()-> new BlockItemBase(PRISMALLON_ORE_BLOCK.get()));




package com.booktail.newdawn.world.gen;

import com.booktail.newdawn.util.RegistryHandler;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.gen.GenerationStage;
import net.minecraft.world.gen.feature.Feature;
import net.minecraft.world.gen.feature.OreFeatureConfig;
import net.minecraft.world.gen.placement.ConfiguredPlacement;
import net.minecraft.world.gen.placement.CountRangeConfig;
import net.minecraft.world.gen.placement.Placement;
import net.minecraftforge.registries.ForgeRegistries;

public class NewDawnOreGen {

    public static void generateOre() {
        for(Biome biome : ForgeRegistries.BIOMES){
            ConfiguredPlacement customConfig = Placement.COUNT_RANGE.configure(new CountRangeConfig(20,5,5,25));
            biome.addFeature(GenerationStage.Decoration.UNDERGROUND_ORES, Feature.ORE
                    .withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, RegistryHandler.PRISMALLON_ORE_BLOCK.get().getDefaultState(), 10))



and NewDawn.java

package com.booktail.newdawn;

import com.booktail.newdawn.util.RegistryHandler;
import com.booktail.newdawn.world.gen.NewDawnOreGen;
import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.InterModComms;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.*;
import net.minecraftforge.fml.event.server.FMLServerStartingEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.stream.Collectors;

public class NewDawn {
    private static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "newdawn";

    public NewDawn() {
        //FML Listeners setup completed



    public static void loadCompleteEvent(FMLLoadCompleteEvent event){

    private void setup(final FMLCommonSetupEvent event) {
        // some preinit confirmation code
        LOGGER.info("Preinit is successful. Check Dirt registry below.");
        LOGGER.info("DIRT BLOCK >> {}", Blocks.DIRT.getRegistryName());

    private void doClientStuff(final FMLClientSetupEvent event) {
        // client test
        LOGGER.info("Got game settings {}", event.getMinecraftSupplier().get().gameSettings);

    private void enqueueIMC(final InterModEnqueueEvent event) {
        // hello world
        InterModComms.sendTo("newdawn", "helloworld", () -> {
            LOGGER.info("Hello world from the MDK");
            return "Hello world";

    private void processIMC(final InterModProcessEvent event) {
        // some example code to receive and process InterModComms from other mods
        LOGGER.info("Got IMC {}", event.getIMCStream().
                map(m -> m.getMessageSupplier().get()).

    // You can use SubscribeEvent and let the Event Bus discover methods to call
    public void onServerStarting(FMLServerStartingEvent event) {
        // do something when the server starts
        LOGGER.info("HELLO from server starting");

    // You can use EventBusSubscriber to automatically subscribe events on the contained class (this is subscribing to the MOD
    // Event bus for receiving Registry Events)
    @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent) {
            // register a new block here
            LOGGER.info("HELLO from Register Block");

    public static final ItemGroup TAB = new ItemGroup("newdawnTab") {

        public ItemStack createIcon() {
            return new ItemStack(RegistryHandler.PRISMALLON_INGOT.get());


I would greatly appreciate any help. I don't know why ore generation isn't happening in new worlds

Link to comment
Share on other sites

Is the loadComplete method running? I would double check via a log msg or breakpoint, just to be sure.


Also, I've always seen oregen go in FMLCommonSetupEvent, not FMLLoadCompleteEvent. Probably doesn't matter, I would guess it's a nuance of the tutorial you're following.

Link to comment
Share on other sites

6 hours ago, Maxi07 said:

I think Iyour main class NewDawn has to annotated with @EventBusSubscriber(modid = [your_modid], bus = Bus.MOD), but leave "@Mod"

Then the methods with @SubribeEvent (like your ore gen) will be executed


I used 

@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)

And that made it work, thank you!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Maybe your file codes are missing. Therefore it is crashing.
    • I've been trying to make a mod pack for the last day or so now and I haven't been able to launch it once even with all mods disabled. It keeps showing up with Exit Code 1. I gave the modpack to a friend to try and it didn't launch on their pc either due to the same exit code, so I'm not entirely certain what the problem is or how to check it in the logs. So far I've attempted: - Changing from forge version 43.3.0 to 43.3.5 - Downloading Java - Disabling mods (both entirely and individually) I have an NVIDIA GeForce GTX 1070 driver, and I haven't tried to uninstall or reinstall it yet because I'm not certain how to and would have to mess anything up further. I have the latest .txt file of the crash report here: [16:24:34] [main/WARN]: Failed to add PDH Counter: \Paging File(_Total)\% Usage, Error code: 0xC0000BB8 [16:24:34] [main/WARN]: Failed to add counter for PDH counter: \Paging File(_Total)\% Usage [16:24:34] [main/WARN]: Disabling further attempts to query Paging File. [16:24:36] [main/WARN]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile [16:24:39] [Datafixer Bootstrap/INFO]: 198 Datafixer optimizations took 149 milliseconds [16:24:40] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD] [16:24:40] [Render thread/INFO]: Setting user: CatDoodlee [16:24:41] [Render thread/INFO]: Backend library: LWJGL version 3.3.2+13 [16:24:42] [Render thread/INFO]: Reloading ResourceManager: vanilla [16:24:42] [Worker-Main-11/INFO]: Found unifont_all_no_pua-15.1.04.hex, loading [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [16:24:44] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Speakers (Atrix Wired Elite Headset) [16:24:44] [Render thread/INFO]: Sound engine started [16:24:44] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas [16:24:44] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [16:24:45] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [16:24:45] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas [16:24:45] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [16:24:45] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [16:24:45] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas [16:25:41] [Render thread/INFO]: Stopping! any form of help is greatly appreciated ❤️
    • Tanks for answer, I added SleepTight and I removed Modernfix, but it still crashing: new log new crash log
    • Hi, I'm trying to hide specific vanilla effects such as levitation or slow falling from the inventory GUI, but I haven't been able to figure out how to do this. I need this because they are triggered by another effect and I don't need them all showing up. Unfortunately, I don't know of any mods that include this feature, and I couldn't find any documentation on the process. I've already looked into the IClientMobEffectExtensions interface, but I'm uncertain about how to implement it in my own effect, let alone in any existing vanilla effect. Please help I am using Forge 47.2.0. for Minecraft 1.20.1
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.