[1.16.1]Render enchanted glint to item

[Lightlygamer1]

I want my item to look like its enchanted but it doesn't have enchants.

[poopoodice]

return true in hasEffect()

[vemerion]

Override the hasEffect method in your item class to always return true, to get the 'enchantment glint' effect.

 

Edit: Uh oh, I was too late it seems.

Edited July 16, 2020 by vemerion

[Lightlygamer1]

package com.lg1.fantasyimagination.items;


import com.lg1.fantasyimagination.FantasyImagination;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ItemEnchantedGlint extends Item
{

    public ItemEnchantedGlint() {
        super(new Item.Properties().group(FantasyImagination.FANTIMAGTAB));
    }

    @Override
    public boolean hasEffect(ItemStack stack) {
        return true;
    }
}

like this

[DavidM]

Yes, except don't create a special base class for it. It's just an override; do it in the actual item's class.

[Lightlygamer1]

 

1 hour ago, DavidM said:

Yes, except don't create a special base class for it. It's just an override; do it in the actual item's class.

ok

[Lightlygamer1]

2 hours ago, DavidM said:

Yes, except don't create a special base class for it. It's just an override; do it in the actual item's class.

what will happen?

[DavidM]

16 minutes ago, Lightlygamer1 said:

what will happen?

Creating excessive base classes is a bad practice against the structure of OOP. Since each class can only inherit one base class, creating base classes just to write less code will prevent deriving classes to extend other classes that are actually useful. For example, with your current setup, if you want to make a sword that glints, you will have to choose between extending SwordItem and ItemEnchantedGlint. This will result in having to mimic the behavior of the unextended class, which would be redundant code (and bad design).

 

For more information, look up "Composition over Inheritance".

[Lightlygamer1]

4 hours ago, DavidM said:

This will result in having to mimic the behavior of the unextended class

so my other items will have enchanted glint

[poopoodice]

https://docs.oracle.com/javase/tutorial/java/javaOO/anonymousclasses.html