[1.16.1] Mob can't climb on my block

[mgen256]

I don't know where is the problem in my code.

I couldn't find any difference with other vanilla blocks.

 

Here is the code.
https://github.com/mgen256/AdditionalLights/blob/1.16.1/src/main/java/com/mgen256/al/blocks/StandingTorch_S.java

 

I confirmed that it works by returning VoxelShapes.fullCube() in getShape().
Please tell me.

 

[DaemonUmbra]

Can you provide your mod source in a GitHub repo?

[mgen256]

I'm sorry, I don't know what you're saying.
My source code should be available from the URL.
Need to do something?

[DaemonUmbra]

I'm asking if you can provide the whole thing in a repo so I can just clone it and have it in a workable state that I can poke at

[poopoodice]

  On 7/27/2020 at 5:20 AM, mgen256 said:

Here is the code.
https://github.com/mgen256/AdditionalLights/blob/1.16.1/src/main/java/com/mgen256/al/blocks/StandingTorch_S.java

Expand  

 

[DaemonUmbra]

Oh I'll just run the mod with this one freaking class, will I @poopoodice?

How many times to I need to repeat a simple request?

[mgen256]

I'm sorry for the late reply. I need help.

 

This is the complete source code page.
https://github.com/mgen256/AdditionalLights/tree/1.16.1

 

Direct download
https://github.com/mgen256/AdditionalLights/archive/1.16.1.zip

 

I'm not very familiar with github. Please let me know if there are any missing items.

[poopoodice]

It isn't so hard for me to just click a button, don't know why are you so pissed

Edited July 28, 2020 by poopoodice

[DaemonUmbra]

Oh FFS... because I couldn't tell the difference between Gist and GitHub proper with the new layout, I thought it was Gist

Sorry

[DaemonUmbra]

Ok now I'm seeing anti-patterns

 

Get rid of ModBlock and ModItem, you shouldn't need them.

Never use @OnlyIn

There's no reason to list your items in a list initializer and then iterate the list

You're letting your blocks and items drive their own registration rather than just registering them

[mgen256]

Thank you !! Will be very studying.

[mgen256]

Do you understand the cause?

[DaemonUmbra]

I believe the jumping is based on the collisionShape, not the regular shape

[mgen256]

They will not climb if the collision shape is smaller than the Full Cube.
I tried this.

private static final VoxelShape COLLISION_SHAPE = Block.makeCuboidShape(0, 0, 0, 14, 14, 14);

@Override
public VoxelShape getCollisionShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) {
	return COLLISION_SHAPE;
}

 

A low value like (0,0,0,6,6,6) seems fine. But because it's lower than the model's height, the mob's legs above it are buried.

Looking at other mods, there were some that could climb and some that could not, and the cause could not be identified.
I tried putting the same value but it didn't work for my mod.

Can you think of anything that might have caused it?

[mgen256]

Does anyone know?

[mgen256]

I have resolved.
I just had to insert the following code in my block.

@Override
public boolean allowsMovement(BlockState state, IBlockReader worldIn, BlockPos pos, PathType type) {
	return false;
}