Help with ItemStack values across classes [1.16.1]

[Giga_5]

Hello! I'm relatively new to modding and Java in general, but I have the basics down and understand how items/blocks/entities/etc. work. Here I am trying to make an item that takes the item in the player's offhand itemstack and launches it as an entity (that extends from SnowballEntity), and then lands as an item on the ground. It all works except that I cannot find I way for the item entity spawned on the ground at the end to detect what item was initially launched from the player's inventory.

 

Here's my "launcher" item class;

public class xplauncher extends Item {



    public xplauncher(Properties p) {
        super(p);
    }
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        ItemStack itmsk = playerIn.getHeldItem(handIn);
        ItemStack stack = playerIn.getHeldItemOffhand();
        double lox = playerIn.getPosX();
        double loy = playerIn.getPosY();
        double loz = playerIn.getPosZ();
        xpball ball = new xpball(worldIn, lox, loy, loz);
        ball.func_234612_a_(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 4.0F, 1.5F, 1.0F);
        if(!stack.isEmpty()) {
            if(!worldIn.isRemote) {
                ball.setItem(stack);
                worldIn.addEntity(ball);
                stack.shrink(1);
            }
        }
        else
        {
            System.out.println("Nothing to shoot");
        }
        return ActionResult.func_233538_a_(itmsk, worldIn.isRemote());
    }
}

 

And here's my "projectile" class;

public class xpball extends SnowballEntity {



    ItemStack it = new ItemStack();

    public xpball(World world, double x, double y, double z) {
        super(world, x, y, z);
    }

    protected void onImpact(RayTraceResult rt) {
        super.onImpact(rt);
        if (!this.world.isRemote) {
                this.world.addEntity(new ItemEntity(this.world, this.getPosX(), this.getPosY(), this.getPosZ(), it));
            }

            this.remove();
        }

    }

 

My goal is for the "it" ItemStack in the projectile class to be somehow filled with the value of the "stack" ItemStack from the launcher class. Can anyone help me out? Constructive criticism is happily taken.

[Aes123]

Im relatively new to modding too but i think you can pass the itemstack from the xpball constructor

[Beethoven92]

Doesn't this#getItem() work, in place of 'it' when you need to pass the ItemStack you want? At this line:

this.world.addEntity(new ItemEntity(this.world, this.getPosX(), this.getPosY(), this.getPosZ(), it));
            

[Draco18s]

7 hours ago, Giga_5 said:

ItemStack it = new ItemStack();

This is just some random ItemStack you created that contains nothing (I am not even sure that's a valid constructor...)

 

You need to actually get the itemstack in the player's hand, which you would have to do when you create your thrown entity (and appears you are already doing):

7 hours ago, Giga_5 said:

ball.setItem(stack);

 

  

4 hours ago, Beethoven92 said:

Doesn't this#getItem() work, in place of 'it' when you need to pass the ItemStack you want? At this line:

this.world.addEntity(new ItemEntity(this.world, this.getPosX(), this.getPosY(), this.getPosZ(), it));
            

He's not creating item entities, he's creating snowball like thrown entities.

Edited July 31, 2020 by Draco18s

[Beethoven92]

2 hours ago, Draco18s said:

 

6 hours ago, Beethoven92 said:

Doesn't this#getItem() work, in place of 'it' when you need to pass the ItemStack you want? At this line:

this.world.addEntity(new ItemEntity(this.world, this.getPosX(), this.getPosY(), this.getPosZ(), it));
            

  He's not creating item entities, he's creating snowball like thrown entities.

 

Yeah. the thrown entity is represented by is xpball class, but he also wants to generate an item entity in the world, where his projectile hits something. Doesn't the line of code above do that? He just have to retrieve the ItemStack he needs and generate the item entity from it, unless i am missing something..

[Giga_5]

Thanks! that solves my problem