Jump to content

Recommended Posts

Posted

Hello!
I created a custom enchantment that is supposed to work like knockback, but it sends the victim in a random direction at a random velocity depending on the enchantment level. It all works perfectly in a single player environment, but upon hitting a mob with a "Glitch" sword with separate physical client and server, the server crashes with a noSuchMethodError exception. I'm  fairly new to modding so I don't fully understand how sides work. Any help would be appreciated.

 

here is the event that executes logic upon a mob being hit with a glitch weapon:

public class glitchevent {

    @SubscribeEvent
    public void onglitch(AttackEntityEvent e) {
        Entity target = e.getTarget();
        PlayerEntity attacker = e.getPlayer();

        int level = EnchantmentHelper.getEnchantmentLevel(ObjectHolderStorage.GLITCH, attacker.getHeldItemMainhand());

        Random r = new Random();

        int ins = r.nextInt(level + 2);
        double launchmultiplier = ins;
        double invertedlaunchmultiplier = ins - ins * ins;
        int test = r.nextInt(4);

        World world = e.getPlayer().world;

        if (!world.isRemote) {

            switch (test) {
                case 0:
                    target.setVelocity(launchmultiplier, 0.1D, launchmultiplier);
                    break;
                case 1:
                    target.setVelocity(invertedlaunchmultiplier, 0.1D, launchmultiplier);
                    break;
                case 2:
                    target.setVelocity(invertedlaunchmultiplier, 0.1D, invertedlaunchmultiplier);
                    break;
                case 3:
                    target.setVelocity(launchmultiplier, 0.1D, invertedlaunchmultiplier);
                    break;
            }
        }
    }
}

and here are the exceptions thrown on the server:

[12Aug2020 00:21:21.669] [Server thread/ERROR] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: Exception caught during firing event: net.minecraft.entity.Entity.func_70016_h(DDD)V
	Index: 1
	Listeners:
		0: NORMAL
		1: ASM: mod.extraenchants.events.glitchevent@2c63f610 onglitch(Lnet/minecraftforge/event/entity/player/AttackEntityEvent;)V
java.lang.NoSuchMethodError: net.minecraft.entity.Entity.func_70016_h(DDD)V
	at mod.extraenchants.events.glitchevent.onglitch(glitchevent.java:36)
	at net.minecraftforge.eventbus.ASMEventHandler_2_glitchevent_onglitch_AttackEntityEvent.invoke(.dynamic)
	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85)
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297)
	at net.minecraftforge.common.ForgeHooks.onPlayerAttackTarget(ForgeHooks.java:719)
	at net.minecraft.entity.player.PlayerEntity.func_71059_n(PlayerEntity.java:1035)
	at net.minecraft.entity.player.ServerPlayerEntity.func_71059_n(ServerPlayerEntity.java:1280)
	at net.minecraft.network.play.ServerPlayNetHandler.func_147340_a(ServerPlayNetHandler.java:1127)
	at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:74)
	at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:13)
	at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21)
	at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18)
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144)
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23)
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:735)
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:157)
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118)
	at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:718)
	at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:712)
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103)
	at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:697)
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:647)
	at net.minecraft.server.MinecraftServer.lambda$func_240784_a_$0(MinecraftServer.java:230)
	at java.base/java.lang.Thread.run(Thread.java:834)

[12Aug2020 00:21:21.825] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception
java.lang.NoSuchMethodError: net.minecraft.entity.Entity.func_70016_h(DDD)V
	at mod.extraenchants.events.glitchevent.onglitch(glitchevent.java:36) ~[?:1.2]
	at net.minecraftforge.eventbus.ASMEventHandler_2_glitchevent_onglitch_AttackEntityEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) ~[eventbus-3.0.3-service.jar:?]
	at net.minecraftforge.common.ForgeHooks.onPlayerAttackTarget(ForgeHooks.java:719) ~[?:?]
	at net.minecraft.entity.player.PlayerEntity.func_71059_n(PlayerEntity.java:1035) ~[?:?]
	at net.minecraft.entity.player.ServerPlayerEntity.func_71059_n(ServerPlayerEntity.java:1280) ~[?:?]
	at net.minecraft.network.play.ServerPlayNetHandler.func_147340_a(ServerPlayNetHandler.java:1127) ~[?:?]
	at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:74) ~[?:?]
	at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:13) ~[?:?]
	at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?]
	at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?]
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:735) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:157) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:718) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:712) ~[?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:697) ~[?:?]
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:647) ~[?:?]
	at net.minecraft.server.MinecraftServer.lambda$func_240784_a_$0(MinecraftServer.java:230) ~[?:?]
	at java.lang.Thread.run(Thread.java:834) [?:?]

 

Posted (edited)

My guess would be the 

if (!world.isRemote) {

Try removing the if statement, (obviously keeping the switch statement), and see how that goes. I haven't tested it yet myself.

 

I believe world.isRemote checks if the world is on a separate physical server, so by inverting it, you're making it so it only works on a client. :)

Edited by BlockyPenguin

Today (22/10/20) I reached 100 posts!

I'm probably more excited than I should be for something so realistically minor...

Posted

Entity#setVelocity is only present on the client, use Entity#setMotion instead. What BlockyPenguin suggested will not work.

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted
  On 8/12/2020 at 5:28 PM, BlockyPenguin said:

so by inverting it, you're making it so it only works on a client.

Expand  

That's a valid assumption, but it doesn't work like that, you cannot access client code from common code without packets.

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted
  On 8/12/2020 at 5:31 PM, Novârch said:

What BlockyPenguin suggested will not work.

Expand  

 

  On 8/12/2020 at 6:14 PM, Novârch said:

That's a valid assumption, but it doesn't work like that, you cannot access client code from common code without packets.

Expand  

 

Ah ok, thanks :)

Today (22/10/20) I reached 100 posts!

I'm probably more excited than I should be for something so realistically minor...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.