Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Ok so this might be simple to explain. This works as intended puts item into that slot
 

if (SlotCircuit.getValidItems().contains(handStack.getItem())) {
                    if (slotHandler.getStackInSlot(0).isEmpty()) {
                        slotHandler.insertItem(0, handStack, false);
                    }
                }

 

Below code doesnt put item in slot but deletes item in hand..... why does it not put item into the slot when i put a line of code after it?
 

if (SlotCircuit.getValidItems().contains(handStack.getItem())) {
                    if (slotHandler.getStackInSlot(0).isEmpty()) {
                        slotHandler.insertItem(0, handStack, false);
                        handStack.shrink(1);
                    }
                }

 

Edited by Mightydanp
add version

We don't know what are and where these came from:

Quote

SlotCircuit

handStack

slotHandler

but apparently, 

handStack.shrink(1);

makes whatever this itemstack came from count - 1

  • Author

Hand stack is just PlayerEntity.getMainHandStack

 

Slot handler leads to ItemStackHandler

 

If you need more information i will post to full class 

  • Author

So what i get from this is insert item. Set that into the player which will also break the chain then shrink players hand  ??

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author
ItemStack heldItem = player.getHeldItem(hand);
		if(!heldItem.isEmpty()) {
			MillstoneTileEntity te = (MillstoneTileEntity)world.getTileEntity(pos);
			IItemHandler inventory = te.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, Direction.UP).orElse(null);
			if(inventory == null) return false;
			ItemStack stack = heldItem.copy();
			stack.setCount(1);
			stack = inventory.insertItem(0, stack, true);
			if(stack.isEmpty()) {
				stack = inventory.insertItem(0, heldItem.split(1), false);

Can your code. I dont understand where you remove 1 from handItem

15 minutes ago, Mightydanp said:

heldItem.split(1)

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

To the surprise of no one: Yes. It splits the stack such that the returned stack has the indicated size (or the original's size, whichever is lower) and the original stack is reduced by that amount (to a minimum of zero).

 

Oh and this:

27 minutes ago, Mightydanp said:

stack = inventory.insertItem(0, stack, true);

Is what checks to see if the item can be inserted, regardless of what stack is currently in the TE's inventory.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  You want to do it for real, or just simulate it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

Oh so wheb you do 

stack = inventory.insertItem(0, stack, true);

it takes the item and set it in slot 0 but it doesnt actually move the item?

thats why you can do

 


				stack = inventory.insertItem(0, heldItem.split(1), false)
  • Author

 

1 minute ago, diesieben07 said:

No it does not "set it in slot 0".

I am confused then so it makes it look like it set that item in slot 0 but doesnt ?

  • Author
stack = inventory.insertItem(0, stack, true);
			if(stack.isEmpty()) {
				stack = inventory.insertItem(0, heldItem.split(1), false);
Can your code. I dont understand where you remove 1 from handItem

Ok so line 1 will visually put an item in slot 0. Which will make stack empty

This will let it pass the of statement and then you insert the item and split it 

6 minutes ago, Mightydanp said:

Ok so line 1 will visually put an item in slot 0.

No. The first line calculates what would be left over if the stack were to be inserted.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

Oh ok so you do that to make sure that that item can go into the slot so that it wont delete the item in your hand if it cant

Yes.

But keep in mind that that is not the only way these methods can be used. That's what it does here because only 1 of whatever item is trying to be inserted at a time. If we wanted to do more than 1, it gets a little trickier, but the general process is still the same:

  1. Attempt to insert
  2. Check if the remainder has a smaller stack size than what we tried to insert
  3. Actually split off and insert only the amount that will fit

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

One thing that confuses me that you did handStack.split(1) inside the method but is that going to split the handstack to 0 but that will make it set nothing in slot 1 or will it set that item on the slot then split handStack to 0

Vanilla treats stacks of size zero as identical to air. You don't have to do anything about it.

That's why .isEmpty() is a thing.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

I understand that but You put handstack.split(1) in the insertItem. How would that set the item in slot 1 and then split it i am confused i thought it would take the handstack and split it then you would be left with air making it not work as intended

50 minutes ago, Mightydanp said:

I understand that but You put handstack.split(1) in the insertItem. How would that set the item in slot 1 and then split it

There are two functions here.

One is inserting a stack into a slot.

The other is splitting the item stack in the player's hand and returning a new stack.

The former is taking as a parameter the result of the latter.

50 minutes ago, Mightydanp said:

i am confused i thought it would take the handstack and split it then you would be left with air making it not work as intended

handstack is indeed left empty if it was a stack of 1 item.

Empty stacks that are not air, and stacks of air, are functionally identical as far as all of vanilla's code is concerned. The whole point of split() is that you have TWO stacks after calling it, the original (now empty) and the new stack (with one item) that gets inserted into the tile entity. That's how the player's held item is cleared.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.