Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

issue with detecting blocks

dontrell94

By dontrell94
in Modder Support

 Share

Recommended Posts

dontrell94 Stone Miner

dontrell94

Posted
Posted

Im trying to replace a specific set of blocks with air... I'm trying to replace 35 blocks at once by redstone activation.

Any help is apreciated.

 

Here's the error:

 

  Reveal hidden contents

 

 

And the class file:

 

  Reveal hidden contents

 

I took over Hunting Traps Mod and work on helping the forge community as much as I can. View my work here: http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/wip-mods/1443756-1-7-2-1-6-4-1-5-2-1-4-7-hunting-traps-mod-v-0-4-0

Draco18s Reality Controller

Draco18s

Posted
Posted

You are trying to replace the blocks in your block's constructor.

 

There are two problems with this:

 

1) The constructor happens before the game has reached the main menu

2) You are trying to access methods of a null object.  That is, your world variable is declared but not defined.  For obvious reasons.  Not to mention that i, j, and k are also null!

 

You should be doing this code either onEntityCollidedWithBlock or onBlockActivated or similar.  Where the world is passed to your block class.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Yagoki Diamond Finder

Yagoki

Posted
Posted

You may want to take a look at your variables i j and k, This may be causing your null pointer. Also, be careful using static variables here because you could get problems concerning threading. Try putting this into the block or a TileEntity instead as a local method and pass it the required parameters through the method.

 

Personally i'd also suggest (just as a bit of cleanup) that you reuse your parX variables so you only have one, and reassign it new values, this will just free up a small amount of memory space and make things look nicer.

 

public class MyTE extends TileEntity
{
    @Override
    public void onUpdate()
    {
        if(this.worldObj.isBlockIndirectlyGettingPowered(xCoord, yCoord, zCoord))
        {
            int id = this.worldObj.getBlockId(xCoord+1, yCoord, zCoord);
            if(id==1)
                world.setBlockId(xCoord+1, yCoord, zCoord, 0);
            id = this.worldObj.getBlockId(xCoord+1, yCoord+1, zCoord);
            if(id==1)
                world.setBlockId(xCoord+1, yCoord+1, zCoord, 0);
            //and so on
        }
    }
}

 

 

  On 6/16/2013 at 2:27 PM, Draco18s said:

You are trying to replace the blocks in your block's constructor.

 

There are two problems with this:

 

1) The constructor happens before the game has reached the main menu

2) You are trying to access methods of a null object.  That is, your world variable is declared but not defined.  For obvious reasons.  Not to mention that i, j, and k are also null!

 

You should be doing this code either onEntityCollidedWithBlock or onBlockActivated or similar.  Where the world is passed to your block class.

 

He is calling this from his block, in the on neighbor block changed, so it is called only when the block is in the world

  Quote

2013-06-16 02:08:03  [sTDERR]    at huntingTraps.Resources.PitfallHandler.iftrap(PitfallHandler.java:13)

2013-06-16 02:08:03  [sTDERR]    at huntingTraps.Traps.Pitfall.onNeighborBlockChange(Pitfall.java:29)

however yes he should be doing it in his block/tileEntity

github
dontrell94 Stone Miner

dontrell94

Posted
  • Author
Posted

I am indeed throwing this method only when needed by another block. this is my attempt at only changing certain blocks.

 

I'm trying to write the coordinates to a variable then have the file each variable checked against certain id numbers. if it is on a predetermined list then it gets turned to air.

I took over Hunting Traps Mod and work on helping the forge community as much as I can. View my work here: http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/wip-mods/1443756-1-7-2-1-6-4-1-5-2-1-4-7-hunting-traps-mod-v-0-4-0

Draco18s Reality Controller

Draco18s

Posted
Posted

Just so you know:

 

par12 == (1|2|3|4|12|13)

 

That won't do what you think it does.

 

1|2|3|4|12|13 == 16.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 6/16/2013 at 4:58 PM, dontrell94 said:

how do i do or?

 

par12 == 1 || par12 ==2 || par12 == 3...

 

This is a fundamental basic understanding of programming.  The fact that you had to ask this question means you're not actually ready to mod Minecraft.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

ObsequiousNewt Dragon Slayer

ObsequiousNewt

Posted
Posted
  On 6/16/2013 at 4:58 PM, Draco18s said:

  Quote

how do i do or?

 

par12 == 1 || par12 ==2 || par12 == 3...

 

This is a fundamental basic understanding of programming.  The fact that you had to ask this question means you're not actually ready to mod Minecraft.

Another of the many shortcomings of Java. With Python, you can do 

if par12 in (1,2,3,4,12,13):
    #stuff

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

dontrell94 Stone Miner

dontrell94

Posted
  • Author
Posted
  On 6/16/2013 at 4:58 PM, Draco18s said:

  Quote

how do i do or?

 

par12 == 1 || par12 ==2 || par12 == 3...

 

This is a fundamental basic understanding of programming.  The fact that you had to ask this question means you're not actually ready to mod Minecraft.

 

No I'm still learning as I go, I forgot about that.......I feel stupid

I took over Hunting Traps Mod and work on helping the forge community as much as I can. View my work here: http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/wip-mods/1443756-1-7-2-1-6-4-1-5-2-1-4-7-hunting-traps-mod-v-0-4-0

Mew Dragon Slayer

Mew

Posted
Posted

I feel like a know all in this situation...

 

try something like this:

package huntingTraps.Resources;

import net.minecraft.world.World;

public class PitfallHandler
{  
    public static World world; // the world you are using
    public static int i, j, k; // X, Y, and Z axis variables

    public PitfallHandler(World world, int x, int y, int x)
    {
        this.world = world; // the world
        this.i = x; // X axis
        this.j = y; // Y axis
        this.k = z; // Z axis
    }
    
    public static void generatePitfall()
    {
        // this nested for loop will make a 'block' of air to the dimensions specified in numOfBlocksOn***
        for(int x = 0; x < numOfBlocksOnXAxis; ++x)
        {
            for(int y = 0; y < numOfBlocksOnYAxis; ++y)
            {
                for(int z = 0; z < numOfBlocksOnZAxis; ++z)
                {
                    world.setBlock(
                       i + x, // this makes blocks of air go out however many numOfBlocksOnXAxis was
                       j - y, // this makes blocks of air go out however many numOfBlocksOnYAxis was
                       k + z, // this makes blocks of air go out however many numOfBlocksOnZAxis was
                       00 // the block of air
                       );
                }
            }
        }
    }
}

 

Then in the onBlockActivated() method, have something like this inside it:

PitfallHandler pit = new Pitfallhandler(Minecraft.getMinecraft().theWorld, (location of block x, y and z coords in the next 3 paramaters) xLocation, yLocation, zLocation);
pit.generatePitfall();

 

I garuntee that the PitfallHandler will work, the other... well :P

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

atrain99 World Shaper

atrain99

Posted
Posted
  On 6/17/2013 at 6:03 AM, Mew said:

I feel like a know all in this situation...

 

try something like this:

~snip~

 

 

I garuntee that the PitfallHandler will work, the other... well :P

 

I think the NPE you're getting comes from code order.

 

If you can single-step the code at the function, you can find the exact point where the NPE is thrown.

So, what would happen if I did push that shiny red button over there? ... Really? ... Can I try it? ... Damn.

Yagoki Diamond Finder

Yagoki

Posted
Posted

then surround 

world.setBlock(
                       i + x, // this makes blocks of air go out however many numOfBlocksOnXAxis was
                       j - y, // this makes blocks of air go out however many numOfBlocksOnYAxis was
                       k + z, // this makes blocks of air go out however many numOfBlocksOnZAxis was
                       00 // the block of air
                       );

with

if(world.getBlockId(i+x, j-y, k+z) == Block.stone.blockId)//or whatever blockId you want

github
Draco18s Reality Controller

Draco18s

Posted
Posted

Just as an FYI on Mew's code.

 

Don't make x y and z static...or hell, even the world (there's a different world object for each dimension!)

 

As soon as you have two of these suckers placed things will Go Weird.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 6/17/2013 at 6:42 PM, dontrell94 said:

It didn't look right as static, so mine isn't

 

Are you passing them to generatePitfall()?  Or are you pretending that they get magically set every time you want to use them?

That is:

Dynamic class-level variables aren't going to fix it alone.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

dontrell94 Stone Miner

dontrell94

Posted
  • Author
Posted

Tell me if i'm wrong....

 

Main block:

 

  Reveal hidden contents

 

 

Handler:

 

  Reveal hidden contents

 

I took over Hunting Traps Mod and work on helping the forge community as much as I can. View my work here: http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/wip-mods/1443756-1-7-2-1-6-4-1-5-2-1-4-7-hunting-traps-mod-v-0-4-0

Draco18s Reality Controller

Draco18s

Posted
Posted

I'm surprised this didn't throw an error.  You don't have enough parameters.

 

world.setBlock(
                                i + x, // this makes blocks of air go out however many numOfBlocksOnXAxis was
                                j - y, // this makes blocks of air go out however many numOfBlocksOnYAxis was
                                k + z, // this makes blocks of air go out however many numOfBlocksOnZAxis was
                                00, // the block of air
                                3 //tells the client and server that a block update is required.
                                );

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted

My bad.

Ever since they changed things from "setBlock/setBlockWithNotify/setBlockAndMetadata/setBlockAndMetadataWithNotify" to only one function (actually, two) they've thrown me for a loop.

 

You are correct, yours works and passes an implied metadata of 0 and a notify flag of 3.

 

Just out of curiosity:

You are doing this with the block on top of stone, yes?  It's only clearing a 2x2x2 cube at the moment, and only stone.

 

(Side note:

new PitfallHandler(Minecraft.getMinecraft().theWorld, i, j, k);

You can just use:

new PitfallHandler(world, i, j, k);

As the world is passed to the neighborChanged function)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept