Jump to content

Recommended Posts

Posted

BlockDescriptor is a Mystcraft API class, it contains block ID, block metadata, and an instability function that returns an integer.

 

I'm trying to sort the array from lowest to highest instability (so that the most unstable material is rarer than the more stable materials).

 

For some reason, allBlocks[0] is ended up as the most unstable (between the 4 blocks I've been using as a test), but the rest of the array is sorted correctly.

 

Input order is Dirt, Diamond Ore, Coal Ore, Birtch Logs (instability values of 0, 1000, 100, 0 respectively).

Output order is Diamond Ore, Dirt, Birtch Logs, Coal Ore.

 

What is wrong with my sort function?

 

 

 

private BlockDescriptor[] sortDescriptors(BlockDescriptor[] allBlocks, int left, int right)
    {
        int pivot = 0;

        if (left < right)
        {
            pivot = partition(allBlocks, left, right, pivot);
            allBlocks = sortDescriptors(allBlocks, left, pivot - 1);
            allBlocks = sortDescriptors(allBlocks, pivot + 1, right);
        }

        return allBlocks;
    }

    private int partition(BlockDescriptor[] allBlocks, int left, int right, int index)
    {
        int pivotValue = allBlocks[index].getInstability(2000);
        //swap pivot to the end
        BlockDescriptor temp = allBlocks[right];
        allBlocks[right] = allBlocks[index];
        allBlocks[index] = temp;
        int storeIndex = left;

        for (int i = left; i < right; i++)
        {
            if (allBlocks[i].getInstability(2000) <= pivotValue)
            {
                temp = allBlocks[i];
                allBlocks[i] = allBlocks[storeIndex];
                allBlocks[storeIndex] = temp;
                storeIndex++;
            }
        }

        temp = allBlocks[right];
        allBlocks[right] = allBlocks[storeIndex];
        allBlocks[storeIndex] = temp;
        return storeIndex;
    }

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • You can check mod compatibility remove new mods and test them one by one.
    • @Tsuk1 Also, new note, you can use blockbench to make the custom item model for when it is not on the head.   EDIT: Funny story, I am making a mod similar to yours! Mine is called NorseMC.
    • @Nood_dev Could you send a screenshot of your weapon code? Here is the one I made (for a dagger): The specific UUID does not matter, just that it is the same every time, which is why UUID#randomUUID does not work public class DaggerItem extends TieredItem implements Vanishable { protected static final double REACH_MODIFIER = -1.5D; protected final Multimap<Attribute, AttributeModifier> defaultModifiers; protected final UUID BASE_ATTACK_REACH_UUID = UUID.fromString("6fe75b5c-9d1b-4e83-9eea-a1d5a94e8dd5") public DaggerItem(Tier pTier, int pAttackDamageModifier, float pAttackSpeedModifier, Properties pProperties) { super(pTier, pAttackDamageModifier, pAttackSpeedModifier, pProperties); this.attackDamage = (float) pAttackDamageModifier + pTier.getAttackDamageBonus(); ImmutableMultimap.Builder<Attribute, AttributeModifier> builder = ImmutableMultimap.builder(); builder.put(Attributes.ATTACK_DAMAGE, new AttributeModifier(BASE_ATTACK_DAMAGE_UUID, "Weapon modifier", this.attackDamage, AttributeModifier.Operation.ADDITION)); builder.put(Attributes.ATTACK_SPEED, new AttributeModifier(BASE_ATTACK_SPEED_UUID, "Weapon modifier", pAttackSpeedModifier, AttributeModifier.Operation.ADDITION)); // THE ONE YOU WANT: builder.put(ForgeMod.ENTITY_REACH.get(), new AttributeModifier(BASE_ATTACK_REACH_UUID, "Weapon modifier", REACH_MODIFIER, AttributeModifier.Operation.ADDITION)); this.defaultModifiers = builder.build(); } @Override public Multimap<Attribute, AttributeModifier> getDefaultAttributeModifiers(EquipmentSlot pEquipmentSlot) { return pEquipmentSlot == EquipmentSlot.MAINHAND ? this.defaultModifiers : super.getDefaultAttributeModifiers(pEquipmentSlot); } }
    • https://images.app.goo.gl/1PxFKdxByTgkxvSu6
    • That's what we'll try out. I could never figure out how to recreate the crash, so I'll just have to wait and see.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.