Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • struggle on Render Model
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
Luis_ST

struggle on Render Model

By Luis_ST, November 24, 2020 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 24, 2020 (edited)

I creat a Custom Shield with Custom Model and ItemStackTileEntityRenderer

but i have the half model/texture: i cant upload my picture so look there: https://drive.google.com/file/d/1GSBd2k3mBavdYc_VhsvNlDajv7llqwBA/view?usp=sharing

Can somebody help me?

 

Edited November 24, 2020 by Luis_ST
correction
  • Quote

Share this post


Link to post
Share on other sites

TheGreyGhost    819

TheGreyGhost

TheGreyGhost    819

  • Reality Controller
  • TheGreyGhost
  • Members
  • 819
  • 3280 posts
Posted November 25, 2020

HI 

Pls show your code?  And upload your project to GitHub?

 

-TGG

 

 

  • Quote

Share this post


Link to post
Share on other sites

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 25, 2020
15 hours ago, TheGreyGhost said:

Pls show your code?  And upload your project to GitHub?

 okay this are the render class:

 

package net.luis.cave.render;

import com.mojang.blaze3d.matrix.MatrixStack;
import com.mojang.blaze3d.vertex.IVertexBuilder;

import net.luis.cave.model.EnderiteShieldModel;
import net.minecraft.client.renderer.IRenderTypeBuffer;
import net.minecraft.client.renderer.ItemRenderer;
import net.minecraft.client.renderer.entity.model.ShieldModel;
import net.minecraft.client.renderer.model.ItemCameraTransforms;
import net.minecraft.client.renderer.tileentity.ItemStackTileEntityRenderer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;

public class EnderiteShieldRender extends ItemStackTileEntityRenderer {
	
	 private final ShieldModel modelShield = new EnderiteShieldModel();
	 
	 public void func_239207_a_(ItemStack p_239207_1_, ItemCameraTransforms.TransformType p_239207_2_, MatrixStack p_239207_3_, 
			 					IRenderTypeBuffer p_239207_4_, int p_239207_5_, int p_239207_6_) {
		 
		 p_239207_3_.push();
		 p_239207_3_.scale(1.0F, -1.0F, -1.0F);
		 
		 final IVertexBuilder VertexBuilder = ItemRenderer.func_239391_c_(p_239207_4_, this.modelShield
				 .getRenderType(new ResourceLocation("cave:textures/entity/enderite_shield.png")), true, p_239207_1_.hasEffect());
		 
		 this.modelShield.func_228294_b_().render(p_239207_3_, VertexBuilder, p_239207_5_, p_239207_6_, 1.0F, 1.0F, 1.0F, 1.0F);	 
	
         p_239207_3_.pop();
         
	 }

}

 

and this are the model:

 

package net.luis.cave.model;

import java.util.List;
import java.util.Random;

import net.minecraft.block.BlockState;
import net.minecraft.client.renderer.entity.model.ShieldModel;
import net.minecraft.client.renderer.model.BakedQuad;
import net.minecraft.client.renderer.model.IBakedModel;
import net.minecraft.client.renderer.model.ItemOverrideList;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraft.util.Direction;

public class EnderiteShieldModel extends ShieldModel implements IBakedModel {

	@Override
	public List<BakedQuad> getQuads(BlockState state, Direction side, Random rand) {
		
		return null;
		
	}

	@Override
	public boolean isAmbientOcclusion() {
		
		return false;
		
	}

	@Override
	public boolean isGui3d() {
		
		return false;
		
	}

	@Override
	public boolean func_230044_c_() {
		
		return false;
		
	}

	@Override
	public boolean isBuiltInRenderer() {
		
		return true;
		
	}

	@Override
	public TextureAtlasSprite getParticleTexture() {
		
		return null;
		
	}

	@Override
	public ItemOverrideList getOverrides() {
		
		return null;
		
	}

 

I think these are the most important classes

  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    69

Beethoven92

Beethoven92    69

  • Dragon Slayer
  • Beethoven92
  • Members
  • 69
  • 556 posts
Posted November 25, 2020

Well, your code does exactly what you are telling it to do, have you taken a look at the ShieldModel class and its members/methods? If so you would notice that there are two getter methods that return two ModelRenderers, respectively one that represents the plate of the shield, and one that represents the handle. Now with:

this.modelShield.func_228294_b_().render(p_239207_3_, VertexBuilder, p_239207_5_, p_239207_6_, 1.0F, 1.0F, 1.0F, 1.0F);	

you are calling only one of these two methods, and you are rendering only the model that you get from it. By looking at the ShieldModel class you will see that this is the method that gets you the handle model

  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 26, 2020
18 hours ago, Beethoven92 said:

Well, your code does exactly what you are telling it to do, have you taken a look at the ShieldModel class and its members/methods? If so you would notice that there are two getter methods that return two ModelRenderers, respectively one that represents the plate of the shield, and one that represents the handle. Now with:


this.modelShield.func_228294_b_().render(p_239207_3_, VertexBuilder, p_239207_5_, p_239207_6_, 1.0F, 1.0F, 1.0F, 1.0F);	

you are calling only one of these two methods, and you are rendering only the model that you get from it. By looking at the ShieldModel class you will see that this is the method that gets you the handle model

okay i think i found the methods but it dosen't work

this now my model class

package net.luis.cave.model;

import java.util.List;
import java.util.Random;

import com.mojang.blaze3d.matrix.MatrixStack;
import com.mojang.blaze3d.vertex.IVertexBuilder;

import net.minecraft.block.BlockState;
import net.minecraft.client.renderer.entity.model.ShieldModel;
import net.minecraft.client.renderer.model.BakedQuad;
import net.minecraft.client.renderer.model.IBakedModel;
import net.minecraft.client.renderer.model.ItemOverrideList;
import net.minecraft.client.renderer.model.ModelRenderer;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraft.util.Direction;

public class EnderiteShieldModel extends ShieldModel implements IBakedModel {
	
	private final ModelRenderer plate;
	private final ModelRenderer handle;
	
	public EnderiteShieldModel() {
		
		this.textureWidth = 64;
		this.textureHeight = 64;
		this.plate = new ModelRenderer(this, 0, 0);
		this.plate.addBox(-6.0F, -11.0F, -2.0F, 12.0F, 22.0F, 1.0F, 0.0F);
		this.handle = new ModelRenderer(this, 26, 0);
		this.handle.addBox(-1.0F, -3.0F, -1.0F, 2.0F, 6.0F, 6.0F, 0.0F);
		
	}
	
	@Override
	public ModelRenderer func_228293_a_() {
		
		return this.plate;
		
	}
	
	@Override
	public ModelRenderer func_228294_b_() {
		
		return this.handle;
		
	}
	
	@Override
	public void render(MatrixStack matrixStackIn, IVertexBuilder bufferIn, int packedLightIn, int packedOverlayIn, float red, float green, float blue, float alpha) {
		
		this.plate.render(matrixStackIn, bufferIn, packedLightIn, packedOverlayIn, red, green, blue, alpha);
		this.handle.render(matrixStackIn, bufferIn, packedLightIn, packedOverlayIn, red, green, blue, alpha);

	}

	@Override
	public List<BakedQuad> getQuads(BlockState state, Direction side, Random rand) {
		
		return null;
		
	}

	@Override
	public boolean isAmbientOcclusion() {
		
		return false;
		
	}

	@Override
	public boolean isGui3d() {
		
		return false;
		
	}

	@Override
	public boolean func_230044_c_() {
		
		return false;
		
	}

	@Override
	public boolean isBuiltInRenderer() {
		
		return true;
		
	}

	@Override
	public TextureAtlasSprite getParticleTexture() {
		
		return null;
		
	}

	@Override
	public ItemOverrideList getOverrides() {
		
		return null;
		
	}
	
}

 

  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    69

Beethoven92

Beethoven92    69

  • Dragon Slayer
  • Beethoven92
  • Members
  • 69
  • 556 posts
Posted November 26, 2020

Actually you don't even need a custom model class, which in your case is identical to ShieldModel. You just have to apply your own texture to the vanilla shield model, which you have to do in the renderer. Also i don't get why you are implementing IBakedModel on your EnderiteShieldModel class. Look at how the ItemStackTileEntityRenderer class renders the shield

  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 26, 2020
52 minutes ago, Beethoven92 said:

Actually you don't even need a custom model class, which in your case is identical to ShieldModel. You just have to apply your own texture to the vanilla shield model, which you have to do in the renderer. Also i don't get why you are implementing IBakedModel on your EnderiteShieldModel class. Look at how the ItemStackTileEntityRenderer class renders the shield

okay thanks it work now

and another question/problem

i dont get the normal blocking model i think the predicate blocking dosent work

 

{
  "parent": "builtin/entity",
  "gui_light": "front",
  "textures": {
    "particle": "block/dark_oak_planks"
  },
  "display": {
    "thirdperson_righthand": {
      "rotation": [0, 90, 0],
      "translation": [10, 6, -4],
      "scale": [1, 1, 1]
    },
    "thirdperson_lefthand": {
      "rotation": [0, 90, 0],
      "translation": [10, 6, 12],
      "scale": [1, 1, 1]
    },
    "firstperson_righthand": {
      "rotation": [0, 180, 5],
      "translation": [-10, 2, -10],
      "scale": [1.25, 1.25, 1.25]
    },
    "firstperson_lefthand": {
      "rotation": [0, 180, 5],
      "translation": [10, 0, -10],
      "scale": [1.25, 1.25, 1.25]
    },
    "gui": {
      "rotation": [15, -25, -5],
      "translation": [2, 3, 0],
      "scale": [0.65, 0.65, 0.65]
    },
    "fixed": {
      "rotation": [0, 180, 0],
      "translation": [-2, 4, -5],
      "scale": [0.5, 0.5, 0.5]
    },
    "ground": {
      "rotation": [0, 0, 0],
      "translation": [4, 4, 2],
      "scale": [0.25, 0.25, 0.25]
    }
  },
  "overrides": [
    {
      "predicate": {
        "blocking": 1
      },
      "model": "cave:item/enderite_shield_blocking"
    }
  ]
}

 

  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    69

Beethoven92

Beethoven92    69

  • Dragon Slayer
  • Beethoven92
  • Members
  • 69
  • 556 posts
Posted November 26, 2020

Item overrides are hardcoded for vanilla items, so the "blocking" property only works with Items.SHIELD. You need to register your own "blocking" property and bind it to your custom shield item. Take a look at the ItemModelsProperties class. Bow, Compass Clock ecc.. properties are also defined there.

  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 26, 2020
1 hour ago, Beethoven92 said:

Item overrides are hardcoded for vanilla items, so the "blocking" property only works with Items.SHIELD. You need to register your own "blocking" property and bind it to your custom shield item. Take a look at the ItemModelsProperties class. Bow, Compass Clock ecc.. properties are also defined there.

Okay i just look into this class so i creat this:

 

package net.luis.cave.models;

import net.luis.cave.init.CaveTools;
import net.minecraft.item.ItemModelsProperties;
import net.minecraft.util.ResourceLocation;

public class ShieldItemModelProperties extends ItemModelsProperties {
	
	public ShieldItemModelProperties() {
		
		func_239418_a_(CaveTools.ENDERITE_SHIELD.get(), new ResourceLocation("blocking"), (p_239421_0_, p_239421_1_, p_239421_2_) -> {
			
			return p_239421_2_ != null && p_239421_2_.isHandActive() && p_239421_2_.getActiveItemStack() == p_239421_0_ ? 1.0F : 0.0F;
			
		});
		
	}

}

 

Where should I add this to the shield or where should i register this

  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    69

Beethoven92

Beethoven92    69

  • Dragon Slayer
  • Beethoven92
  • Members
  • 69
  • 556 posts
Posted November 26, 2020 (edited)

There is not need to extend ItemModelsProperties since func_239418_a_ is a static method. You have to register your properties during your client setup event

Edited November 26, 2020 by Beethoven92
  • Thanks 1
  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

Luis_ST    0

Luis_ST

Luis_ST    0

  • Creeper Killer
  • Luis_ST
  • Members
  • 0
  • 140 posts
Posted November 27, 2020
19 hours ago, Beethoven92 said:

There is not need to extend ItemModelsProperties since func_239418_a_ is a static method. You have to register your properties during your client setup event

okay thanks so much the Shield works perfectly

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • rennmaus
      gradlew build file too small

      By rennmaus · Posted 2 minutes ago

      Hey, I'm sorry for my bad english, isn't the best. I've coded a small mod in eclipse with forge gradle, but when i export it, the file is just 8kb small. My Launcher notice the mod, but do not add the crafting recipes etc. Can anyone help me please? Before i started coding, i typed in the command line: ./gradlew eclipse and it worked...   Christian
    • Shinzu🖤
      Ive been trying to make my own server and whenever i run the command that microsoft/minecraft gave me it just says the following

      By Shinzu🖤 · Posted 3 minutes ago

      Ive been trying to make my own server and whenever i run the command that microsoft/minecraft gave me it just says the following
    • diesieben07
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By diesieben07 · Posted 38 minutes ago

      Then you need an IItemHandler that combines the default slots (call super.getCapability to get them) and your own.
    • Klarks
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By Klarks · Posted 53 minutes ago

      To get my itemhandler.i need to get default living entity slots and my custom slots
    • diesieben07
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By diesieben07 · Posted 57 minutes ago

      That's an infinite loop. Why are you overriding getCapability at all?
  • Topics

    • Klarks
      13
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By Klarks
      Started 5 hours ago

    • Fars3O_
      1
      Minecraft forge not fully loading

      By Fars3O_
      Started 5 hours ago

    • BastouP
      3
      [1.16.4] Get Overworld save directory

      By BastouP
      Started 15 hours ago

    • Woodside
      15
      [1.15.2] Render as 2D icon in GUI, 3D model in hand

      By Woodside
      Started Sunday at 08:26 PM

    • CatSack
      1
      Forge unable to find model

      By CatSack
      Started 13 hours ago

  • Who's Online (See full list)

    • Aďas
    • rennmaus
    • night_charm
    • Shinzu🖤
    • loordgek
    • Danebi
    • Klarks
    • diesieben07
    • Wintersky20
    • GhostAkil
    • joaofm
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • struggle on Render Model
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community