Jump to content

Getting an Entity from EntityType


Turtledove

Recommended Posts

So I need to create a lookup table of several of my custom entities, via the EntityType members of my entity registry. The entities are successfully registered;

 

    public static final EntityType<DemonFangEntity> DEMON_FANG = registerEntity(EntityType.Builder.create(DemonFangEntity::new, EntityClassification.MISC).size(0.7F, 0.7F), "demon_fang");

 

and when I need an entity to spawn I simply call the following method where I try to return an entity via a string key. In this case, I'd need this to return a DemonFangEntity object (it extends WithernautsMagicEntity):

 

    public WithernautsMagicEntity getMagicEntity(World worldIn, String key)
    {
        try {
            for (Field f : EntityRegistry.class.getDeclaredFields())
            {
                Object obj = f.get(null);
                if (obj instanceof EntityType)
                {
                    EntityType type = (EntityType)obj;
                    Entity entity = type.create(worldIn);
                    if (entity instanceof WithernautsMagicEntity)
                    {
                        WithernautsMagicEntity magicEntity = (WithernautsMagicEntity)entity;
                        if (magicEntity.getKey().equals(key))
                            return magicEntity;
                    }
                }
            }
            throw new IllegalArgumentException();
        } catch (IllegalAccessException e)
        {
            throw new RuntimeException(e);
        }
    }

 

However, this method currently throws an exception because Entity entity = type.create(worldIn) returns null. What's a way I could correctly return an object of EntityType's template type? Or is this just not possible without reflection?

 

Sidenote: I'm trying to do it this way because I don't want to create a giant conditional statement since it would not scale well at all with my project's scope.

Edited by Turtledove
Link to comment
Share on other sites

Okay...

first thing wrong is with your reflection code: you are passing null into the .get() method, that's not how it works.

you need to pass it an instance of the Object that you got the Field from, in this case you need the instance of EntityRegistry.

 

But there's a way better way of accomplishing what you want, you can just get the Deffered Register from your EntityRegistry class, and it has a method called .getEntries(), I think it's pretty self explanatory what it does.

 

This should solve your problem and drastically simplify the code

Link to comment
Share on other sites

1 hour ago, Turtledove said:

Sidenote: I'm trying to do it this way because I don't want to create a giant conditional statement since it would not scale well at all with my project's scope.

I don't see in which scenario not using reflection would result in a giant conditional statement

 

1 hour ago, Turtledove said:

and when I need an entity to spawn I simply call the following method where I try to return an entity via a string key.

Trying to get things by string is very error-prone, you should at a minimun store the Entity Id String in your EntityRegistry as a static final, and then use it when needed

Link to comment
Share on other sites

30 minutes ago, kiou.23 said:

I don't see in which scenario not using reflection would result in a giant conditional statement

 

Trying to get things by string is very error-prone, you should at a minimun store the Entity Id String in your EntityRegistry as a static final, and then use it when needed

Ugly conditionals, as in:

switch key:
	case 'blah':
		return BlahEntity object
	case 'foo':
		return FooEntity object
	case 'bar':
		return BarEntity object
	.
	.
	.
	case 'blah':
		return BlahEntity object

Where I'd need to add to this whenever I add new relevant Entities. This is what I'm avoiding.

 

35 minutes ago, kiou.23 said:

Okay...

first thing wrong is with your reflection code: you are passing null into the .get() method, that's not how it works.

you need to pass it an instance of the Object that you got the Field from, in this case you need the instance of EntityRegistry.

 

This part works just fine, we pass null to field.get() in this case because the members it's looking for are static. It correctly retreives the EntityTypes, the problem is that I don't know how to get an Entity object out of it.

 

Edited by Turtledove
Link to comment
Share on other sites

Howdy

 

 

I'm not sure I understand the problem you're facing.

 

Because you control the creation of your own types, you should be able to create a map of the entity type and its string name when you create them, and when you get a string name, use that map to decide if it's one of your entities and then spawn it.  Your registered entity type has the factory in it already.

 

Using reflection to search your own registry class seems like a very strange idea to me.

 

I also suggest not to use static initialisers for your entity types; either used DeferredRegistry or use an event, like this

https://github.com/TheGreyGhost/MinecraftByExample/blob/master/src/main/java/minecraftbyexample/mbe81_entity_projectile/StartupCommon.java

 

Cheers

  TGG

 

 

 

 

 

Link to comment
Share on other sites

22 minutes ago, Turtledove said:

It correctly retreives the EntityTypes, the problem is that I don't know how to get an Entity object out of it.

You can use EntityType.create(), this returns a new Entity

 

23 minutes ago, Turtledove said:

This part works just fine, we pass null to field.get() in this case because the members it's looking for are static.

Oh yeah, those are static, my bad. It's that I just spended the whole day doing reflection and getting non static values

Link to comment
Share on other sites

27 minutes ago, Turtledove said:

Ugly conditionals, as in:


switch key:
	case 'blah':
		return BlahEntity object
	case 'foo':
		return FooEntity object
	case 'bar':
		return BarEntity object
	.
	.
	.
	case 'blah':
		return BlahEntity object

Where I'd need to add to this whenever I add new relevant Entities. This is what I'm avoiding.

Can't you make the method generic? make it receive a EntityType<T> and then return the entity from it

It also seems very redundant, why do you need a method for this, isn't it easier to call EntityRegistry.RANDOM_ENTITY_TYPE.get().create()?

 

I also don't get why you are using reflections. I suppose you're using Deferred Registries, and the Deferred Regsitry has a method that returns all entries. And if you're not using Deferred Registries, you should

Edited by kiou.23
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • this is my crash report i get when i try to run my server help would be amazing really dont wanna have to start again     ---- Minecraft Crash Report ---- // Who set us up the TNT? Time: 2023-12-10 19:19:35 Description: Exception in server tick loop net.minecraftforge.fml.config.ConfigFileTypeHandler$ConfigLoadingException: Failed loading config file jei-server.toml of type SERVER for modid jei     at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:47) ~[fmlcore-1.20.1-47.2.17.jar%23168!/:?] {}     at net.minecraftforge.fml.config.ConfigTracker.openConfig(ConfigTracker.java:60) ~[fmlcore-1.20.1-47.2.17.jar%23168!/:?] {}     at net.minecraftforge.fml.config.ConfigTracker.lambda$loadConfigs$1(ConfigTracker.java:50) ~[fmlcore-1.20.1-47.2.17.jar%23168!/:?] {}     at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {re:mixin}     at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2131) ~[?:?] {}     at net.minecraftforge.fml.config.ConfigTracker.loadConfigs(ConfigTracker.java:50) ~[fmlcore-1.20.1-47.2.17.jar%23168!/:?] {}     at net.minecraftforge.server.ServerLifecycleHooks.handleServerAboutToStart(ServerLifecycleHooks.java:96) ~[forge-1.20.1-47.2.17-universal.jar%23172!/:?] {re:classloading}     at net.minecraft.server.dedicated.DedicatedServer.m_7038_(DedicatedServer.java:162) ~[server-1.20.1-20230612.114412-srg.jar%23167!/:?] {re:classloading,pl:accesstransformer:B}     at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:634) ~[server-1.20.1-20230612.114412-srg.jar%23167!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:A}     at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251) ~[server-1.20.1-20230612.114412-srg.jar%23167!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:A}     at java.lang.Thread.run(Thread.java:842) ~[?:?] {} Caused by: com.electronwill.nightconfig.core.io.ParsingException: Not enough data available     at com.electronwill.nightconfig.core.io.ParsingException.notEnoughData(ParsingException.java:22) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.io.ReaderInput.directReadChar(ReaderInput.java:36) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.io.AbstractInput.readChar(AbstractInput.java:49) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.io.AbstractInput.readCharsUntil(AbstractInput.java:123) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.toml.TableParser.parseKey(TableParser.java:166) ~[toml-3.6.4.jar%2359!/:?] {}     at com.electronwill.nightconfig.toml.TableParser.parseDottedKey(TableParser.java:145) ~[toml-3.6.4.jar%2359!/:?] {}     at com.electronwill.nightconfig.toml.TableParser.parseNormal(TableParser.java:55) ~[toml-3.6.4.jar%2359!/:?] {}     at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:44) ~[toml-3.6.4.jar%2359!/:?] {}     at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:37) ~[toml-3.6.4.jar%2359!/:?] {}     at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:113) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:219) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:202) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.file.WriteSyncFileConfig.load(WriteSyncFileConfig.java:73) ~[core-3.6.4.jar%2358!/:?] {}     at com.electronwill.nightconfig.core.file.AutosaveCommentedFileConfig.load(AutosaveCommentedFileConfig.java:85) ~[core-3.6.4.jar%2358!/:?] {}     at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:43) ~[fmlcore-1.20.1-47.2.17.jar%23168!/:?] {}     ... 10 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details:     Minecraft Version: 1.20.1     Minecraft Version ID: 1.20.1     Operating System: Windows 11 (amd64) version 10.0     Java Version: 17.0.9, Oracle Corporation     Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation     Memory: 711865472 bytes (678 MiB) / 2136997888 bytes (2038 MiB) up to 4271898624 bytes (4074 MiB)     CPUs: 16     Processor Vendor: AuthenticAMD     Processor Name: AMD Ryzen 7 5800X 8-Core Processor                  Identifier: AuthenticAMD Family 25 Model 33 Stepping 0     Microarchitecture: Zen 3     Frequency (GHz): 3.80     Number of physical packages: 1     Number of physical CPUs: 8     Number of logical CPUs: 16     Graphics card #0 name: NVIDIA GeForce RTX 3060 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x2414     Graphics card #0 versionInfo: DriverVersion=31.0.15.4629     Memory slot #0 capacity (MB): 8192.00     Memory slot #0 clockSpeed (GHz): 3.60     Memory slot #0 type: DDR4     Memory slot #1 capacity (MB): 8192.00     Memory slot #1 clockSpeed (GHz): 3.60     Memory slot #1 type: DDR4     Virtual memory max (MB): 19238.84     Virtual memory used (MB): 10746.77     Swap memory total (MB): 2944.00     Swap memory used (MB): 0.00     JVM Flags: 0 total;      Server Running: true     Player Count: 0 / 20; []     Data Packs: vanilla, mod:terrablender (incompatible), mod:mousetweaks, mod:supermartijn642configlib (incompatible), mod:geckolib, mod:excavar, mod:ae2 (incompatible), mod:supermartijn642corelib (incompatible), mod:wthit (incompatible), mod:curios (incompatible), mod:mekanism, mod:patchouli (incompatible), mod:xaerominimap, mod:travelersbackpack, mod:badpackets (incompatible), mod:betterthirdperson, mod:mixinextras (incompatible), mod:uteamcore, mod:mekanismtools, mod:architectury (incompatible), mod:globalxp, mod:mekanismgenerators, mod:beyond_earth (incompatible), mod:ars_nouveau (incompatible), mod:fallingtree (incompatible), mod:extradisks, mod:cloth_config (incompatible), mod:sound_physics_remastered, mod:forge, mod:commonality, mod:apexcore, mod:refinedstorage, mod:refinedstorageaddons, mod:durabilitytooltip (incompatible), mod:corpse, mod:nyfsspiders (incompatible), mod:jei     Enabled Feature Flags: minecraft:vanilla     World Generation: Stable     Is Modded: Definitely; Server brand changed to 'forge'     Type: Dedicated Server (map_server.txt)     ModLauncher: 10.0.9+10.0.9+main.dcd20f30     ModLauncher launch target: forgeserver     ModLauncher naming: srg     ModLauncher services:          mixin-0.8.5.jar mixin PLUGINSERVICE          eventbus-6.0.5.jar eventbus PLUGINSERVICE          fmlloader-1.20.1-47.2.17.jar slf4jfixer PLUGINSERVICE          fmlloader-1.20.1-47.2.17.jar object_holder_definalize PLUGINSERVICE          fmlloader-1.20.1-47.2.17.jar runtime_enum_extender PLUGINSERVICE          fmlloader-1.20.1-47.2.17.jar capability_token_subclass PLUGINSERVICE          accesstransformers-8.0.4.jar accesstransformer PLUGINSERVICE          fmlloader-1.20.1-47.2.17.jar runtimedistcleaner PLUGINSERVICE          modlauncher-10.0.9.jar mixin TRANSFORMATIONSERVICE          modlauncher-10.0.9.jar fml TRANSFORMATIONSERVICE      FML Language Providers:          minecraft@1.0         lowcodefml@null         javafml@null     Mod List:          server-1.20.1-20230612.114412-srg.jar             |Minecraft                     |minecraft                     |1.20.1              |DONE      |Manifest: NOSIGNATURE         TerraBlender-forge-1.20.1-3.0.0.169.jar           |TerraBlender                  |terrablender                  |3.0.0.169           |DONE      |Manifest: NOSIGNATURE         MouseTweaks-forge-mc1.20-2.25.jar                 |Mouse Tweaks                  |mousetweaks                   |2.25                |DONE      |Manifest: NOSIGNATURE         supermartijn642configlib-1.1.8-forge-mc1.20.jar   |SuperMartijn642's Config Libra|supermartijn642configlib      |1.1.8               |DONE      |Manifest: NOSIGNATURE         geckolib-forge-1.20.1-4.2.4.jar                   |GeckoLib 4                    |geckolib                      |4.2.4               |DONE      |Manifest: NOSIGNATURE         Excavar-1.20.1-3.1.0.jar                          |Excavar                       |excavar                       |1.20.1-3.1.0        |DONE      |Manifest: NOSIGNATURE         jei-1.20.1-forge-15.2.0.27.jar                    |Just Enough Items             |jei                           |15.2.0.27           |DONE      |Manifest: NOSIGNATURE         appliedenergistics2-forge-15.0.15.jar             |Applied Energistics 2         |ae2                           |15.0.15             |DONE      |Manifest: NOSIGNATURE         supermartijn642corelib-1.1.15-forge-mc1.20.jar    |SuperMartijn642's Core Lib    |supermartijn642corelib        |1.1.15              |DONE      |Manifest: NOSIGNATURE         wthit-forge-8.4.3.jar                             |wthit                         |wthit                         |8.4.3               |DONE      |Manifest: NOSIGNATURE         curios-forge-5.4.5+1.20.1.jar                     |Curios API                    |curios                        |5.4.5+1.20.1        |DONE      |Manifest: NOSIGNATURE         Mekanism-1.20.1-10.4.5.19.jar                     |Mekanism                      |mekanism                      |10.4.5              |DONE      |Manifest: NOSIGNATURE         Patchouli-1.20.1-83-FORGE.jar                     |Patchouli                     |patchouli                     |1.20.1-83-FORGE     |DONE      |Manifest: NOSIGNATURE         Xaeros_Minimap_23.9.1_Forge_1.20.jar              |Xaero's Minimap               |xaerominimap                  |23.9.1              |DONE      |Manifest: NOSIGNATURE         TravelersBackpack-1.20.1-9.1.11.jar               |Traveler's Backpack           |travelersbackpack             |9.1.11              |DONE      |Manifest: NOSIGNATURE         badpackets-forge-0.4.3.jar                        |Bad Packets                   |badpackets                    |0.4.3               |DONE      |Manifest: NOSIGNATURE         BetterThirdPerson-Forge-1.20-1.9.0.jar            |Better Third Person           |betterthirdperson             |1.9.0               |DONE      |Manifest: NOSIGNATURE         mixinextras-forge-0.2.0-beta.8.jar                |MixinExtras                   |mixinextras                   |0.2.0-beta.8        |DONE      |Manifest: NOSIGNATURE         u_team_core-forge-1.20.1-5.1.4.269.jar            |U Team Core                   |uteamcore                     |5.1.4.269           |DONE      |Manifest: f4:a6:0b:ee:cb:8a:1a:ea:9f:9d:45:91:8f:8b:b3:ae:26:f3:bf:05:86:1d:90:9e:f6:32:2a:1a:ed:1d:ce:b0         MekanismTools-1.20.1-10.4.5.19.jar                |Mekanism: Tools               |mekanismtools                 |10.4.5              |DONE      |Manifest: NOSIGNATURE         architectury-9.1.12-forge.jar                     |Architectury                  |architectury                  |9.1.12              |DONE      |Manifest: NOSIGNATURE         globalxp-1.20-1.10.3.jar                          |Global XP                     |globalxp                      |1.10.3              |DONE      |Manifest: NOSIGNATURE         MekanismGenerators-1.20.1-10.4.5.19.jar           |Mekanism: Generators          |mekanismgenerators            |10.4.5              |DONE      |Manifest: NOSIGNATURE         Beyond-Earth-1.20.1-7.0-SNAPSHOT.jar              |Beyond Earth                  |beyond_earth                  |7.0-SNAPSHOT        |DONE      |Manifest: NOSIGNATURE         ars_nouveau-1.20.1-4.7.4-all.jar                  |Ars Nouveau                   |ars_nouveau                   |4.7.4               |DONE      |Manifest: NOSIGNATURE         FallingTree-1.20.1-4.3.2.jar                      |FallingTree                   |fallingtree                   |4.3.2               |DONE      |Manifest: 3c:8e:df:6c:df:a6:2a:9f:af:64:ea:04:9a:cf:65:92:3b:54:93:0e:96:50:b4:52:e1:13:42:18:2b:ae:40:29         ExtraDisks-1.20.1-3.0.1.jar                       |Extra Disks                   |extradisks                    |1.20.1-3.0.1        |DONE      |Manifest: NOSIGNATURE         cloth-config-11.1.106-forge.jar                   |Cloth Config v10 API          |cloth_config                  |11.1.106            |DONE      |Manifest: NOSIGNATURE         soundphysics-forge-1.20.1-1.1.1.jar               |Sound Physics Remastered      |sound_physics_remastered      |1.20.1-1.1.1        |DONE      |Manifest: NOSIGNATURE         forge-1.20.1-47.2.17-universal.jar                |Forge                         |forge                         |47.2.17             |DONE      |Manifest: 84:ce:76:e8:45:35:e4:0e:63:86:df:47:59:80:0f:67:6c:c1:5f:6e:5f:4d:b3:54:47:1a:9f:7f:ed:5e:f2:90         commonality-1.20.1-7.0.0.jar                      |Commonality                   |commonality                   |7.0.0               |DONE      |Manifest: NOSIGNATURE         apexcore-1.20.1-10.0.0.jar                        |ApexCore                      |apexcore                      |10.0.0              |DONE      |Manifest: NOSIGNATURE         refinedstorage-1.12.4.jar                         |Refined Storage               |refinedstorage                |1.12.4              |DONE      |Manifest: NOSIGNATURE         refinedstorageaddons-0.10.0.jar                   |Refined Storage Addons        |refinedstorageaddons          |0.10.0              |DONE      |Manifest: NOSIGNATURE         durabilitytooltip-1.1.5-forge-mc1.20.jar          |Durability Tooltip            |durabilitytooltip             |1.1.5               |DONE      |Manifest: NOSIGNATURE         corpse-1.20.1-1.0.9.jar                           |Corpse                        |corpse                        |1.20.1-1.0.9        |DONE      |Manifest: NOSIGNATURE         nyfsspiders-forge-1.20.1-2.1.1.jar                |Nyf's Spiders                 |nyfsspiders                   |2.1.1               |DONE      |Manifest: NOSIGNATURE     Crash Report UUID: 8651d130-7ff8-4155-aaae-797986a5116d     FML: 47.2     Forge: net.minecraftforge:47.2.17
    • Maybe try with removing the mod "create goggles". In the log it looks like there is an issue with this mod too!
    • If music flows in your veins, makes you change, reveal yourself in kaleidoscope of emotions, then our website for downloading electronic music will help you always have around good compositions and cheerful mood. Great choice of different genres will cheer the heart of any music lover. muzhousebeat.com
    • Firstly, Java 17 is not required for Forge in Minecraft version 1.12.2, instead it can be deadly to run a 1.12.2 server with Java 17, use Java 8!! Use the correct Java 8 path for the server and you should be good to go! For my use, I am using Eclipse Temurin Java, which you can download relatively easy! Here you have my start arguments when starting Forge server 1.12.2! "C:\Program Files\Eclipse Adoptium\jre-8.0.392.8-hotspot\bin\javaw.exe" -Xmx4G -Xms4G -jar forge-1.12.2-14.23.5.2860.jar pause As I am using Java JRE not Java JDK, please use the version that is best for you! With best regards  nicky.gg
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.