Jump to content

Recommended Posts

Posted

Hi all,

 

I'm trying to make a custom picaxe that will smelt the block you mine. However, when I try to get the smelt result of a block, it always returns null, EXCEPT for the first time for each new block.

The first stone I mined, smelted into stone, however after that it returned null every time. The first iron ore I mined dropped an iron ingot, after that FurnaceRecipes.smelting().getSmeltingResult(new ItemStack(Block.blocksList[par3])) always returned null for iron ore (I have checked to make sure that new ItemStack(Block.blocksList[par3]) is of the correct type). Can anyone help me? Here is my onBlockDestroyed code

 

@Override
public boolean onBlockDestroyed(ItemStack par1ItemStack, World par2World, int par3, int x, int y, int z, EntityLiving par7EntityLiving) {

	        boolean dropModified = false;
		if (!par2World.isRemote)
		{


			ItemStack res = FurnaceRecipes.smelting().getSmeltingResult(new ItemStack(Block.blocksList[par3]));
			if (res != null)
			{
				float f = 0.7F;
				double d0 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d1 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d2 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				EntityItem entityitem = new EntityItem(par2World, (double)x + d0, (double)y + d1, (double)z + d2, res);
				entityitem.delayBeforeCanPickup = 10;
				par2World.spawnEntityInWorld(entityitem);
				dropModified = true;
			}

	        }
                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);
	        return true;
}

Posted

Do you need the

                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);

? If not, try deleting it.

↑↑↑↑↑↑↑↑↑↑ Click it please? :3 ↑↑↑↑↑↑↑↑↑↑

Posted

Do you need the

                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);

? If not, try deleting it.

 

The whole statement? Then the block will drop the smelted contents and the original contents too won't it?

 

I need the pickaxe should only smelt things SOMETIMES as in there's a chance it will drop regularly. I didnt put that part into the code I posted but it shouldn't affect it. My issue is that FurnaceRecipes returns null even though it shouldn't.

Posted
which heu ......

 

which class has the code for onBlockDestroyed?

 

im serious btw, this might be a huge problem

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

which heu ......

 

which class has the code for onBlockDestroyed?

 

im serious btw, this might be a huge problem

 

As I said my class is extending ItemPickaxe.

 

OnBlockDestroyed is part of ItemTool

Posted

which heu ......

 

which class has the code for onBlockDestroyed?

 

im serious btw, this might be a huge problem

 

As I said my class is extending ItemPickaxe.

 

OnBlockDestroyed is part of ItemTool

 

ItemPickaxe extends ItemTool

Posted

which heu ......

 

which class has the code for onBlockDestroyed?

 

im serious btw, this might be a huge problem

 

As I said my class is extending ItemPickaxe.

 

OnBlockDestroyed is part of ItemTool

 

ItemPickaxe extends ItemTool

 

Yes, that is how I overrode it.

Posted

just for fun, try

 

ItemStack iss = (ItemStack)FurnaceRecipes.smelting().getSmeltingList().get(par3);

 

its basicly what vanilla is doing. also safecheck non-null of "iss"

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

just for fun, try

 

ItemStack iss = (ItemStack)FurnaceRecipes.smelting().getSmeltingList().get(par3);

 

its basicly what vanilla is doing. also safecheck non-null of "iss"

 

It seems like my problem is now in this part:

 

if (!par2World.isRemote && par2World.getGameRules().getGameRuleBooleanValue("doTileDrops"))
			{
				float f = 0.7F;
				double d0 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d1 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d2 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				EntityItem entityitem = new EntityItem(par2World, (double)x + d0, (double)y + d1, (double)z + d2, iss);
				entityitem.delayBeforeCanPickup = 10;
				par2World.spawnEntityInWorld(entityitem);
				dropModified = true;
			}

 

Its not actually spawning anything even though the code is run just fine. It spawns something once then stops

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I have this same problem. Did you manage to find a solution? Any help would be appreciated. Thanks.
    • log: https://mclo.gs/QJg3wYX as stated in the title, my game freezes upon loading into the server after i used a far-away waystone in it. The modpack i'm using is better minecraft V18. Issue only comes up in this specific server, singleplayer and other servers are A-okay. i've already experimented with removing possible culprits like modernfix and various others to no effect. i've also attempted a full reinstall of the modpack profile. Issue occurs shortly after the 'cancel' button dissapears on the 'loading world' section of the loading screen.   thanks in advance.
    • You would have better results asking a more specific question. What have you done? What exactly do you need help with? Please also read the FAQ regarding posting logs.
    • Hi, this is my second post with the same content as no one answered this and it's been a long time since I made the last post, I want to make a client-only mod, everything is ok, but when I use shaders, none of the textures rendered in RenderLevelStageEvent nor the crow entity model are rendered, I want them to be visible, because it's a horror themed mod I've already tried it with different shaders, but it didn't work with any of them and I really want to add support for shaders Here is how i render the crow model in the CrowEntityRenderer<CrowEntity>, by the time i use this method, i know is not the right method but i don't think this is the cause of the problem, the renderType i'm using is entityCutout @Override public void render(CrowEntity p_entity, float entityYaw, float partialTick, PoseStack poseStack, MultiBufferSource bufferSource, int packedLight) { super.render(p_entity, entityYaw, partialTick, poseStack, bufferSource, packedLight); ClientEventHandler.getClient().crow.renderToBuffer(poseStack, bufferSource.getBuffer(ClientEventHandler.getClient().crow .renderType(TEXTURE)), packedLight, OverlayTexture.NO_OVERLAY, Utils.rgb(255, 255, 255)); } Here renderLevelStage @Override public void renderWorld(RenderLevelStageEvent e) { horrorEvents.draw(e); } Here is how i render every event public void draw(RenderLevelStageEvent e) { for (HorrorEvent event : currentHorrorEvents) { event.tick(e.getPartialTick()); event.draw(e); } } Here is how i render the crow model on the event @Override public void draw(RenderLevelStageEvent e) { if(e.getStage() == RenderLevelStageEvent.Stage.AFTER_ENTITIES) { float arcProgress = getArcProgress(0.25f); int alpha = (int) Mth.lerp(arcProgress, 0, 255); int packedLight = LevelRenderer.getLightColor(Minecraft.getInstance().level, blockPos); VertexConsumer builder = ClientEventHandler.bufferSource.getBuffer(crow); Crow<CreepyBirdHorrorEvent> model = ClientEventHandler .getClient().crow; model.setupAnim(this); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, packedLight, OverlayTexture.NO_OVERLAY, alpha); builder = ClientEventHandler.bufferSource.getBuffer(eyes); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, 15728880, OverlayTexture.NO_OVERLAY, alpha); } } How i render the model public static void renderModelInWorld(Model model, Vector3f pos, Vector3f offset, Camera camera, PoseStack matrix, VertexConsumer builder, int light, int overlay, int alpha) { matrix.pushPose(); Vec3 cameraPos = camera.getPosition(); double finalX = pos.x - cameraPos.x + offset.x; double finalY = pos.y - cameraPos.y + offset.y; double finalZ = pos.z - cameraPos.z + offset.z; matrix.pushPose(); matrix.translate(finalX, finalY, finalZ); matrix.mulPose(Axis.XP.rotationDegrees(180f)); model.renderToBuffer(matrix, builder, light, overlay, Utils .rgba(255, 255, 255, alpha)); matrix.popPose(); matrix.popPose(); } Thanks in advance
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.