This code is not working anything i did wrong?

[Turnrp]

Im trying to detect when a player clicks with my item

 

if (player.getHeldItemMainhand().getItem() == RegistryHandler.BACKPACK.get())
        player.setHealth(0);
}

[Turnrp]

Btw i just added braces to it and it still did nothing

[Turnrp]

New Code:

 

if (player.getHeldItemMainhand().getItem() == RegistryHandler.BACKPACK.get()) {
    player.setHealth(0);
}

 

 

P.S Still doesn't work

Edited December 23, 2020 by Turnrp

[Saksham4106]

that's way too less info... where are you writing this if statement?

 

[Turnrp]

  On 12/23/2020 at 8:04 AM, Saksham4106 said:

that's way too less info... where are you writing this if statement?

 

Expand  

@SubscribeEvent
public void OnRightClick(PlayerInteractEvent.RightClickItem RightClick) {
    LivingEntity player = RightClick.getEntityLiving();
    if (player.getHeldItemMainhand().getItem() == RegistryHandler.BACKPACK.get()) {
        player.setHealth(0);
    }
}

[Saksham4106]

which version is this?
tis method doesn't exist in 1.15

 

Edited December 23, 2020 by Saksham4106

[Turnrp]

1.16.4

Edited December 23, 2020 by Turnrp
1.16+

[Saksham4106]

oh nvm that was dumb i didn't see you are making an event

you can just override onItemRightClick in your item's class

[Turnrp]

So i do the event inside the item class?

[Saksham4106]

no inside your backpack item class
you'll need to just override onItemRightClick and then do 

 player.setHealth(0);

inside that method

[Turnrp]

I did @Overide OnItemRightClick and nothing shows up

[Turnrp]

there is 

PlayerInteractEvent.RightClickItem

[Saksham4106]

   @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        playerIn.setHealth(0);
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }

 

[Turnrp]

  On 12/23/2020 at 8:20 AM, Saksham4106 said:

   @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
        playerIn.setHealth(0);
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }

 

Expand  

gave me a bunch of errors

[Turnrp]

and yes i added the classes

[Saksham4106]

what errors

 

[Turnrp]

Im gonna head to bed just right things you can help me with in here gn ill talk tommorow

[Saksham4106]

  On 12/23/2020 at 8:28 AM, Turnrp said:

Im gonna head to bed just right things you can help me with in here gn ill talk tommorow

Expand  

k..,. just saying that your item's class should extend Item if you didn't do that

[DavidM]

1. That method triggers on both the client and the server side. You will need to check the side with World#isRemote.

2. Your overriding method does not have the correct signatures (please learn Java before attempting to write a mod).

[Turnrp]

  On 12/23/2020 at 8:31 AM, Saksham4106 said:

k..,. just saying that your item's class should extend Item if you didn't do that

Expand  

I did do that 

[Turnrp]

  On 12/23/2020 at 8:45 AM, DavidM said:

1. That method triggers on both the client and the server side. You will need to check the side with World#isRemote.

2. Your overriding method does not have the correct signatures (please learn Java before attempting to write a mod).

Expand  

I jsut wanna know why its broken

[kiou.23]

  On 12/23/2020 at 7:48 PM, Turnrp said:

I jsut wanna know why its broken

Expand  

Learning java is the best way of knowing why your code is broken

Learn Java

 

"keep in mind that this is not a Java school. You are expected to have basic knowledge of Java before posting here." - this is literally right below the forum title

[DavidM]

  On 12/23/2020 at 7:48 PM, Turnrp said:

I jsut wanna know why its broken

Expand  

I just told you.

  On 12/23/2020 at 8:45 AM, DavidM said:

Your overriding method does not have the correct signatures

Expand  

and

  On 12/23/2020 at 8:45 AM, DavidM said:

That method triggers on both the client and the server side. You will need to check the side with World#isRemote.

Expand