Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.4] what difference between custom slots and EquipmentSlotType


Recommended Posts

In my container class ive created slots 

private static final EquipmentSlotType[] VALID_EQUIPMENT_SLOTS = new EquipmentSlotType[]{EquipmentSlotType.HEAD, EquipmentSlotType.CHEST, EquipmentSlotType.LEGS, EquipmentSlotType.FEET};
 
en.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
     int index =0;
     for(int i = 8;i < 64;i+=18)
     {
         final EquipmentSlotType equipmentslottype = VALID_EQUIPMENT_SLOTS[index];
         addSlot(new SlotItemHandler(h,index,8,i)
         {
             public int getSlotStackLimit() {
                 return 1;
             }

             public boolean isItemValid(ItemStack stack) {
                 return stack.canEquip(equipmentslottype,en);
             }


             public boolean canTakeStack(PlayerEntity playerIn) {
                 ItemStack itemstack = this.getStack();
                 return !itemstack.isEmpty() && !playerIn.isCreative() && EnchantmentHelper.hasBindingCurse(itemstack) ? false : super.canTakeStack(playerIn);
             }

             @OnlyIn(Dist.CLIENT)
             public Pair<ResourceLocation, ResourceLocation> getBackground() {
                 return Pair.of(MyModContainer.LOCATION_BLOCKS_TEXTURE, MyModContainer.ARMOR_SLOT_TEXTURES[equipmentslottype.getIndex()]);
             }
         });
    index++;
     }
});

 

In my entity class i can use hadler to set and get my items from slots

    public ItemStackHandler handler;

    private ItemStackHandler getHandler()
    {
        if(handler == null)
        {
            handler = new ItemStackHandler(4);
        }
        return handler;
    }




    @Override
    public ILivingEntityData onInitialSpawn(IServerWorld worldIn, DifficultyInstance difficultyIn, SpawnReason reason, @Nullable ILivingEntityData spawnDataIn, @Nullable CompoundNBT dataTag) {
handler.setStackInSlot(0,new ItemStack(Items.DIAMOND_HELMET));




        return super.onInitialSpawn(worldIn, difficultyIn, reason, spawnDataIn, dataTag);
    }

 

But i cant get an itemstack from my handler from my layer model class. the game crashes. but i can get it from EquipmentSlotType but i dont need it because i store items in my container class slots

public class top1Layer  extends LayerRenderer<MyEntity, MobModel<MyEntity>> {
    private static final ResourceLocation TEXTURE_TOP1 = new ResourceLocation(Main.MODID,"textures/entity/mob/monster.png");

    public top1Layer(IEntityRenderer<MyEntity, MobModel<MyEntity>> entityRendererIn) {
        super(entityRendererIn);
    }





    @Override
    public void render(MatrixStack matrixStackIn, IRenderTypeBuffer bufferIn, int packedLightIn, MyEntity entitylivingbaseIn, float limbSwing, float limbSwingAmount, float partialTicks, float ageInTicks, float netHeadYaw, float headPitch) {
       ItemStack itemstack = entitylivingbaseIn.handler.getStackInSlot(0);
    }
}
Link to post
Share on other sites

All living entities already have an armor and held item inventory, you don't need to add it manually. Look at LivingEntity#getCapability, it will return you IItemHandler instances for those inventories.

Link to post
Share on other sites

Return here?

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
      
  return  LazyOptional.of(() -> (T) getHandler()); //Here?
    }
    return super.getCapability(cap, side);
}
Link to post
Share on other sites

those handlers ?

public <T> net.minecraftforge.common.util.LazyOptional<T> getCapability(net.minecraftforge.common.capabilities.Capability<T> capability, @Nullable Direction facing) {
   if (this.isAlive() && capability == net.minecraftforge.items.CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
      if (facing == null) return handlers[2].cast();
      else if (facing.getAxis().isVertical()) return handlers[0].cast();
      else if (facing.getAxis().isHorizontal()) return handlers[1].cast();
   }
   return super.getCapability(capability, facing);
}

 

Link to post
Share on other sites

Like this

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        return getCapability(cap,side).cast();
     
    }
    return super.getCapability(cap, side);
}
Link to post
Share on other sites

Like this?
 

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        super.getCapability(cap, side);
        return  LazyOptional.of(() -> (T) getHandler());
    }
    return super.getCapability(cap, side);
}
Link to post
Share on other sites

LazyOptional is just that: An optional value that is computed lazily.

 

4 minutes ago, Klarks said:

Do i need to return a list of ItemHandlers?

No, you need to create a combined IItemHandler by using CombinedInvWrapper.

This should not happen inside getCapability, you should create this handler and the LazyOptional once (in your class' constructor) and then just return the value in getCapability.

Link to post
Share on other sites

I guess i did it.

public <T> LazyOptional<T> create(LivingEntity entity)
{
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[2];
    ret[0] = LazyOptional.of(() ->  getHandler());
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
}
public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
      //  super.getCapability(cap, side).;
        return create(this);
    }
    return super.getCapability(cap, side);
}

 

But how would a slot know if its a default or a custom slot
 

en.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
    int index = 0;
    for(int i =8;i < 63;i+=18)
    {
        final EquipmentSlotType equipmentslottype = VALID_EQUIPMENT_SLOTS[index];
        addSlot(new SlotItemHandler(h,index,8,i){

            public int getSlotStackLimit() {
                return 1;
            }


            public boolean isItemValid(ItemStack stack) {
                return stack.canEquip(equipmentslottype, en);
            }

            public boolean canTakeStack(PlayerEntity playerIn) {
                ItemStack itemstack = this.getStack();
                return !itemstack.isEmpty() && !playerIn.isCreative() && EnchantmentHelper.hasBindingCurse(itemstack) ? false : super.canTakeStack(playerIn);
            }

            @OnlyIn(Dist.CLIENT)
            public Pair<ResourceLocation, ResourceLocation> getBackground() {
                return Pair.of(PlayerContainer.LOCATION_BLOCKS_TEXTURE, MyModContainer.ARMOR_SLOT_TEXTURES[equipmentslottype.getIndex()]);
            }
        });
        index++;
    }
});
Link to post
Share on other sites

You are not doing what I told you to do:

  1. You are not creating your handler and LazyOptional in the constructor.
  2. You are not using super.getCapability to get the default handlers.

Additionally:

  • Please use @Override when overriding methods.
  • Do not use @OnlyIn.
  • 20 minutes ago, Klarks said:

    for(int i =8;i < 63;i+=18)

    This is only four slots. Do you actually have any slots besides the armor and hand inventory?

Link to post
Share on other sites

I created now.

public MyEntity(EntityType<? extends MyEntity> type, World worldIn)
{
    super(type, worldIn);
   handler = getHandler();
    optional = create(this);
}


do i need this?

public <T> LazyOptional<T> create(LivingEntity entity)
{
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[2];
    ret[0] = LazyOptional.of(() ->  getHandler());
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
}

 

here i got default handler 
 

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        defHandler = (ItemStackHandler) super.getCapability(cap,side).orElse(null);
        return create(this);
    }
    return super.getCapability(cap, side);
}

public ItemStack func_213803_dV() {
    return this.getItemStackFromSlot(EquipmentSlotType.CHEST);
}

Am i going right?

Link to post
Share on other sites
31 minutes ago, Klarks said:

return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));

Why did you create two lazy optionals, then unbox them to pass into the CombinedInvWrapper?

(Not to mention using an array to store the local results? Why!?)

return LazyOptional.of(() -> (T)new CombinedInvWrapper(getHandler(), new EntityArmorInvWrapper(entity)));

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

Why i need cal super.getCapability? Is new EntityArmorInvWrapper(entity) doing same thing?

LivingEntity. it returns handlers which are LazyOptional<IItemHandlerModifiable>[] and they contains same things what i have already created

private final net.minecraftforge.common.util.LazyOptional<?>[] handlers = net.minecraftforge.items.wrapper.EntityEquipmentInvWrapper.create(this);


public <T> net.minecraftforge.common.util.LazyOptional<T> getCapability(net.minecraftforge.common.capabilities.Capability<T> capability, @Nullable Direction facing) {
   if (this.isAlive() && capability == net.minecraftforge.items.CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
      if (facing == null) return handlers[2].cast();
      else if (facing.getAxis().isVertical()) return handlers[0].cast();
      else if (facing.getAxis().isHorizontal()) return handlers[1].cast();
   }
   return super.getCapability(capability, facing);

 

EntityEquipmentInvWrapper

public static LazyOptional<IItemHandlerModifiable>[] create(LivingEntity entity)
{
    @SuppressWarnings("unchecked")
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[3];
    ret[0] = LazyOptional.of(() -> new EntityHandsInvWrapper(entity));
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    ret[2] = LazyOptional.of(() -> new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
    return ret;
}
Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Goals and Tasks are defined within the flyweight Entity itself whenever it is constructed. I would suggest taking a look at already implemented entities with goals and tasks if you want to implement them yourself.
    • Any mod present on the server (assuming it doesn't have the ignore extension point set) must be present on the client to allow both to connect.
    • Yes, you are passing in an Item instead of a supplier of an item. I would suggest taking another read over the docs.
    • Hi again, I'm trying to create a custom living entity but I keep running into this issue that causes a crash due to a ticking entity. Crash: [12:31:15] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception net.minecraft.crash.ReportedException: Ticking entity at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:855) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:787) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.integrated.IntegratedServer.tickServer(IntegratedServer.java:78) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:642) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:232) ~[forge:?] {re:classloading,pl:accesstransformer:B} at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282] {} Caused by: java.lang.NullPointerException at net.minecraft.entity.LivingEntity.travel(LivingEntity.java:1905) ~[forge:?] {re:classloading} at net.minecraft.entity.LivingEntity.aiStep(LivingEntity.java:2449) ~[forge:?] {re:classloading} at net.minecraft.entity.MobEntity.aiStep(MobEntity.java:488) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.entity.AgeableEntity.aiStep(AgeableEntity.java:115) ~[forge:?] {re:classloading} at net.minecraft.entity.passive.AnimalEntity.aiStep(AnimalEntity.java:51) ~[forge:?] {re:classloading} at net.minecraft.entity.LivingEntity.tick(LivingEntity.java:2158) ~[forge:?] {re:classloading} at net.minecraft.entity.MobEntity.tick(MobEntity.java:300) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.world.server.ServerWorld.tickNonPassenger(ServerWorld.java:611) ~[forge:?] {re:classloading} at net.minecraft.world.World.guardEntityTick(World.java:554) ~[forge:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.world.server.ServerWorld.tick(ServerWorld.java:404) ~[forge:?] {re:classloading} at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:851) ~[forge:?] {re:classloading,pl:accesstransformer:B} ... 5 more AL lib: (EE) alc_cleanup: 1 device not closed  It seems to be that I have not defined an ai/brain but I have no idea how to do this. I cant seem to see any event to do this in the library.  Any help would be greatly appreciated.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.