[1.16.4] Custom item enchantability

[AzizD 0]

I created a custom item that extends TieredItem. I want it to be enchantable through the enchantment table with Sharpnes, Looting etc. I can enchant but only the unbreaking enchantment shows up.

[Draco18s 2426]

There are functions that define this. The default checks what kind of item things are and allows or denies various enchantments.

TieredItem only allows Unbreaking (because that's the default).

[AzizD 0]

@Override
    public boolean canApplyAtEnchantingTable(ItemStack stack, Enchantment enchantment) {
        enchantment = Enchantments.SHARPNESS;
        return enchantment.canApply(stack.getItem().getDefaultInstance());
    }

I tried to override this method. Whenever i put the item in the enchantment table game crashes with java.lang.StackOverflowError.

[AzizD 0]

@Override
    public boolean canApplyAtEnchantingTable(ItemStack stack, Enchantment enchantment) {
        if(enchantment == Enchantments.SHARPNESS) {
            enchantment.canApply(stack);
        }
        return true;
    }

I changed with this but same error.

[kiou.23 26]

55 minutes ago, AzizD said:

@Override
    public boolean canApplyAtEnchantingTable(ItemStack stack, Enchantment enchantment) {
        if(enchantment == Enchantments.SHARPNESS) {
            enchantment.canApply(stack);
        }
        return true;
    }

I changed with this but same error.

well obviously, Enchantment#canApply(), calls ItemStack#CanApplyAtEnchantingTable(), which calls Item#canApplyAtEnchantingTable. Therefore, you got yourself an infinite loop...

[AzizD 0]

    @Override
    public boolean canApplyAtEnchantingTable(ItemStack stack, Enchantment enchantment) {
        Enchantment[] enchantments = {
                Enchantments.SHARPNESS,
                Enchantments.LOOTING,
                Enchantments.FIRE_ASPECT,
                Enchantments.UNBREAKING,
                Enchantments.KNOCKBACK,
                Enchantments.MENDING,
        };
        for(int i=0;i<enchantments.length;i++){
            if(enchantments[i] == enchantment){
                return true;
            }
        }
        return false;
    }

 

I wrote this and it worked. Thx.

[diesieben07 7797]

A better way would be to use a Set (probably ImmutableSet in this case).

[AzizD 0]

23 minutes ago, diesieben07 said:

A better way would be to use a Set (probably ImmutableSet in this case).

It looks way better. Thanks for the advice.

@Override
    public boolean canApplyAtEnchantingTable(ItemStack stack, Enchantment enchantment) {
        Set e = ImmutableSet.of(
                Enchantments.SHARPNESS,
                Enchantments.LOOTING,
                Enchantments.FIRE_ASPECT,
                Enchantments.UNBREAKING,
                Enchantments.KNOCKBACK
                );
        return e.contains(enchantment);
    }

 

[diesieben07 7797]

• Please don't use raw types.
• Store the Set in a field, don't create it every time.

[AzizD 0]

5 minutes ago, diesieben07 said:

• Please don't use raw types.
• Store the Set in a field, don't create it every time.

I got it.